Skip to content

Commit d12b361

Browse files
TMHSDigitalclaude
andcommitted
docs: note Go 1.26.0's false -race failures on Windows
Contributors on Windows should run race tests with GOTOOLCHAIN=go1.26.3; go.mod keeps go 1.26.0 as the minimum, which CI requires. Fixes #103 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent 5de1afc commit d12b361

2 files changed

Lines changed: 22 additions & 0 deletions

File tree

‎docs/CONTRIBUTING.md‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,17 @@ All pull requests must pass the full test suite, including the race detector:
156156
go test -v -race ./...
157157
```
158158

159+
On Windows, use Go 1.26.3 or later for race runs. Go 1.26.0 reports false
160+
data races there (between `context.WithTimeout` and the net package's DNS
161+
lookup goroutine) and can crash with `Exception 0xc0000005` in `scan.Run`;
162+
neither is a bug in subenum, and Linux, where CI runs `-race`, is not
163+
affected. `go.mod` keeps `go 1.26.0` as the minimum, so pick the toolchain
164+
per command:
165+
166+
```bash
167+
GOTOOLCHAIN=go1.26.3 go test -race ./...
168+
```
169+
159170
New features should include tests. New flags must be covered by at least one test case.
160171
Do not hit public resolvers. Use `-simulate` or the in-process DNS server in
161172
`internal/dnstest`, which answers from a per-query handler (records, RCODE,

‎docs/DEVELOPER_GUIDE.md‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,17 @@ To run all tests:
160160
go test -v -race ./...
161161
```
162162

163+
On Windows, use Go 1.26.3 or later for race runs. Go 1.26.0 reports false
164+
data races there (between `context.WithTimeout` and the net package's DNS
165+
lookup goroutine) and can crash with `Exception 0xc0000005` in `scan.Run`;
166+
neither is a bug in subenum, and Linux, where CI runs `-race`, is not
167+
affected. `go.mod` keeps `go 1.26.0` as the minimum, so pick the toolchain
168+
per command:
169+
170+
```bash
171+
GOTOOLCHAIN=go1.26.3 go test -race ./...
172+
```
173+
163174
Default `go test ./...` is hermetic (in-process DNS responder, no outbound
164175
network). The optional live resolver smoke test is gated on an env var:
165176

0 commit comments

Comments
 (0)