Skip to content

Commit b3ec7f2

Browse files
TMHSDigitalclaude
andcommitted
Docs: drop the manual GOTOOLCHAIN step for Windows race runs (#286)
Since #243, go.mod names toolchain go1.26.11, so a local Go older than that switches to the patched toolchain on its own. The Developer Guide and Contributing pages still told Windows contributors to set GOTOOLCHAIN=go1.26.3 per command, an extra step that also picked an older toolchain than the one go.mod asks for. Both pages now explain the Go 1.26.0 bug and that no workaround is needed unless GOTOOLCHAIN=local forces 1.26.0. Fixes #286 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent 152fecb commit b3ec7f2

2 files changed

Lines changed: 14 additions & 32 deletions

File tree

‎docs/CONTRIBUTING.md‎

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -167,22 +167,13 @@ All pull requests must pass the full test suite, including the race detector:
167167
go test -v -race ./...
168168
```
169169

170-
On Windows, use Go 1.26.3 or later for race runs. Go 1.26.0 reports false
171-
data races there (between `context.WithTimeout` and the net package's DNS
172-
lookup goroutine) and can crash with `Exception 0xc0000005` in `scan.Run`;
173-
neither is a bug in subenum, and Linux, where CI runs `-race`, is not
174-
affected. `go.mod` keeps `go 1.26.0` as the minimum, so pick the toolchain
175-
per command:
176-
177-
```bash
178-
GOTOOLCHAIN=go1.26.3 go test -race ./...
179-
```
180-
181-
In PowerShell:
182-
183-
```powershell
184-
$env:GOTOOLCHAIN = "go1.26.3"; go test -race ./...; Remove-Item Env:GOTOOLCHAIN
185-
```
170+
On Windows, Go 1.26.0 reports false data races (between
171+
`context.WithTimeout` and the net package's DNS lookup goroutine) and can
172+
crash with `Exception 0xc0000005` in `scan.Run`; neither is a bug in
173+
subenum, and Linux, where CI runs `-race`, is not affected. You need no
174+
workaround: `go.mod` names `toolchain go1.26.11`, so a local Go older than
175+
that switches to the patched toolchain by itself. The problem only comes
176+
back if you force Go 1.26.0 with `GOTOOLCHAIN=local`.
186177

187178
New features should include tests. New flags must be covered by at least one test case.
188179
Do not hit public resolvers. Use `-simulate` or the in-process DNS server in

‎docs/DEVELOPER_GUIDE.md‎

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -209,22 +209,13 @@ To run all tests:
209209
go test -v -race ./...
210210
```
211211

212-
On Windows, use Go 1.26.3 or later for race runs. Go 1.26.0 reports false
213-
data races there (between `context.WithTimeout` and the net package's DNS
214-
lookup goroutine) and can crash with `Exception 0xc0000005` in `scan.Run`;
215-
neither is a bug in subenum, and Linux, where CI runs `-race`, is not
216-
affected. `go.mod` keeps `go 1.26.0` as the minimum, so pick the toolchain
217-
per command:
218-
219-
```bash
220-
GOTOOLCHAIN=go1.26.3 go test -race ./...
221-
```
222-
223-
In PowerShell:
224-
225-
```powershell
226-
$env:GOTOOLCHAIN = "go1.26.3"; go test -race ./...; Remove-Item Env:GOTOOLCHAIN
227-
```
212+
On Windows, Go 1.26.0 reports false data races (between
213+
`context.WithTimeout` and the net package's DNS lookup goroutine) and can
214+
crash with `Exception 0xc0000005` in `scan.Run`; neither is a bug in
215+
subenum, and Linux, where CI runs `-race`, is not affected. You need no
216+
workaround: `go.mod` names `toolchain go1.26.11`, so a local Go older than
217+
that switches to the patched toolchain by itself. The problem only comes
218+
back if you force Go 1.26.0 with `GOTOOLCHAIN=local`.
228219

229220
Default `go test ./...` is hermetic (in-process DNS responder, no outbound
230221
network). The optional live resolver smoke test is gated on an env var:

0 commit comments

Comments
 (0)