You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 654f974
Browse filesBrowse the repository at this point in the historyBrowse files
Keep the inconclusive-name list only when something reads it (#300)
Every lookup that timed out, was refused or failed kept its name for
the whole scan, even when neither -inconclusive nor -retry-inconclusive
was set, so a scan against a failing resolver held one string per name.
scan.Config and scan.Options gain ListInconclusive. The engine collects
the names only for that or the retry pass, stores a wordlist entry as
its index, and fills Stats.Inconclusive only when the list was asked
for. The CLI asks for it with -inconclusive; pkg/subenum always does, so
library callers see no change. Counts are unaffected.
Co-Authored-By: Claude Mythos 5.2 <noreply@anthropic.com>
Fixes#300
Copy file name to clipboardExpand all lines: CHANGELOG.md
+1Lines changed: 1 addition & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -50,6 +50,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
50
50
-`-format json` streams its array instead of holding every result and then encoding the whole document, so its peak memory matches `-format jsonl` (a 300k-result run: about 200 MB instead of 420 MB). The output is byte for byte the same (#181).
51
51
- The wordlist is normalized once per run instead of once per `-dL` target: `wordlist.Prepare` normalizes the lines and `Prepared.For` applies only each target's 253-character limit. On a 1M-line list, normalizing takes about 0.5 s instead of 0.8 s with almost no allocations, and each further target about 0.5 ms. Results and counts are unchanged (#182).
52
52
- Tests no longer flake under load: lab end-to-end runs use a 5 s timeout with 3 attempts and fail with a clear message if the lab 2 wildcard probe times out, the resolver-pool spread test counts lookups per member instead of timing the scan (the timing view is now `BenchmarkPoolSpreadsLoad`), and CI runs tests in shuffled order (#167).
53
+
- The names whose lookup timed out, was refused or failed are kept only when something reads them: for the `-inconclusive` file, and until the `-retry-inconclusive` pass has run. A scan without either only counts them, so under `-no-abort` or `-auto-rate` against a failing resolver memory no longer grows with every failed lookup (about 1 GB at 10M failures). When they are kept, a wordlist entry costs its index rather than its name. Counts, the report and `pkg/subenum`'s `Stats.Inconclusive` are unchanged; the `-resume` state lists the names only with `-inconclusive` (#300).
53
54
54
55
### Fixed
55
56
- The TUI configuration form fits a terminal shorter than its 31 lines, such as the standard 80×24: the logo is dropped, then the field rows scroll to keep the focused field in view, with `↑ N more fields` and `↓ N more fields` lines for the rest. The validation error and the key hints are always shown, so a rejected ctrl+r no longer fails without a visible reason (#287).
***Recursive enumeration** (optional): when `Config.Recursive` is set and a job below the depth cap resolves, the worker first checks the new parent with `Lookup.CheckWildcard` (cached per parent; inconclusive results are not cached). A wildcard or inconclusive parent is not expanded and a `NoticeSkip` notice is emitted. Otherwise the parent is handed to the dispatcher, whose visited set deduplicates the children (loop and duplicate protection); the progress total grows as new work is admitted.
185
185
***Progress ticker**: A separate goroutine emits `EventProgress` once per second. The total is read atomically since recursion can expand it mid-scan.
186
186
***Rate limiter** (optional): one `dns.RateLimiter` paces the whole scan. Live scans attach it to the context with `dns.WithLimiter`, so every wire query takes a slot (see 2.3). Simulated scans have no wire traffic and take one slot per job. `0` means unlimited.
187
-
***Retry pass (`-retry-inconclusive`)**: workers record each name whose lookup timed out, was refused or failed. Once every worker has exited, `retryPending` looks each of them up once more against the trusted resolver, with up to `Concurrency` goroutines. A name that now resolves is reported like any other result but not expanded recursively. The pass is skipped after a guard abort, an interrupt or a spent `-max-duration`. `Stats.Retried` and `Stats.Recovered` count it, and the names still without an answer are listed in `Stats.Inconclusive` whether or not the pass ran.
187
+
***Retry pass (`-retry-inconclusive`)**: workers record each name whose lookup timed out, was refused or failed. Once every worker has exited, `retryPending` looks each of them up once more against the trusted resolver, with up to `Concurrency` goroutines. A name that now resolves is reported like any other result but not expanded recursively. The pass is skipped after a guard abort, an interrupt or a spent `-max-duration`. `Stats.Retried` and `Stats.Recovered` count it, and the names still without an answer are listed in `Stats.Inconclusive` whether or not the pass ran, when `Config.ListInconclusive` is set: the CLI sets it for `-inconclusive` and `pkg/subenum` always does. Without it and without the pass the names are only counted, and the pass alone drops them once it has run, so failed lookups do not hold memory for a list nobody reads. A wordlist entry is kept as its index (`pendingLookup`); only a recursive child keeps its name.
188
188
***Completion**: a `sync.WaitGroup` waits for all workers (after the dispatcher closes `jobs`), the optional retry pass runs, then the progress ticker is stopped and `EventDone` is emitted.
189
189
***Interactions**: `scan.Run` is the single entry point for scanning used by both the CLI output pipeline and the Bubble Tea TUI. It decouples the scan engine from any specific display layer.
0 commit comments