You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 43579aa
Browse filesBrowse the repository at this point in the historyBrowse files
Account for the -r pool in -dry-run's preflight and estimate (#376)
-dry-run built the -r pool but never used it: the preflight went only to
-dns-server and the duration estimate used only -rate, so a run capped by
-rate-per-resolver was planned as unlimited. Each pool resolver now gets
the target's preflight query too (dns.Pool.Probe, outside the rotation and
its accounting), reported per resolver as text "pool" lines and JSON
pool_preflight. The estimate uses min(-rate, -rate-per-resolver x pool
size), either term 0 meaning no bound, exposed as rate_effective. A failing
pool resolver does not fail the dry run, as a scan benches it.
The issue's -permute items (a seeds-only pass and custom permutation
words) need a flag name and behaviour decision and are left open.
Refs #376
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copy file name to clipboardExpand all lines: CHANGELOG.md
+1Lines changed: 1 addition & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -46,6 +46,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
46
46
- The GitHub Action gains three outputs: `changes`, the path of the JSONL file listing the added, removed and changed names (empty when there were no previous results to diff against), so a later step can open an issue or post them; `takeovers`, the number of takeover candidates found; and `internal`, the number of names answering with an address that is not public. The job summary table has a column for each count and lists the takeover candidates under it. `docs/monitoring.md` shows a step that opens an issue from `changes` (#311).
47
47
- The TUI's finished screen shows the run-quality verdict (`complete`, `degraded` or `unreliable`) with its reason above the counters, colored green, orange or red, so a scan that lost lookups or stopped at Max Duration no longer looks like a clean one. The counters line adds skipped candidates, retried and recovered names, takeover candidates and rate back-offs when there are any. The screen is the same height as before (#312).
48
48
-`pkg/subenum` exports `ProbeZone(ctx, domain, ZoneOptions)`, which tries a zone transfer (AXFR) from the domain's name servers with `-axfr`'s limits (8 servers, 2 addresses each) and reports the names, the servers that allowed it and whether the zone uses plain NSEC (`ZoneInfo`), and `ZoneTransfer(ZoneOptions)`, a `Source` for `Config.Sources` that scans the transferred names. Its queries are not paced by `Rate`, as `-axfr`'s are not. The CLI and the library share the attempt in a new `internal/axfr` package (#314).
49
+
-`-dry-run` takes the `-r` resolver pool into account: each pool resolver gets the target's preflight query too and has its own `pool` line (`pool_preflight` in JSON, with each resolver's `address`, `preflight` and `ok`), and the duration estimate uses `-rate-per-resolver` times the pool size when that is below `-rate` or `-rate` is unlimited, naming the flag that bounds it (`rate_effective` in JSON). A failing pool resolver does not fail the dry run, as a scan benches it and carries on (#376).
49
50
50
51
### Changed
51
52
- A `-recursive` scan over a wordlist of single labels no longer remembers every candidate it generated (about 75 MB per million), and one that reaches `-max-queries` or `-max-duration` counts the untested candidates without building each name, so it stops on time (#301).
Copy file name to clipboardExpand all lines: README.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -290,7 +290,7 @@ This table describes `main`, which can be ahead of the latest release: a release
290
290
|`-simulate-zone <file>`| n/a | Lab mode: answer every query from a scenario file, or a built-in scenario such as `lab1` (`lab1`-`lab6`, with their own wordlist when `-w` is not given), via a local DNS server on `127.0.0.1`; no traffic leaves the machine. See [Labs](docs/labs.md)|
291
291
|**Modes**|||
292
292
|`-tui`|`false`| Launch the interactive Terminal UI |
293
-
|`-dry-run`|`false`| Print the plan without scanning: candidates after dedupe and `-exclude`, query and duration estimates, and the resolver preflight (its only DNS query, paced by `-rate` and skipped for a target `-exclude` rules out), then exit; JSON with `-format json` or `jsonl`|
293
+
|`-dry-run`|`false`| Print the plan without scanning: candidates after dedupe and `-exclude`, query and duration estimates (at `-rate`, or `-rate-per-resolver` times the `-r` pool size when that is lower), and the resolver preflight (its only DNS query, also sent once to each `-r` pool resolver, paced by `-rate` and skipped for a target `-exclude` rules out; a failing pool resolver is reported but does not fail the run), then exit; JSON with `-format json` or `jsonl`|
294
294
|`-print-config`|`false`| Print every setting's effective value and source (`flag`, env, config or default), then exit |
Copy file name to clipboardExpand all lines: docs/_includes/flags.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -11,7 +11,7 @@
11
11
|`-diff <string>`| - | Previous results file (any -format); report only names added or removed since then, and exit 4 when there are changes |
12
12
|`-diff-records` {% include unreleased.html flag="diff-records" %} | - | With -diff, also report names whose records changed (a re-pointed CNAME, moved addresses), compared over the -type record types; needs a json, jsonl or csv -diff file |
13
13
|`-dns-server <string>`| 8.8.8.8:53 | DNS server: ip:port (UDP, TCP fallback), tls://host[:853] (DNS over TLS) or https://host/path (DNS over HTTPS) |
14
-
|`-dry-run` {% include unreleased.html flag="dry-run" %} | - | Print the plan without scanning: candidates after dedupe and -exclude, query and duration estimates, and the resolver preflight (its only DNS query); then exit |
14
+
|`-dry-run` {% include unreleased.html flag="dry-run" %} | - | Print the plan without scanning: candidates after dedupe and -exclude, query and duration estimates, and the resolver preflight (its only DNS query, also sent to each -r pool resolver); then exit |
15
15
|`-exclude <string>`| - | Comma-separated out-of-scope names and \*.parent patterns; never queried or expanded |
16
16
|`-exclude-file <string>`| - | File of out-of-scope names and \*.parent patterns, one per line (# comments allowed) |
17
17
|`-force`| - | Continue scanning even if wildcard DNS is detected |
fs.BoolVar(&f.tui, "tui", false, "Launch the interactive terminal UI, its form pre-filled from the other flags and the domain argument")
219
219
fs.BoolVar(&f.printConfig, "print-config", false, "Print every setting's effective value and its source (flag, env, config or default), then exit")
220
-
fs.BoolVar(&f.dryRun, "dry-run", false, "Print the plan without scanning: candidates after dedupe and -exclude, query and duration estimates, and the resolver preflight (its only DNS query); then exit")
220
+
fs.BoolVar(&f.dryRun, "dry-run", false, "Print the plan without scanning: candidates after dedupe and -exclude, query and duration estimates, and the resolver preflight (its only DNS query, also sent to each -r pool resolver); then exit")
221
221
fs.Var(&f.wordlists, "w", "Path to a wordlist `file` (- for stdin); repeat to combine several, deduplicated; omitted: the bundled top-5000 list")
222
222
fs.StringVar(&f.domainList, "dL", "", "File of apex domains to scan, one per line (- for stdin); replaces the <domain> argument")
223
223
fs.IntVar(&f.concurrency, "t", scan.DefaultConcurrency, "Number of concurrent workers")
0 commit comments