You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 3057e1e
Browse filesBrowse the repository at this point in the historyBrowse files
fix(dns): DoT pool liveness, DoH redirect/throttle handling, IPv6 tls://
- DoT: probe a pooled connection before reuse so one the server closed
no longer wastes a counted, paced query; keep up to 128 idle
connections; close idle DoT/DoH connections when a scan ends
(dns.CloseIdleConnections, weakly registered per resolver).
- DoH: never follow redirects (no cleartext downgrade); HTTP 429/503
classify as refused.
- tls://[IPv6] without a port is accepted; validate and the dialer share
validate.DoTAddress. Lab zone CNAME targets are validated and "@" means
the scanned domain.
- dnsserver.Close tracks and closes stream connections and waits for
every handler; CloseStreamsAfter for tests. New tests for untrusted DoT
certs, DoH redirects/throttling, stale pooled connections and the
server lifecycle.
Fixes#113Fixes#114Fixes#115Fixes#122
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copy file name to clipboardExpand all lines: CHANGELOG.md
+4Lines changed: 4 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -30,6 +30,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
30
30
- The minimum Go version is now 1.26 (`go 1.26.0` in go.mod), required by current `golang.org/x/sys` and `golang.org/x/text`; both were bumped and `govulncheck -show verbose` now reports no vulnerable modules. Dependabot also updates indirect modules, and CI lints with errorlint, nilerr, contextcheck, noctx, copyloopvar, usestdlibvars and revive, with errcheck exemptions narrowed to stdout prints (#83).
31
31
32
32
### Fixed
33
+
- DoT connection reuse is accurate: a pooled connection the server already closed is detected before reuse instead of failing a query that had already been counted and paced (a server closing after each answer cost 19 dials for 10 lookups; now 10). Up to 128 connections are kept, matching the default `-t`, and a scan closes its idle DoT and DoH connections when it ends, so a program that scans repeatedly through `pkg/subenum` does not hold them open (#113).
34
+
- DNS over HTTPS never follows a redirect, so a misconfigured endpoint or proxy cannot move the query elsewhere or downgrade it to cleartext `http://`; HTTP 429 and 503 count as `refused` (the rate-limit signal) instead of `other` (#114).
35
+
-`-dns-server tls://[2001:db8::1]` (a bracketed IPv6 host without a port) is accepted; the validator and the dialer now share one parser. Lab zone CNAME targets are validated, and `CNAME @` points at the scanned domain instead of the bogus `@.<domain>` (#115).
36
+
- The test DNS server's `Close` waits for every handler, closes open stream connections, and no longer returns while delayed UDP answers or connections parked on a dropped query are still running. New tests cover an untrusted DoT certificate, DoH redirects and throttling, stale pooled connections, a lying pool member and the server's own lifecycle (#122).
33
37
-`pkg/subenum.Run` no longer leaks the scan's worker pool when a caller breaks out of the event loop and cancels without draining (about 100 goroutines per run before): after cancellation the forwarder never waits for a reader, so every goroutine exits within about a second. `DefaultWords` parses the bundled list once, and a positive `Timeout` below 1ms is rounded up instead of being rejected as 0 (#112).
34
38
- A resolver pool member that answers NXDOMAIN for names that exist can no longer silently hide them. Each member is checked with canaries (names the trusted resolver confirmed, starting with the apex), and an NXDOMAIN from a member that has not passed a canary is confirmed by a second member. A member contradicted three times (a hidden name, a failed canary, or a hit the trusted resolver denies) is flagged and dropped for the rest of the run; the per-resolver report gains `canaries`, `contradicted` and `flagged`. In a hermetic test, one always-NXDOMAIN member previously hid half the real names; now none are lost. In a zone with no known name to use as a canary, NXDOMAIN answers cost a second pool query until one is found (#105).
35
39
-`-diff` no longer reports names this run never tested as removed. Every previous name the run did not find is looked up again with the trusted resolver, and only NXDOMAIN counts as removed; names that still resolve (a smaller wordlist, no `-recursive` or `-permute`, now wildcard-filtered) or whose lookup fails are counted as `still_resolving` and `unverified` in the report's `diff` object instead (#110).
0 commit comments