Skip to content

Commit 1be9a54

Browse files
TMHSDigitalclaude
andcommitted
docs(scan,output): correct two stale comments (#233)
runner.go said each job reports its completion as soon as it is done; since #184 a worker reports a whole chunk's completions in one send. SetTakeoverColumn said only CNAME lookups yield takeover hints; since #194 NS does too (dns.HintsTakeover), and that is what the CLI checks. Fixes #233 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent 2ff594c commit 1be9a54

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

‎internal/output/writer.go‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,8 @@ func diffPrefix(change string) string {
157157
}
158158

159159
// SetTakeoverColumn adds a takeover_candidate column to CSV output. The CLI
160-
// sets it when CNAME records are requested, the only case that yields hints.
160+
// sets it when CNAME or NS records are requested, the only cases that yield
161+
// hints (see dns.HintsTakeover).
161162
func (w *Writer) SetTakeoverColumn(on bool) { w.takeoverColumn = on }
162163

163164
// SetSeed records the simulation seed for the simulated-results file header.

‎internal/scan/runner.go‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -685,8 +685,9 @@ func Run(ctx context.Context, cfg Config, events chan<- Event) {
685685
// completed. Workers send found parents on enqueue (before signalling
686686
// completed) and the dispatcher expands them into depth-capped children.
687687
// Jobs go out in small chunks and both hand-off channels are buffered,
688-
// so workers and the dispatcher rarely block on each other (#184); each
689-
// job still reports its own completion as soon as it is done.
688+
// so workers and the dispatcher rarely block on each other (#184); a
689+
// worker reports the completions of a whole chunk in one send once the
690+
// chunk is done.
690691
workers := workerCount(cfg, maxDepth)
691692
jobs := make(chan []job, handoffPerWorker*workers)
692693
enqueue := make(chan job)

0 commit comments

Comments
 (0)