Skip to content

Commit 14a48f7

Browse files
committed
test(tui): cover saved config privacy and corrupt fallback
1 parent dd5b156 commit 14a48f7

2 files changed

Lines changed: 87 additions & 0 deletions

File tree

‎internal/tui/config_test.go‎

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package tui
22

33
import (
44
"os"
5+
"path/filepath"
56
"runtime"
67
"testing"
78
)
@@ -178,6 +179,43 @@ func TestLoadSavedConfigMissing(t *testing.T) {
178179
}
179180
}
180181

182+
func TestLoadSavedConfigCorrupt(t *testing.T) {
183+
for name, data := range map[string]string{
184+
"truncated": `{"domain":`,
185+
"invalid field type": `{"domain":"saved.example.com","concurrency":"many"}`,
186+
} {
187+
t.Run(name, func(t *testing.T) {
188+
redirectConfig(t)
189+
p, err := configPath()
190+
if err != nil {
191+
t.Fatal(err)
192+
}
193+
if err := os.MkdirAll(filepath.Dir(p), 0o700); err != nil {
194+
t.Fatal(err)
195+
}
196+
if err := os.WriteFile(p, []byte(data), 0o600); err != nil {
197+
t.Fatal(err)
198+
}
199+
if sc, ok := loadSavedConfig(); ok || sc != (savedConfig{}) {
200+
t.Fatalf("loadSavedConfig = %+v, %v; want empty config, false", sc, ok)
201+
}
202+
m := New(Options{})
203+
if m.state != stateForm {
204+
t.Fatalf("startup state = %v, want form", m.state)
205+
}
206+
defaults := newFormModel(savedConfig{})
207+
for f, spec := range formFields {
208+
if got, want := m.form.inputs[f].Value(), defaults.inputs[f].Value(); got != want {
209+
t.Errorf("%s = %q, want default %q", spec.name(), got, want)
210+
}
211+
if m.form.toggles[f] != defaults.toggles[f] {
212+
t.Errorf("%s = %v, want default %v", spec.name(), m.form.toggles[f], defaults.toggles[f])
213+
}
214+
}
215+
})
216+
}
217+
}
218+
181219
// TestSavedConfigSeedsForm verifies a saved config drives the form defaults,
182220
// which is what the `r` (new scan) keybind and startup rely on.
183221
func TestSavedConfigSeedsForm(t *testing.T) {

‎internal/tui/config_unix_test.go‎

Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
//go:build unix
2+
3+
package tui
4+
5+
import (
6+
"os"
7+
"path/filepath"
8+
"syscall"
9+
"testing"
10+
)
11+
12+
// The saved form can contain private file paths and resolver settings. Even a
13+
// permissive umask must not make it readable by other users (#413).
14+
func TestSaveConfigPrivatePermissions(t *testing.T) {
15+
// Umask is process-wide: keep this test and its subtests non-parallel.
16+
old := syscall.Umask(0)
17+
defer syscall.Umask(old)
18+
for _, existing := range []bool{false, true} {
19+
name := "new"
20+
if existing {
21+
name = "replace"
22+
}
23+
t.Run(name, func(t *testing.T) {
24+
redirectConfig(t)
25+
p, err := configPath()
26+
if err != nil {
27+
t.Fatal(err)
28+
}
29+
if existing {
30+
if err := os.MkdirAll(filepath.Dir(p), 0o700); err != nil {
31+
t.Fatal(err)
32+
}
33+
if err := os.WriteFile(p, []byte("{}"), 0o666); err != nil {
34+
t.Fatal(err)
35+
}
36+
}
37+
if err := saveConfig(savedConfig{Domain: "example.com"}); err != nil {
38+
t.Fatal(err)
39+
}
40+
info, err := os.Stat(p)
41+
if err != nil {
42+
t.Fatal(err)
43+
}
44+
if got := info.Mode().Perm(); got != 0o600 {
45+
t.Errorf("last.json mode = %04o with umask 000, want 0600", got)
46+
}
47+
})
48+
}
49+
}

0 commit comments

Comments
 (0)