Repository navigation
Commit 032f41f
Guard the flag trait maps and drop pacingFlags' bool copy (#402)
Six name-keyed maps decide what a flag does in config files, env vars,
resume and completion, and only fileFlags had a test that its keys are
real flags. A new test checks every key of noDefaultFlags, listFlags,
repeatFlags, unsavedSettings, pacingFlags and valueChoices against the
registered flags (-h and -help are the flag package's own), so a
renamed or misspelled flag fails CI.
pacingFlags' value restated whether each flag is boolean; it is now a
plain set, and pacingOverrides reads IsBoolFlag from the flags
themselves, as completion does.
Steps 1-2 of the issue; the optional single flagTraits table (step 3)
is not done.
Fixes #402
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>1 parent b9bc33c commit 032f41f
2 files changed
Lines changed: 40 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
| |||
330 | 331 | | |
331 | 332 | | |
332 | 333 | | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
333 | 360 | | |
334 | 361 | | |
335 | 362 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
245 | 245 | | |
246 | 246 | | |
247 | 247 | | |
248 | | - | |
| 248 | + | |
| 249 | + | |
249 | 250 | | |
250 | | - | |
251 | | - | |
| 251 | + | |
| 252 | + | |
252 | 253 | | |
253 | 254 | | |
254 | 255 | | |
| |||
354 | 355 | | |
355 | 356 | | |
356 | 357 | | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
357 | 365 | | |
358 | 366 | | |
359 | 367 | | |
360 | 368 | | |
361 | | - | |
362 | | - | |
| 369 | + | |
| 370 | + | |
363 | 371 | | |
364 | 372 | | |
365 | 373 | | |
| |||
0 commit comments