LoRa: preset verify fail blocks uploading new configs

[NArmistead]

Version/Project: 2.5.0

Describe the bug
During LoRa init (before entering the fsm), if a user uploads an invalid preset (specifically a frequency out of compliance), we go into an error state. Resetting the FC runs this check before any user input is possible, which prevents uploading a new preset or clearing the existing one.

To Reproduce
Steps to reproduce the behavior:

1. Upload an invalid LoRa preset
2. Reset the FC
3. Observe the flashing white and red LED and that USB can't be used

Expected behavior
There should be a way to reset the preset or upload a new one.

Screenshots/Pictures/Video
N/A

Additional context
None

Points of Contact
Telemetry SME: @ETSells
Rev 2 Project Lead: @NArmistead

[ETSells]

This is a LoRa app integration issue that has sadly only surfaced recently.

See the A0010 system security assessment for the definitions of severity/likelihood I use below.

Triage:
As a code change is required to return to standard operation every time this case is hit, this issue shall be considered high severity (S3).

The condition to reach this issue can be reached through normal & expected operation. We fail to validate inputs crossing the surface to the flight computer, and these inputs force the flight computer to crash if they fall outside an expected range. This requires physical access, so likelihood is the upper end of L2.

The security threat score for this issue is T1, with dependency analysis (N/A) and a security code review of its resolution recommended under the SSA for rev 3.

The impact of this issue is much higher at a functional level though, and inhibits users' ability to use the software without developer assistance.

Recommend this issue be prioritized at P1 and opened outside of CCB. I will implement the fix as part of #293.

[ETSells]

Now on integration/state-estims-telemetry.

Emulator builds have this weird runtime issue for me so I'm unable to test. @NArmistead, could you try to test the fix?

[ETSells]

Emulator bug found here has been reported at: SunDevilRocketry/sdr-emulator#64