Added experimental mode to jspecify nullability checks

These checks enable the new jdk nullability data, so nullable lib methods are properly annotated now

Author: MartelliEnrico

build.gradle.kts

@@ -62,11 +62,20 @@ val jlink = tasks.register<JlinkTask>(JlinkTask.DEFAULT_TASK_NAME) {
     javaCompiler = javaToolchains.compilerFor(java.toolchain)
 }
 
+nullability {
+    jspecify {
+        experimental = true
+    }
+}
+
 val CompileOptions.nullability: NullabilityOptions
-    get() = (this as ExtensionAware).extensions["nullability"] as NullabilityOptions
+    get() = (this as ExtensionAware).extensions.getByName("nullability") as NullabilityOptions
 
 tasks.named<JavaCompile>(JavaPlugin.COMPILE_TEST_JAVA_TASK_NAME) {
     options.nullability.checking = "tests"
+    options.nullability.jspecify {
+        experimental = true
+    }
 }
 
 tasks.test {

src/main/java/com/github/stickerifier/stickerify/bot/Stickerify.java

@@ -57,7 +57,7 @@
 public record Stickerify(TelegramBot bot, Executor executor) implements UpdatesListener, ExceptionHandler, AutoCloseable {
 
 	private static final StructuredLogger LOGGER = new StructuredLogger(Stickerify.class);
-	private static final String BOT_TOKEN = System.getenv("STICKERIFY_TOKEN");
+	private static final @Nullable String BOT_TOKEN = System.getenv("STICKERIFY_TOKEN");
 	private static final ThreadFactory VIRTUAL_THREAD_FACTORY = Thread.ofVirtual().name("Virtual-", 0).factory();
 	private static final InputRichMessage PROCESSING_MESSAGE = new InputRichMessage().html(PROCESSING.getText());
 

src/main/java/com/github/stickerifier/stickerify/process/OsConstants.java

@@ -1,7 +1,8 @@
 package com.github.stickerifier.stickerify.process;
 
 public final class OsConstants {
-	private static final boolean IS_WINDOWS = System.getProperty("os.name").toLowerCase().contains("windows");
+	private static final String OS = System.getenv().getOrDefault("os.name", "");
+	private static final boolean IS_WINDOWS = OS.toLowerCase().contains("windows");
 
 	public static final String NULL_FILE = IS_WINDOWS ? "NUL" : "/dev/null";
 

src/test/java/com/github/stickerifier/stickerify/ResourceHelper.java

@@ -10,7 +10,10 @@
 public final class ResourceHelper {
 
 	public static File loadResource(String filename) {
-		var resource = ResourceHelper.class.getClassLoader().getResource(filename);
+		var cl = ResourceHelper.class.getClassLoader();
+		assertNotNull(cl, "Classloader not found");
+
+		var resource = cl.getResource(filename);
 		assertNotNull(resource, "Test resource [%s] not found.".formatted(filename));
 
 		return new File(resource.getFile());

src/test/java/com/github/stickerifier/stickerify/junit/TempFilesCleanupExtension.java

@@ -20,6 +20,7 @@ public void afterAll(ExtensionContext context) throws IOException {
 
 	private void deleteTempFiles() throws IOException {
 		var tempFolder = System.getProperty("java.io.tmpdir");
+		if (tempFolder == null) return;
 
 		try (var files = Files.list(Path.of(tempFolder))) {
 			for (var file : files.toList()) {
@@ -31,7 +32,9 @@ private void deleteTempFiles() throws IOException {
 	}
 
 	private boolean isStickerifyFile(Path path) {
-		var fileName = path.getFileName().toString();
+		var file = path.getFileName();
+		if (file == null) return false;
+		var fileName = file.toString();
 
 		return Files.isRegularFile(path) && (fileName.startsWith("Stickerify-") || fileName.startsWith("OriginalFile-"));
 	}

src/test/java/com/github/stickerifier/stickerify/media/MediaHelperTest.java

@@ -5,6 +5,7 @@
 import static com.github.stickerifier.stickerify.media.MediaConstraints.MAX_IMAGE_FILE_SIZE;
 import static com.github.stickerifier.stickerify.media.MediaConstraints.MAX_VIDEO_FILE_SIZE;
 import static com.github.stickerifier.stickerify.media.MediaConstraints.VP9_CODEC;
+import static java.util.Objects.requireNonNullElse;
 import static java.util.concurrent.Executors.newVirtualThreadPerTaskExecutor;
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.Matchers.equalTo;
@@ -352,7 +353,7 @@ private static void executeConcurrentConversionsOf(File inputFile) {
 						MediaHelper.convert(inputFile);
 					} catch (Throwable e) {
 						failedConversions.incrementAndGet();
-						failureReasons.add(e.getMessage());
+						failureReasons.add(requireNonNullElse(e.getMessage(), e.getClass().getSimpleName()));
 					}
 				}));
 			}