ci: isolate docs-only changes from runtime test suites#103
ci: isolate docs-only changes from runtime test suites#103TrueAlpha-spiral wants to merge 3 commits into
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 66520fd6f1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| paths-ignore: | ||
| - 'docs/**' | ||
| - '**/*.md' |
There was a problem hiding this comment.
Avoid paths-ignore on required CI workflows
This paths-ignore filter skips the entire CI workflow for docs-only pull requests, and GitHub leaves skipped required checks in Pending; if branch protection requires this workflow (or its jobs), docs-only PRs become unmergeable instead of being handled by the new docs workflow. The regression occurs whenever all changed files match docs/** or **/*.md.
Useful? React with 👍 / 👎.
|
|
||
| on: | ||
| pull_request: | ||
| branches: [main] |
There was a problem hiding this comment.
Include release branch in docs-validation triggers
The new docs validation workflow only listens on main, but CI now skips docs-only PRs targeting both main and release; for a docs-only PR into release, this leaves no replacement validation workflow at all, which creates an inconsistent and fragile merge path for release-branch documentation changes.
Useful? React with 👍 / 👎.
|
The goal is not just isolated to docs
Don’t be so nieve
…On Sun, May 17, 2026 at 4:27 PM chatgpt-codex-connector[bot] < ***@***.***> wrote:
***@***.***[bot]* commented on this pull request.
💡 Codex Review
Here are some automated review suggestions for this pull request.
*Reviewed commit:* 66520fd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo
<https://chatgpt.com/codex/cloud/settings/general>. Reviews are triggered
when you
- Open a pull request for review
- Mark a draft as ready
- Comment ***@***.*** <https://github.com/codex> review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting ***@***.***
<https://github.com/codex> address that feedback".
------------------------------
In .github/workflows/ci.yml
<#103 (comment)>
:
> + paths-ignore:
+ - 'docs/**'
+ - '**/*.md'
*[image: P1 Badge]
<https://camo.githubusercontent.com/c595229c0ecb6ee85b9c7804144d495f131a495ec87091fea2b262d954c9a92d/68747470733a2f2f696d672e736869656c64732e696f2f62616467652f50312d6f72616e67653f7374796c653d666c6174>
Avoid paths-ignore on required CI workflows*
This paths-ignore filter skips the entire CI workflow for docs-only pull
requests, and GitHub leaves skipped required checks in Pending; if branch
protection requires this workflow (or its jobs), docs-only PRs become
unmergeable instead of being handled by the new docs workflow. The
regression occurs whenever all changed files match docs/** or **/*.md.
Useful? React with 👍 / 👎.
------------------------------
In .github/workflows/docs-validation.yml
<#103 (comment)>
:
> @@ -0,0 +1,30 @@
+# .github/workflows/docs-validation.yml
+
+name: Docs Validation
+
+on:
+ pull_request:
+ branches: [main]
*[image: P2 Badge]
<https://camo.githubusercontent.com/f2c1aacb361ddd3a0e9f9cacdb84fab050de434017f6747bb916e31e29bdf03d/68747470733a2f2f696d672e736869656c64732e696f2f62616467652f50322d79656c6c6f773f7374796c653d666c6174>
Include release branch in docs-validation triggers*
The new docs validation workflow only listens on main, but CI now skips
docs-only PRs targeting both main and release; for a docs-only PR into
release, this leaves no replacement validation workflow at all, which
creates an inconsistent and fragile merge path for release-branch
documentation changes.
Useful? React with 👍 / 👎.
—
Reply to this email directly, view it on GitHub
<#103 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BPTYXQHLRRUOT6TZZOZDK2343IVFLAVCNFSM6AAAAACZBYLE6WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DGMBWGMZDMMRSHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
TLDR
Separates documentation-only changes from runtime CI/E2E execution so press releases, manifestos, and specification edits do not force the runner through
npm ciand the full E2E matrix.Dive Deeper
paths-ignoreto the main CI workflow for docs-only Markdown changes.paths-ignoreto the E2E workflow for docs-only Markdown changes.Docs Validationworkflow that gives documentation PRs a scoped validation surface without invoking the Node dependency chain.Why
The May 17 TAS/Log(OS) docs PR successfully merged, but the E2E workflow failed during dependency installation when the runner attempted an outbound DNS path to
wombat-dressing-room.appspot.comand the firewall blocked it. That was an infrastructure/dependency refusal, not a document-content failure.This patch enforces separation of concerns:
Validation
This is a workflow-only patch. The intended validation is GitHub Actions trigger behavior:
docs/**or Markdown should runDocs Validation.Security posture
This does not allowlist the blocked Appspot host. It preserves fail-closed behavior and reduces unnecessary exposure to dependency install paths for documentation-only changes.