From e55eaecc62d8df32665c4aa4ba398501fe08d2ea Mon Sep 17 00:00:00 2001 From: bigcupcoffee <24373206+bigcupcoffee@users.noreply.github.com> Date: Sat, 29 Aug 2026 21:08:26 +0300 Subject: [PATCH 1/4] add proguard-rules.pro --- packages/skia/android/proguard-rules.pro | 1 + 1 file changed, 1 insertion(+) create mode 100644 packages/skia/android/proguard-rules.pro diff --git a/packages/skia/android/proguard-rules.pro b/packages/skia/android/proguard-rules.pro new file mode 100644 index 0000000000..7d89532d7d --- /dev/null +++ b/packages/skia/android/proguard-rules.pro @@ -0,0 +1 @@ +-keep class com.shopify.reactnative.skia.** { *; } From f44cae4755a1b0fa766388373cb71a2234f37f0a Mon Sep 17 00:00:00 2001 From: bigcupcoffee <24373206+bigcupcoffee@users.noreply.github.com> Date: Sat, 29 Aug 2026 21:09:36 +0300 Subject: [PATCH 2/4] wire consumerProguardFiles --- packages/skia/android/build.gradle | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/skia/android/build.gradle b/packages/skia/android/build.gradle index 357647ab0c..e9a35b2b6c 100644 --- a/packages/skia/android/build.gradle +++ b/packages/skia/android/build.gradle @@ -215,6 +215,8 @@ android { versionName "1.0" buildConfigField "boolean", "IS_NEW_ARCHITECTURE_ENABLED", isNewArchitectureEnabled().toString() + consumerProguardFiles 'proguard-rules.pro' + externalNativeBuild { cmake { cppFlags "-fexceptions", "-frtti", "-std=c++1y", "-DONANDROID" From 0bb6fd2fdd93600b4e05372fe53a0a0744cbc501 Mon Sep 17 00:00:00 2001 From: bigcupcoffee <24373206+bigcupcoffee@users.noreply.github.com> Date: Sat, 29 Aug 2026 21:11:01 +0300 Subject: [PATCH 3/4] Delete Proguard section from installation.md --- apps/docs/docs/getting-started/installation.md | 8 -------- 1 file changed, 8 deletions(-) diff --git a/apps/docs/docs/getting-started/installation.md b/apps/docs/docs/getting-started/installation.md index 72453b04a8..239752b1cb 100644 --- a/apps/docs/docs/getting-started/installation.md +++ b/apps/docs/docs/getting-started/installation.md @@ -62,14 +62,6 @@ If the NDK is not installed, you can install it via Android Studio by going to t And then the _SDK Location_ section. It will show you the NDK path, or the option to download it if you don't have it installed. -### Proguard - -If you're using Proguard, make sure to add the following rule at `proguard-rules.pro`: - -``` --keep class com.shopify.reactnative.skia.** { *; } -``` - ### TroubleShooting For error **_CMake 'X.X.X' was not found in SDK, PATH, or by cmake.dir property._** From b1b668a4a77533b7113c5c5230ba681afd4d2dc2 Mon Sep 17 00:00:00 2001 From: William Candillon Date: Sun, 30 Aug 2026 17:16:33 +0200 Subject: [PATCH 4/4] =?UTF-8?q?fix(=F0=9F=A4=96):=20publish=20proguard-rul?= =?UTF-8?q?es.pro=20to=20npm?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The `files` whitelist enumerates the Android files individually, so `android/proguard-rules.pro` was excluded from the published tarball while build.gradle referenced it via consumerProguardFiles. Co-Authored-By: Claude Opus 5 (1M context) --- packages/skia/package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/skia/package.json b/packages/skia/package.json index 815dcb70bc..cd6e0f06ae 100644 --- a/packages/skia/package.json +++ b/packages/skia/package.json @@ -22,6 +22,7 @@ "README.md", "LICENSE.md", "android/build.gradle", + "android/proguard-rules.pro", "android/CMakeLists.txt", "android/cpp/**", "android/src/**",