Skip to content

Commit 4c7adde

Browse files
marknolanclaude
andcommitted
DEV-793 Fix stale containsKey wording in gap-window comment (Copilot review)
The first paragraph still described the pre-fix containsKey-guarded / first-payload seeding, contradicting the unconditional-put explanation below it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent c7415b5 commit 4c7adde

1 file changed

Lines changed: 7 additions & 8 deletions

File tree

ShimmerDriver/src/main/java/com/shimmerresearch/verisense/payloaddesign/PayloadContentsDetailsV8orAbove.java

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -381,14 +381,13 @@ private void refineSlowSensorSamplingRateFromBlockTicks(DATABLOCK_SENSOR_ID slow
381381
// exposure + dead time: ~100 vs ~110 ms at the default exposure) and the
382382
// MLX90632's conversions can slip by several refresh periods and then catch
383383
// up (observed +12.5% block spacing with no samples lost - DEV-927
384-
// validation data). Because this seeding is containsKey-guarded, it comes
385-
// from the FIRST payload with >= 2 blocks - often a single inter-block gap,
386-
// i.e. no spread information - so the gap side of the window cannot rely on
387-
// observed spread at all: it is set to tolerate anything up to
388-
// SLOW_SENSOR_MAX_INTER_BLOCK_GAP_RATIO x the achieved median spacing, which
389-
// keeps healthy jitter continuous while a genuinely dropped block (2x
390-
// spacing) still splits. The fast side keeps the observed-minimum-period
391-
// basis with the standard tolerance.
384+
// validation data). A single payload carries only 2-3 slow-sensor blocks,
385+
// i.e. one or two inter-block gaps - no spread information - so the gap
386+
// side of the window cannot rely on observed spread at all: it is set to
387+
// tolerate anything up to SLOW_SENSOR_MAX_INTER_BLOCK_GAP_RATIO x the
388+
// achieved median spacing, which keeps healthy jitter continuous while a
389+
// genuinely dropped block (2x spacing) still splits. The fast side keeps
390+
// the observed-minimum-period basis with the standard tolerance.
392391
// The put is deliberately UNCONDITIONAL: the limits map is global across
393392
// payloads, and a payload with fewer than two blocks of this sensor (early
394393
// return above - e.g. the very first payload of a recording) leaves

0 commit comments

Comments
 (0)