fix(install): rebase onto main — renumber uninstall/lifecycle codes around #479 (AB7006→AB7009, AB7325→AB7328); write the Claude receipt before the load verdict

Author: ScriptedAlchemy

packages/agent-bundle/src/install/install.ts

@@ -372,10 +372,9 @@ export const parsePublicHostInventory = (
       }
       if (options.scope !== undefined && row['scope'] !== options.scope) continue;
       const errors = claudePluginRowErrors(row);
-      entries.push({
-        ...(errors.length === 0 ? {} : { errors }),
       entries.push({
         ...(typeof row['enabled'] === 'boolean' ? { enabled: row['enabled'] } : {}),
+        ...(errors.length === 0 ? {} : { errors }),
         installPath: row['installPath'],
         scope: row['scope'],
         version: row['version'],

packages/agent-bundle/tests/install.test.ts

@@ -385,26 +385,30 @@ it('fails a Claude install (AB7006) when plugin list --json reports load errors
       listings += 1;
       return listings === 1 ? '[]' : claudeRefusedInventory(installed);
     });
-    const error = await installBundle({ commandRunner: fresh.runner, from: fixture.from, host: 'claude', scope: 'user' })
+    const error = await installBundle({ ...isolated(fixture), commandRunner: fresh.runner, from: fixture.from, host: 'claude', scope: 'user' })
       .catch((failure: unknown) => failure);
     expect(error).toBeInstanceOf(DiagnosticError);
     const [diagnostic] = (error as DiagnosticError).diagnostics;
     expect(diagnostic).toMatchObject({ code: 'AB7006', severity: 'error', target: 'claude' });
     expect(diagnostic?.message).toContain(`claude refused to load install-fixture@install-fixture-marketplace (version 1.2.3) at ${JSON.stringify(installed)} (scope user) after installation`);
     expect(diagnostic?.message).toContain('Duplicate hooks file detected');
     expect(diagnostic?.message).toContain('--replace');
+    // The receipt lands before the load verdict, so the refused copy stays receipt-owned for `uninstall`.
     expect(fresh.calls.map((call) => call.args.join(' '))).toEqual([
       'plugin list --json',
+      'plugin marketplace list --json',
       `plugin marketplace add ${fixture.bundleRoot}`,
       'plugin install install-fixture@install-fixture-marketplace --scope user',
       'plugin list --json',
     ]);
+    expect(await readInstallReceiptFile(join(fixture.cleanupRoot, 'claude-config', 'agent-bundle', 'receipts', 'install-fixture.user.json')))
+      .toMatchObject({ plugin: 'install-fixture', scope: 'user' });
 
     // A byte-identical copy the host already refuses is never "already installed": reinstalling the same
     // bytes cannot help, so the defect is reported instead of a success.
     await cp(fixture.bundleRoot, installed, { recursive: true });
     const identical = recordingRunner((call) => isInventoryCall(call) ? claudeRefusedInventory(installed) : '');
-    const existing = await installBundle({ commandRunner: identical.runner, from: fixture.from, host: 'claude', scope: 'user' })
+    const existing = await installBundle({ ...isolated(fixture), commandRunner: identical.runner, from: fixture.from, host: 'claude', scope: 'user' })
       .catch((failure: unknown) => failure);
     expect(existing).toBeInstanceOf(DiagnosticError);
     expect((existing as DiagnosticError).diagnostics[0]).toMatchObject({ code: 'AB7006', target: 'claude' });
@@ -413,7 +417,7 @@ it('fails a Claude install (AB7006) when plugin list --json reports load errors
 
     // Healthy rows (no `errors` key) keep the install result unchanged.
     const healthy = recordingRunner((call) => isInventoryCall(call) ? claudeInventory(installed) : '');
-    await expect(installBundle({ commandRunner: healthy.runner, from: fixture.from, host: 'claude', scope: 'user' }))
+    await expect(installBundle({ ...isolated(fixture), commandRunner: healthy.runner, from: fixture.from, host: 'claude', scope: 'user' }))
       .resolves.toMatchObject({ state: 'already-installed' });
   } finally {
     await rm(fixture.cleanupRoot, { force: true, recursive: true });