fix: green main after #656/#664 — ignore package-build compile staging in dev, update superseded test contracts

Author: ScriptedAlchemy

.changeset/dev-package-build-stage-watch.md

@@ -0,0 +1,5 @@
+---
+"agent-bundle": patch
+---
+
+Fix `agent-bundle dev` republishing a fresh epoch after every npm-root package build: the package build's compile staging directory now uses the `.<output>.stage-` name the source watcher already ignores, so a project with a `bin` or `lib` no longer sees a spurious rebuild (and a lost operator `.env` layer) seconds after each publish (#666)

packages/agent-bundle/src/build/package-build.ts

@@ -388,8 +388,11 @@ export const buildPackageOutputs = async (options: {
 
   const stageParent = dirname(outputRoot);
   await mkdir(stageParent, { recursive: true });
+  // Both share the `.<output>.stage-` prefix the dev watcher treats as build
+  // output (`dev/watcher.ts` `isOutputStagingPath`); any other sibling name
+  // invalidates the epoch the package build just followed.
   const stageRoot = await mkdtemp(join(stageParent, `.${basename(outputRoot)}.stage-`));
-  const compileRoot = await mkdtemp(join(stageParent, `.${basename(outputRoot)}.compile-`));
+  const compileRoot = await mkdtemp(join(stageParent, `.${basename(outputRoot)}.stage-`));
   try {
     const ignoredRuntimeRoots = Object.freeze([...new Set([
       ...(entries.some((entry) => entry.aliases?.[terminalCapabilityRuntimeSpecifier] !== undefined)

packages/agent-bundle/tests/prepack.test.ts

@@ -427,14 +427,16 @@ it('reports git, GitHub-shorthand, remote-tarball, and path dependency specifier
     };
   },
   async () => {
-    await mkdir(join(projectRoot, 'vendor', 'vendored'), { recursive: true });
-    await mkdir(join(projectRoot, 'vendor', 'bad-manifest'), { recursive: true });
+    // `file:` sources resolve inside the packed npm root (`dist`), not the project.
+    const vendor = join(projectRoot, 'dist', 'vendor');
+    await mkdir(join(vendor, 'vendored'), { recursive: true });
+    await mkdir(join(vendor, 'bad-manifest'), { recursive: true });
     await Promise.all([
-      writeFile(join(projectRoot, 'vendor', 'vendored', 'package.json'), '{ "name": "vendored", "version": "1.0.0" }\n'),
-      writeFile(join(projectRoot, 'vendor', 'bad-manifest', 'package.json'), '{\n'),
-      writeFile(join(projectRoot, 'vendor', 'tarred.tgz'), packageTarball('{ "name": "tarred", "version": "1.0.0" }')),
-      writeFile(join(projectRoot, 'vendor', 'bad-tarred-manifest.tgz'), packageTarball('not json\n')),
-      writeFile(join(projectRoot, 'vendor', 'not-archive.tgz'), 'not a tarball\n'),
+      writeFile(join(vendor, 'vendored', 'package.json'), '{ "name": "vendored", "version": "1.0.0" }\n'),
+      writeFile(join(vendor, 'bad-manifest', 'package.json'), '{\n'),
+      writeFile(join(vendor, 'tarred.tgz'), packageTarball('{ "name": "tarred", "version": "1.0.0" }')),
+      writeFile(join(vendor, 'bad-tarred-manifest.tgz'), packageTarball('not json\n')),
+      writeFile(join(vendor, 'not-archive.tgz'), 'not a tarball\n'),
     ]);
     const pack = { ...result.pack, files: [...result.pack.files,
       { path: 'node_modules/embedded/package.json' },
@@ -466,7 +468,7 @@ it('reports git, GitHub-shorthand, remote-tarball, and path dependency specifier
     for (const name of ['alias', 'tilde', 'versioned', 'embedded', 'vendored', 'tarred']) {
       expect(reported[0]?.message).not.toContain(JSON.stringify(name));
     }
-    await rm(join(projectRoot, 'vendor'), { force: true, recursive: true });
+    await rm(vendor, { force: true, recursive: true });
     expect(reported[0]?.recovery).toContain('registry');
 
     const underPnpm = withCode(await diagnostics(pack, true), 'AB7015');
@@ -600,20 +602,13 @@ it('reads an installed manifest as npm does, so the last of duplicate name keys
 it('prepack succeeds and surfaces the warning when the only finding is an unresolvable optional dependency', () => withPackageDocument(
   (document) => {
     document.optionalDependencies = { 'optional-native': 'github:owner/optional-native' };
-    // The build rewrites dist, so the packed declaration that references the optional package lives in its own
-    // packed directory; an install script running it instead would make the failed fetch fatal.
-    document.files = [...(document.files as readonly string[]), 'extras'];
+    // The generated npm root carries only emitted files, so the evidence that keeps the optional package out of
+    // AB7014 is a consumer install script that mentions it; one that ran it would make the failed fetch fatal.
+    document.scripts = { ...(document.scripts as Record<string, string> | undefined), postinstall: 'echo optional-native' };
   },
   async () => {
-    const extras = join(projectRoot, 'extras');
-    await mkdir(extras, { recursive: true });
-    await writeFile(join(extras, 'optional.d.ts'), 'export type { Native } from "optional-native";\n');
-    try {
-      const packed = await prepack({ root: projectRoot });
-      expect(packed.diagnostics.map((diagnostic) => [diagnostic.code, diagnostic.severity])).toEqual([['AB7015', 'warning']]);
-    } finally {
-      await rm(extras, { force: true, recursive: true });
-    }
+    const packed = await prepack({ root: projectRoot });
+    expect(packed.diagnostics.map((diagnostic) => [diagnostic.code, diagnostic.severity])).toEqual([['AB7015', 'warning']]);
   },
 ));
 
@@ -638,7 +633,7 @@ it('accepts a dependency that only packed declaration files reference, including
     // A `#` specifier reaches the package the imports map names.
     await writeFile(modern, 'export type { Driver } from "#driver";\n');
     try {
-      const pack = { ...result.pack, files: [...result.pack.files, { path: 'dist/consumer.d.ts' }, { path: 'dist/driver.d.mts' }] };
+      const pack = { ...result.pack, files: [...result.pack.files, { path: 'consumer.d.ts' }, { path: 'driver.d.mts' }] };
       const [reported] = withCode(await diagnostics(pack), 'AB7014');
       expect(reported?.message).toContain('"never-loaded"');
       for (const name of ['zod', '@types/node', 'driver-package']) expect(reported?.message).not.toContain(JSON.stringify(name));

packages/agent-bundle/tests/route-register-typegen.test.ts

@@ -172,8 +172,8 @@ it('types every route-aware public surface from the generated route registration
       "export type FindResult = Assert<Equal<RegisteredRouteResult<'tool:curator/find'>, { hits: number }>>;",
       "export type Unregistered = Assert<Equal<RegisteredRouteInput<'tool:curator/missing'>, unknown>>;",
       '// An event route registers the harness payload — the component props without the `signal` the harness',
-      '// injects — and no result, since event modules export no resultSchema.',
-      "export type EventInput = Assert<Equal<keyof RegisteredRouteInput<'event:tool/after'>, 'canonical' | 'native'>>;",
+      '// injects, including the optional preflight `data` (#661) — and no result, since event modules export no resultSchema.',
+      "export type EventInput = Assert<Equal<keyof RegisteredRouteInput<'event:tool/after'>, 'canonical' | 'native' | 'preflight'>>;",
       "export type EventCanonical = Assert<Equal<RegisteredRouteInput<'event:tool/after'>['canonical'], AgentEventCanonicalIdentity<'tool/after'>>>;",
       '// The route\'s family narrows `canonical.payload`: tool/after fields are present, stop-only fields are not.',
       "export type EventPayload = Assert<Equal<RegisteredRouteInput<'event:tool/after'>['canonical']['payload'], AgentEventPayload<'tool/after'>>>;",