From fdec022033db1ed9862d4211766eb1fe346bcf63 Mon Sep 17 00:00:00 2001 From: ChrisRackauckas-Claude Date: Sun, 14 Jun 2026 04:49:38 -0400 Subject: [PATCH] Canonicalize remaining plain @testset units to @safetestset Convert the independent test units in test/runtests.jl that were still plain `@testset "X" begin include(...) end` into `@safetestset` so each runs in its own module (isolation + world-age safety), matching the already-canonical units in this suite. Converted: GPU Kernelized Non Stiff ODE Regression, GPU Kernelized Stiff ODE Regression, Lower level API, and the four nested units inside the "Callbacks" group (Non Stiff/Stiff ODE ContinuousCallback, SDE Regression, SDE Convergence). The included files are already self-contained (own `using` lines + shared utils.jl include), so no file edits were needed; SafeTestsets injects `using Test` into each module so the bare `@test` calls resolve. Left "Distributed Multi-GPU" as a plain `@testset` (distributed addprocs/@everywhere does not play nicely with modules, as noted in the file). Kept the "Callbacks" outer grouping `@testset` as a wrapper and the GROUP-dispatch ladder unchanged. SafeTestsets is already a test dep. Co-Authored-By: Chris Rackauckas Co-Authored-By: Claude Opus 4.8 (1M context) --- test/runtests.jl | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/test/runtests.jl b/test/runtests.jl index ce5d4e37..0ef9fe74 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -35,13 +35,13 @@ end @time @safetestset "GPU Kernelized DAE Mass Matrix" begin include("gpu_kernel_de/stiff_ode/gpu_ode_modelingtoolkit_dae.jl") end -@time @testset "GPU Kernelized Non Stiff ODE Regression" begin +@time @safetestset "GPU Kernelized Non Stiff ODE Regression" begin include("gpu_kernel_de/gpu_ode_regression.jl") end @time @safetestset "GPU Kernelized Non Stiff ODE DiscreteCallback" begin include("gpu_kernel_de/gpu_ode_discrete_callbacks.jl") end -@time @testset "GPU Kernelized Stiff ODE Regression" begin +@time @safetestset "GPU Kernelized Stiff ODE Regression" begin include("gpu_kernel_de/stiff_ode/gpu_ode_regression.jl") end @time @safetestset "GPU Kernelized Stiff ODE DiscreteCallback" begin @@ -86,7 +86,7 @@ if GROUP in SUPPORTS_DOUBLE_PRECISION include("reduction.jl") end - @time @testset "Lower level API" begin + @time @safetestset "Lower level API" begin include("lower_level_api.jl") end @@ -105,17 +105,17 @@ end if GROUP == "CUDA" @testset "Callbacks" begin # Causes dynamic function invocation - @time @testset "GPU Kernelized Non Stiff ODE ContinuousCallback" begin + @time @safetestset "GPU Kernelized Non Stiff ODE ContinuousCallback" begin include("gpu_kernel_de/gpu_ode_continuous_callbacks.jl") end - @time @testset "GPU Kernelized Stiff ODE ContinuousCallback" begin + @time @safetestset "GPU Kernelized Stiff ODE ContinuousCallback" begin include("gpu_kernel_de/stiff_ode/gpu_ode_continuous_callbacks.jl") end # device Random not implemented yet - @time @testset "GPU Kernelized SDE Regression" begin + @time @safetestset "GPU Kernelized SDE Regression" begin include("gpu_kernel_de/gpu_sde_regression.jl") end - @time @testset "GPU Kernelized SDE Convergence" begin + @time @safetestset "GPU Kernelized SDE Convergence" begin include("gpu_kernel_de/gpu_sde_convergence.jl") end end