Feat: Week6/nonshaman-m2#60
Open
nonshaman wants to merge 14 commits into
Open
Conversation
Feat: Week3/nonshaman m1
feat: 3주차 미션 2 진행 (fix)
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
yewon20804
reviewed
May 12, 2026
Collaborator
yewon20804
left a comment
There was a problem hiding this comment.
6주차 두번째 미션 확인했습니다 ! useInfiniteQuery + react-intersection-observer로 무한스크롤 잘 구현해주셨고, 스켈레톤 UI도 컴포넌트 분리까지 깔끔하게 작업해주셨네요 👍 아래 코멘트 확인해주세요 !
1. lp.ts — authorld 오타
// week4/mission02/src/types/lp.ts
// 현재
authorld: number;
// 수정
authorId: number;
지금은 개인 프로젝트라 크게 문제는 없지만, 추후 팀 프로젝트나 협업 과정에서는 이런 작은 오타도 타입 사용이나 API 연결 시 이슈로 이어질 수 있어서 수정해두면 좋을 것 같습니다 🙂
2. console.log, 주석 삭제
useGetInfiniteLpList.ts 파일에 getNextPageParam 안에 console.log랑
HomePage.tsx에 주석 처리된 코드들은 사용하지 않으면 지워주시는게 좋을 것 같아요 ~!
3. HomePage.tsx — 스켈레톤 count
// 현재
{isFetching && <LpCardSkeletonList count={20}/>}
// 수정 제안
{isFetching && <LpCardSkeletonList count={5}/>}
isFetching 상태일 때도 스켈레톤을 20개 고정으로 보여주고 있는데, 실제로 불러오는 limit이 5개이므로 스켈레톤 수를 limit과 맞춰주면 UX가 더 자연스러울 것 같습니다 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 주차 / 미션
📌 작업 내용
✨ 상세 작업 내용
✅ 체크리스트