5주차 미션 [워니]#8
Open
ywkim1m wants to merge 2 commits into
Open
Conversation
yangjiae12
reviewed
May 4, 2026
Member
yangjiae12
left a comment
yangjiae12
left a comment
There was a problem hiding this comment.
수고하셨습니다! 지난 4주차 미션 때 말씀 드린 것만 반영해주시면 좋겠습니다!
| @RestController | ||
| @RequiredArgsConstructor | ||
| @RequestMapping("/api") | ||
| public class MissionController { |
Member
There was a problem hiding this comment.
도메인별로 Base Path를 /api/도메인명으로 통일하면 더 직관적일 것 같습니다
Member
There was a problem hiding this comment.
현재 member 패키지와 mission 패키지에 MissionController가 분산되어 있는데, 이를 domain.mission 패키지의 컨트롤러 하나로 통합하면 좋을 것 같습니다
Member
There was a problem hiding this comment.
DTO 선언 방식의 통일성이 부족합니다! 통합 클래스를 활용하실 거라면 현재 작성된 DTO를 내부 클래스로 옮겨주시고, 아니라면 빈 클래스들을 정리해주세요~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 구현 결과
💬 기타 공유 사항