5주차 미션 [루가]#7
Open
ochyeon wants to merge 16 commits into
Open
Conversation
yangjiae12
approved these changes
May 4, 2026
Comment on lines
+7
to
+10
| @Getter | ||
| public static class RegionMissionReqDto { | ||
| private String region; | ||
| } |
Member
There was a problem hiding this comment.
static class 대신 record를 사용해봐도 좋을 것 같습니다! record를 사용하면 @Getter 없이도 접근자 메서드가 자동으로 생성되고, 필드가 불변으로 관리됩니다~
| @RequiredArgsConstructor | ||
| public class HomeController { | ||
|
|
||
| @GetMapping("/userInfo") |
Member
There was a problem hiding this comment.
일반적으로 엔드포인트는 카멜 케이스가 아닌 하이픈을 사용하는 것이 표준입니다!
Member
There was a problem hiding this comment.
또한 스웨거 명세도 추가해주시면 프론트 측에서 더 편하게 API를 활용할 수 있을 것 같아요~
Comment on lines
+7
to
+10
| @Getter | ||
| public static class MissionSuccessReqDto { | ||
| private Long missionId; | ||
| } |
Member
There was a problem hiding this comment.
Request Body 없이 missionId를 경로 변수로 받는 것이 더 자연스러울 것 같습니다!
Comment on lines
+7
to
+12
| @Getter | ||
| public static class CreateReviewReqDto { | ||
| private Long restaurantId; | ||
| private Float score; | ||
| private String body; | ||
| } |
Member
There was a problem hiding this comment.
이 부분도 restaurantId는 경로로 빼면 좋습니다
…(record 사용, 엔드포인트 수정 및 스웨거 명세 추가)
…Id를 경로 변수로 받도록 수정
…tId를 경로 변수로 받도록 수정
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 구현 결과
4주차 미션 수정 -> 이전 pr에 반영
home 도메인 추가 -> api 명세서 상 홈 화면을 다루는 api가 필요하기 때문에 추가함 (우선은 controller, dto만)
각 도메인 별 controller & dto 작성
[ TODO ] : restaurant 도메인을 따로 분리함에 따른 API 명세서 수정
[ TODO ] : 수정된 API 명세서를 바탕으로 restaurant 도메인 내 controller & dto 작성
[ TODO ] : 작성한 코드 바탕으로 API 명세서 수정 및 구체화
❓ 리뷰 요청
🤔 질문
💬 기타 공유 사항