5주차 미션 [카카]#6
Open
KateteDeveloper wants to merge 4 commits into
Open
Conversation
yangjiae12
reviewed
May 3, 2026
Member
yangjiae12
left a comment
yangjiae12
left a comment
There was a problem hiding this comment.
폴더 구조만 알맞게 수정해주시면 좋을 것 같습니다! 5주차 미션 내용이 Controller와 Dto 작성이기 때문에 저 둘에 집중해서 리뷰 작성했고, 비즈니스 로직 작성한 거에 대해서는 추후 미션에서 함께 리뷰 진행하겠습니다~ 수고하셨어요
KateteDeveloper
force-pushed
the
kaka/week5
branch
from
e2519dc to
16a278f
Compare
refactor: DTO 클래스를 record 타입으로 변환 및 Enum 상수 추가 - Home, Mission, Member, Review 도메인의 DTO 클래스(@Getter, @builder)를 Java record로 리팩토링 - DTO 내부 클래스의 불필요한 'Class' 접미사 제거 (예: MyDataReqClass -> MyDataReq) - Controller, Service, Converter 계층에 record 타입 변경 사항(생성자 및 접근자) 반영 - Gender, Term, SocialType Enum에 필요한 상수(MALE, FEMALE, REQUIRED, OPTIONAL 등) 추가 ```
```text
refactor: 리뷰 생성 API 수정 (marketId PathVariable 적용 및 ID 타입 Long 변경)
```
**Breakdown of the changes covered:**
* **Controller**: Updated the review creation endpoint to accept `marketId` as a `@PathVariable` (`/v1/create/{marketId}`).
* **DTO**: Removed `marketId` and `regionId` from `CreateReviewReq` since `marketId` is now handled via the URL path.
* **Entity**: Changed the data types of `marketId` and `regionId` in the `Review` entity from `Integer` to `Long`.
* **Service & Converter**: Updated methods to pass `marketId` from the controller down to the entity builder.
…based on your examples: ```text feat: update CreateReviewRes DTO and ReviewConverter, remove regionId from Review entity ``` **Here is a quick breakdown of the specific changes mapped in this commit:** * **`Review.java`**: Removed the `regionId` field and its corresponding column mapping. * **`ReviewResDTO.java`**: Populated the `CreateReviewRes` record with `reviewId`, `stars`, and `content` fields (previously an empty record). * **`ReviewConverter.java`**: Updated the `toCreateReview` method to properly map the `Review` entity data to the newly updated `CreateReviewRes` DTO instead of returning an empty object.
KateteDeveloper
commented
May 5, 2026
Collaborator
Author
KateteDeveloper
left a comment
KateteDeveloper
left a comment
There was a problem hiding this comment.
@yangjiae12 피드백 바탕으로 수정했습니다! 감사합니다:)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚩 관련 이슈
📌 구현 결과
총 6개의 API를 구현했습니다.
🏠 Home
GET /home/v1/missions- 해당 지역 미션 목록 조회GET /home/v1/mydata- 홈 마이데이터 조회🎯 Mission
GET /mission/v1/missions- 내 미션 목록 조회POST /mission/completed- 미션 완료 처리⭐ Review
POST /review/v1/review/create- 리뷰 작성👤 Member
POST /auth/v1/signup- 회원가입POST /auth/v1/users/me- 내 정보 조회참고 사항
Mission엔티티의status,member_id필드는 ERD상user_mission테이블 소속 → 추후 수정 예정Member의phoneNumberStatus필드 추가Genderenum 값 추후 채워야 함