7주차 미션 [루가]#16
Open
ochyeon wants to merge 41 commits into
Open
Conversation
…(record 사용, 엔드포인트 수정 및 스웨거 명세 추가)
…Id를 경로 변수로 받도록 수정
…tId를 경로 변수로 받도록 수정
This reverts commit 4945095.
yangjiae12
reviewed
May 18, 2026
Comment on lines
+69
to
+73
| case "stars" -> slice = reviewRepository.findByUserOrderByGrade( | ||
| user, | ||
| cursorGrade, | ||
| PageRequest.of(0, size) | ||
| ); |
Member
There was a problem hiding this comment.
별점 정렬에서는 같은 별점의 리뷰가 여러 개 있을 수 있어, grade만 cursor로 사용하면 데이터가 누락될 수 있습니다. grade + id를 함께 cursor로 사용하는 방식이 더 안정적일 것 같습니다.
|
|
||
| Slice<Review> slice; | ||
|
|
||
| switch (sort.toLowerCase()) { |
Member
There was a problem hiding this comment.
sort가 null이면 NPE가 발생할 수 있어, 기본값을 지정하거나 null 검증을 추가하면 좋을 것 같습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 구현 결과
[지난 미션 피드백 수정]
❓ 리뷰 요청
🤔 질문
💬 기타 공유 사항