6주차 미션 [루크]#11
Open
yujining3827 wants to merge 46 commits into
Open
Conversation
Collaborator
|
수고하셨습니다! |
Collaborator
|
일관성 있고 좋습니다~! 수고하셨습니다:) |
yangjiae12
reviewed
May 8, 2026
Comment on lines
+22
to
+28
| return MemberResDTO.MyPageDTO.builder() | ||
| .nickname(member.getName()) | ||
| .email(member.getEmail()) | ||
| .phoneNumber(member.getPhoneNumber()) | ||
| .phoneNumberStatus(member.getPhoneNumberStatus()) | ||
| .userPoint(member.getUserPoint()) | ||
| .build(); |
Member
There was a problem hiding this comment.
dto 변환 로직을 MemberConverter로 분리하여 서비스 레이어는 비즈니스 로직에만 집중할 수 있도록 개선하면 좋을 것 같습니다
| public MemberResDTO.MyPageDTO getMyPage(Long memberId) { | ||
|
|
||
| Member member = memberRepository.findById(memberId) | ||
| .orElseThrow(() -> new RuntimeException("멤버가 존재하지 않습니다.")); |
Member
There was a problem hiding this comment.
현재 getMissionList와 getHomeMissionList 내부에 데이터를 DTO로 변환하는 매핑 로직이 길게 포함되어 있습니다. 프로젝트의 일관성을 위해 매핑 책임은 MissionConverter로 위임하고, 서비스는 비즈니스 흐름을 제어하는 데 집중하면 가독성이 훨씬 좋아질 것 같습니다!
|
|
||
| Pageable pageable = PageRequest.of(page, size); | ||
|
|
||
| Page<Participate> participatePage = |
Member
There was a problem hiding this comment.
응답 DTO에서 전체 페이지 수가 아닌 hasNext 여부만 사용하고 있기 때문에 전체 카운트 쿼리가 나가는 Page 대신 다음 페이지 존재 여부만 확인하는 Slice를 활용하면 성능을 높일 수 있습니다~
Comment on lines
+9
to
+18
| @Getter | ||
| @Builder | ||
| @AllArgsConstructor | ||
| @NoArgsConstructor | ||
| public static class MissionListDTO { | ||
| public List<MissionDTO> content; | ||
| public Integer page; | ||
| public Integer size; | ||
| public Boolean hasNext; | ||
| } |
Member
There was a problem hiding this comment.
지금처럼 페이징이 필요할 때 도메인마다 MissionListDTO 등을 따로 만들면 중복 코드가 발생하기 때문에 공통 페이징 DTO를 정의하면 좋을 것 같습니다
|
|
||
| @Service | ||
| @RequiredArgsConstructor | ||
| @Transactional |
Member
There was a problem hiding this comment.
생성 로직에는 적절하지만, 나중에 추가될 조회 메서드들을 고려하여 클래스 전체에는 @transactional(readOnly = true)를 설정하고, 생성이 발생하는 메서드에만 @transactional을 개별 선언하는 방식이 성능 및 안정성 측면에서 권장됩니다.
Comment on lines
+30
to
+34
| Member member = memberRepository.findById(memberId) | ||
| .orElseThrow(() -> new RuntimeException("멤버가 존재하지 않습니다.")); | ||
|
|
||
| Market market = marketRepository.findById(marketId) | ||
| .orElseThrow(() -> new RuntimeException("가게가 존재하지 않습니다.")); |
Comment on lines
+36
to
+48
| Review review = Review.builder() | ||
| .member(member) | ||
| .market(market) | ||
| .stars(request.getStars()) | ||
| .content(request.getContent()) | ||
| .build(); | ||
|
|
||
| Review savedReview = reviewRepository.save(review); | ||
|
|
||
| return ReviewResDTO.CreateReviewDTO.builder() | ||
| .reviewId(savedReview.getId()) | ||
| .message("리뷰 작성 완료!") | ||
| .build(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚩 관련 이슈
📌 구현 결과
마이페이지 조회 API 구현
/members/home/my리뷰 작성 API 구현
/review/markets/{marketId}진행중 / 완료 미션 조회 API 구현
홈 화면 지역별 진행 중인 미션 조회 API 구현
❓ 리뷰 요청
🤔 질문
💬 기타 공유 사항