6주차 미션 [워니]#10
Open
ywkim1m wants to merge 10 commits into
Open
Conversation
Collaborator
|
수고하셨습니다! |
Collaborator
|
미션 수고하셨습니다!! |
yangjiae12
reviewed
May 9, 2026
Comment on lines
+26
to
+35
| return MyPageResponse.builder() | ||
| .memberId(member.getId()) | ||
| .nickname(member.getNickname()) | ||
| .email(member.getEmail()) | ||
| .phoneNumber(member.getPhoneNumber()) | ||
| .isPhoneVerified(member.getIsPhoneVerified()) | ||
| .point(member.getPoint()) | ||
| .reviewCount(reviewCount) | ||
| .build(); | ||
| } |
Member
There was a problem hiding this comment.
Service에서 엔티티를 dto로 직접 변환하고 있는데 이 로직은 Converter로 분리하면 좋을 것 같습니다
Member
There was a problem hiding this comment.
현재 MemberResDTO, MemberReqDTO라는 빈 클래스 파일을 만들어두고, 정작 실제 응답인 MyPageResponse는 별도 파일로 분리해서 사용하고 있습니다. 이렇게 되면 도메인이 커질수록 dto 패키지에 파일이 수십 개로 늘어나 관리 효율이 떨어집니다. 이 파일에 dto를 모아서 작성하면 좋을 거 같아요!
| return missions.map(MissionConverter::toResponse); | ||
| } | ||
|
|
||
| private final MissionRepository missionRepository; |
Member
There was a problem hiding this comment.
모든 private final 필드는 클래스 최상단에 선언해주세요!
| public Page<HomeMissionResponse> getHomeMissions(Long locationId, Pageable pageable) { | ||
|
|
||
| Page<Mission> missions = | ||
| missionRepository.findByLocation(locationId, pageable); |
Member
There was a problem hiding this comment.
현재 서비스에서는 페이징 처리를 해주고 계신데, 반환되는 dto에는 메타 데이터를 담을 곳이 없습니다! 모든 도메인에서 페이징 응답을 일관되게 처리할 수 잇도록 공통 페이징 응답 DTO를 만들어 관리하는 건 어떨까요?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 구현 결과
💬 기타 공유 사항
테스트 후 컨트롤러 수정하겠습니다...
지역별 미션-홈화면