8주차 미션 [빈]#35
Open
deli-minju wants to merge 4 commits into
Open
Conversation
yangjiae12
reviewed
May 24, 2026
Member
yangjiae12
left a comment
yangjiae12
left a comment
There was a problem hiding this comment.
회원가입에서 음식 카테고리 선택은 잘 반영되어 있는 것 같습니다! 다만 약관 동의에 대한 내용이 없는 것 같아 약관 동의 정보도 요청 DTO와 서비스 로직에 추가하면 좋을 것 같습니다
Comment on lines
+68
to
+75
| List<Long> distinctCategoryIds = request.preferCategoryIds().stream() | ||
| .distinct() | ||
| .toList(); | ||
|
|
||
| List<FoodCategory> categories = foodCategoryRepository.findAllById(distinctCategoryIds); | ||
| if (categories.size() != distinctCategoryIds.size()) { | ||
| throw new MemberException(MemberErrorCode.FOOD_CATEGORY_NOT_FOUND); | ||
| } |
Member
There was a problem hiding this comment.
요청한 카테고리 ID의 중복을 제거하고, 실제 조회된 개수와 비교해 존재 여부를 검증하는 흐름이 좋은 거 같습니다~
| @NotBlank @Size(max = 255) String address, | ||
| @NotBlank @Size(max = 20) String nickname, | ||
| @NotBlank @Email @Size(max = 100) String email, | ||
| @NotBlank @Size(min = 8, max = 30) String password, |
Member
There was a problem hiding this comment.
보안 요구사항에 따라 영문/숫자/특수문자 조합 등의 @pattern 검증을 추가해도 좋을 것 같습니다
yangjiae12
approved these changes
May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚩 관련 이슈
📌 구현 결과
❓ 리뷰 요청
🤔 질문
💬 기타 공유 사항