5주차 미션 [빈]#12
Open
deli-minju wants to merge 3 commits into
Open
Conversation
Collaborator
|
수고하셨습니다! |
yangjiae12
approved these changes
May 2, 2026
Comment on lines
+20
to
+23
| @PostMapping("/me") | ||
| public ResponseEntity<ApiResponse<MemberResDto.GetMyPageResponse>> getMyPage( | ||
| @Valid @RequestBody MemberReqDto.GetMyPageRequest request | ||
| ) { |
Member
There was a problem hiding this comment.
컨트롤러에 Swagger 명세를 추가해 주시면 좋을 것 같습니다!
Comment on lines
+12
to
+19
| public record Create( | ||
| @NotBlank @Size(max = 20) String name, | ||
| @NotNull Gender gender, | ||
| @NotNull LocalDate birthDate, | ||
| @NotBlank @Size(max = 255) String address, | ||
| @NotBlank @Size(max = 20) String nickname | ||
| ) { | ||
| } |
Member
There was a problem hiding this comment.
추가로 각 필드마다 @Schema(description = "...", example = "...")를 추가해서 설명과 예시값을 넣어주시면 좋을 것 같습니다. 특히 birthDate나 gender 같은 필드는 스웨거에 예시값이 있으면 데이터 형식을 파악하기 훨씬 수월할 것 같아요!
Comment on lines
+13
to
+14
| MEMBER_NOT_FOUND(HttpStatus.NOT_FOUND, "MEMBER404", "사용자를 찾을 수 없습니다."), | ||
| STORE_NOT_FOUND(HttpStatus.NOT_FOUND, "STORE404", "가게를 찾을 수 없습니다."); |
Member
There was a problem hiding this comment.
현재 ReviewErrorCode나 MissionErrorCode를 보면, 다른 도메인의 리소스인 MEMBER_NOT_FOUND나 STORE_NOT_FOUND가 중복으로 정의되어 있습니다. 에러 관리의 일관성을 위해 해당 리소스의 메인 도메인 Enum에서만 에러를 정의하고 이를 재사용하는 방식을 권장합니다!
yangjiae12
reviewed
May 2, 2026
| @Getter | ||
| @RequiredArgsConstructor | ||
| public enum MemberErrorCode implements BaseErrorCode { | ||
| MEMBER_NOT_FOUND(HttpStatus.NOT_FOUND, "MEMBER404", "사용자를 찾을 수 없습니다."); |
Member
There was a problem hiding this comment.
현재의 MEMBER404 방식은 동일한 HTTP 상태 코드를 가진 여러 에러를 표현하기에 한계가 있습니다! 이를 방지하기 위해 MEMBER404_1처럼 구체적인 인덱스를 부여하는 방식으로 수정하면 좋을 것 같아요.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚩 관련 이슈
📌 구현 결과
❓ 리뷰 요청
🤔 질문
💬 기타 공유 사항
POST /api/v1/users/me는 5주차 범위(Controller/DTO 중심)에 맞춰 더미 응답으로 구현했습니다.