Conversation
Collaborator
There was a problem hiding this comment.
PR에 빌드 결과물(build/ 폴더)이 포함되어 올라온 것 같아요!
자동 생성되는 Binding 클래스나 Hilt 파일들은 커밋에 포함되면 안 돼요 .......😵
.gitignore에 아래 내용이 있는지 확인해주세요!
/build
/app/build
그리고 이미 트래킹된 경우엔 아래 명령어로 제거해주세요!
git rm -r --cached app/build
git rm -r --cached build
Lemon0610
reviewed
May 20, 2026
| } | ||
|
|
||
| @Composable | ||
| private fun HomeScreen() { |
Collaborator
There was a problem hiding this comment.
스크린들 파일 각각 분리하는게 좋을 것 같아요!
mookeunji05
reviewed
May 20, 2026
| import android.view.LayoutInflater | ||
| import android.view.View | ||
| import android.view.ViewGroup | ||
| import androidx.recyclerview.widget.DiffUtil |
Collaborator
There was a problem hiding this comment.
리사이클러 대신 listadapter와 DiffUtil을 사용하여 데이터 변경 시 변경된 부분만 효율적으로 만든 점이 좋은것같아요
jeongkyueun
reviewed
May 20, 2026
| import androidx.fragment.app.Fragment | ||
| import com.example.nike.R | ||
|
|
||
| class ProductDetailActivity : Fragment() { |
Collaborator
There was a problem hiding this comment.
파일 이름은 Activity인데 코드 내용은 Fragment로 되어 있습니다. 네이밍과 실제 역할이 일치하도록 수정하는 게 좋을 거 같아요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 PR 제목
feat: 7주차 미션
🔗 관련 이슈
Closes #이슈번호
✨ 변경 사항
🔍 테스트
📸 스크린샷 (선택)
🚨 추가 이슈