Conversation
Lemon0610
reviewed
Apr 29, 2026
Comment on lines
+53
to
+62
| <Button | ||
| android:id="@+id/btnEditProfile" | ||
| android:layout_width="180dp" | ||
| android:layout_height="52dp" | ||
| android:layout_marginTop="26dp" | ||
| android:background="@drawable/profile_outline_button_bg" | ||
| android:backgroundTint="@android:color/transparent" | ||
| android:text="프로필 수정" | ||
| android:textColor="#111111" | ||
| android:textSize="14sp" /> |
jeongkyueun
approved these changes
Apr 29, 2026
Collaborator
jeongkyueun
left a comment
jeongkyueun
left a comment
There was a problem hiding this comment.
공통 인터셉터(AuthenticationInterceptor)를 통해 x-api-key를 자동화하신 부분 좋네요!
mookeunji05
reviewed
Apr 29, 2026
| android:id="@+id/menu_profile" | ||
| android:icon="@drawable/ic_user" | ||
| android:title="프로필" /> | ||
|
|
Collaborator
kimdoyeon1234
left a comment
kimdoyeon1234
left a comment
There was a problem hiding this comment.
수고하셨습니다! 이번 PR에서 구조적 완성도가 높았습니다!
다음에 개선하면 좋을 점
- API 키를 BuildConfig로 분리하고 로깅은 디버그 빌드에서만 켜주세요
- ProductGridAdapter와 HomeProductAdapter를 ListAdapter + DiffUtil로 개선하면 더 좋아요
- 더미 데이터 이미지를 상품별로 다르게 넣어주면 UI 확인이 편합니다 🙂
그리고 파일 이름 week5 같이 week로 통일해주세요! 제가 찾기 편하게 ㅎㅎ 수고하셨습니다
Comment on lines
+11
to
+15
| private const val API_KEY = "reqres_4b7b1e3a525043a4b967f4b1085f63ff" | ||
|
|
||
| private val loggingInterceptor = HttpLoggingInterceptor().apply { | ||
| level = HttpLoggingInterceptor.Level.BODY | ||
| } |
Collaborator
There was a problem hiding this comment.
API 키 하드코딩은 local.properties + BuildConfig로 분리해주세요! 로깅도 디버그 빌드에서만 켜도록 수정하면 좋아요
Comment on lines
+78
to
+92
| private fun Product.toUiModel(isLiked: Boolean): ProductUiModel { | ||
| return ProductUiModel( | ||
| id = id, | ||
| name = name, | ||
| description = description, | ||
| price = price, | ||
| imageResId = imageResId, | ||
| colorCount = colorCount, | ||
| isBestSeller = isBestSeller, | ||
| isLiked = isLiked, | ||
| category = category, | ||
| isNew = isNew | ||
| ) | ||
| } | ||
| } No newline at end of file |
Collaborator
There was a problem hiding this comment.
Product와 ProductUiModel이 필드가 거의 동일해요. 지금은 학습 단계라 괜찮지만, 실제 프로젝트에서는 서버에서 오는 데이터 모델과 UI 모델이 다를 때 분리하는 게 의미 있습니다! 지금처럼 로컬 더미 데이터만 쓴다면 굳이 두 개로 나누지 않아도 됩니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 PR 제목
feat: 5주차 미션_우가
feat: 마이페이지 API 연동
🔗 관련 이슈
Closes #이슈번호
✨ 변경 사항
🔍 테스트
📸 스크린샷 (선택)
🚨 추가 이슈