Skip to content

Commit f40c7ee

Browse files
style: clean up imports and comments in test files
- Revert unrelated import order and whitespace changes in integration __init__.py - Fix Db2 capitalization in test_dialect.py comment Signed-off-by: IBM Db2 Eco System <Hdm-dev-persona-db2-eco-system@ibm.com>
1 parent a190479 commit f40c7ee

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

‎tests/core/engine_adapter/integration/__init__.py‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,30 +3,30 @@
33
import os
44
import pathlib
55
import sys
6-
import time
76
import typing as t
7+
import time
88
from contextlib import contextmanager
9-
from dataclasses import dataclass
109

1110
import pandas as pd # noqa: TID253
1211
import pytest
13-
from _pytest.mark import MarkDecorator
14-
from _pytest.mark.structures import ParameterSet
1512
from sqlglot import exp, parse_one
1613
from sqlglot.optimizer.normalize_identifiers import normalize_identifiers
1714

18-
import sqlmesh.core.dialect as d
1915
from sqlmesh import Config, Context, EngineAdapter
2016
from sqlmesh.core.config import load_config_from_paths
2117
from sqlmesh.core.config.connection import AthenaConnectionConfig
2218
from sqlmesh.core.dialect import normalize_model_name
23-
from sqlmesh.core.engine_adapter import AthenaEngineAdapter, SparkEngineAdapter, TrinoEngineAdapter
19+
import sqlmesh.core.dialect as d
20+
from sqlmesh.core.engine_adapter import SparkEngineAdapter, TrinoEngineAdapter, AthenaEngineAdapter
2421
from sqlmesh.core.engine_adapter.shared import DataObject
2522
from sqlmesh.core.model.definition import SqlModel, load_sql_based_model
2623
from sqlmesh.utils import random_id
2724
from sqlmesh.utils.date import to_ds
2825
from sqlmesh.utils.pydantic import PydanticModel
2926
from tests.utils.pandas import compare_dataframes
27+
from dataclasses import dataclass
28+
from _pytest.mark import MarkDecorator
29+
from _pytest.mark.structures import ParameterSet
3030

3131
if t.TYPE_CHECKING:
3232
from sqlmesh.core._typing import TableName, SchemaName
@@ -658,7 +658,7 @@ def get_column_comments(
658658
query = f"""
659659
SELECT
660660
col.COLUMN_NAME column_name,
661-
CAST(ep.value AS NVARCHAR(MAX)) comment
661+
CAST(ep.value AS NVARCHAR(MAX)) comment
662662
FROM INFORMATION_SCHEMA.COLUMNS col
663663
CROSS APPLY fn_listextendedproperty('MS_Description', 'schema', col.TABLE_SCHEMA, '{kind}', col.TABLE_NAME, 'column', col.COLUMN_NAME) ep
664664
WHERE col.TABLE_SCHEMA = '{schema_name}' AND col.TABLE_NAME = '{table_name}'

‎tests/core/test_dialect.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1051,7 +1051,7 @@ def test_parse_snowflake_create_schema_ddl():
10511051

10521052
@pytest.mark.parametrize("dialect", sorted(set(DIALECT_TO_TYPE.values())))
10531053
def test_sqlglot_extended_correctly(dialect: str) -> None:
1054-
# Skip DB2 on Python 3.9 since db2-sqlglot-dialect requires Python 3.10+
1054+
# Skip Db2 on Python 3.9 since db2-sqlglot-dialect requires Python 3.10+
10551055
if dialect == "db2" and sys.version_info < (3, 10):
10561056
pytest.skip("DB2 dialect requires Python 3.10+ for db2-sqlglot-dialect")
10571057

0 commit comments

Comments
 (0)