fix(web): resolve model paths against their own project root (#6052)

Signed-off-by: Adegbite Ayoade <tripleaceme@gmail.com>
Co-authored-by: Cortland Goffena <30168413+cmgoffena13@users.noreply.github.com>

Author: tripleaceme

tests/web/test_models.py

@@ -0,0 +1,25 @@
+# SPDX-License-Identifier: Apache-2.0
+
+from __future__ import annotations
+
+import pytest
+
+from sqlmesh.core.context import Context
+from web.server.api.endpoints.models import get_models
+
+pytestmark = pytest.mark.web
+
+
+def test_get_models_multi_repo() -> None:
+    """Models of every project are serialized, not just those of the first one.
+
+    `context.path` is the first configured project, so it is not an ancestor of the models
+    defined in any of the others.
+    """
+    context = Context(paths=["examples/multi/repo_1", "examples/multi/repo_2"], gateway="memory")
+
+    paths_by_name = {model.name: model.path for model in get_models(context)}
+
+    # Each model is reported relative to the project that defines it.
+    assert paths_by_name["bronze.a"] == "models/a.sql"
+    assert paths_by_name["silver.c"] == "models/c.sql"

web/server/api/endpoints/models.py

@@ -1,6 +1,7 @@
 from __future__ import annotations
 
 import typing as t
+from pathlib import Path
 
 from fastapi import APIRouter, Depends, HTTPException
 from sqlglot import exp
@@ -12,6 +13,7 @@
 from sqlmesh.utils.date import now, to_datetime
 from web.server import models
 from web.server.settings import get_loaded_context
+from web.server.utils import is_relative_to
 
 router = APIRouter()
 
@@ -125,7 +127,7 @@ def serialize_model(context: Context, model: Model, render_query: bool = False)
     return models.Model(
         name=model.name,
         fqn=model.fqn,
-        path=str(path.absolute().relative_to(context.path).as_posix()) if path else None,
+        path=_path_relative_to_project(context, path) if path else None,
         full_path=str(path.absolute().as_posix()) if path else None,
         dialect=dialect,
         columns=columns,
@@ -138,6 +140,23 @@ def serialize_model(context: Context, model: Model, render_query: bool = False)
     )
 
 
+def _path_relative_to_project(context: Context, path: Path) -> str:
+    """Returns a model's path relative to the project root that defines it.
+
+    `context.path` is only the first of the configured projects, so it isn't necessarily an
+    ancestor of every model when the context is loaded with more than one of them.
+    """
+    absolute_path = path.absolute()
+    project_roots = [root for root in context.configs if is_relative_to(absolute_path, root)]
+    if not project_roots:
+        # The model lives outside of every configured project, so there is nothing to be
+        # relative to.
+        return absolute_path.as_posix()
+    # The deepest root wins so that nested projects report the closest one.
+    closest_root = max(project_roots, key=lambda root: len(root.parts))
+    return absolute_path.relative_to(closest_root).as_posix()
+
+
 def _get_model_type(model: Model) -> str:
     if model.is_sql:
         return models.ModelType.SQL