Goggle diving helmets should have same tooltips as Create ones

[VladisCrafter]

Realized this while reviewing #51. Diving helmets, both copper and netherite, aren't just "armor".
I propose merging the text from item.create.copper_diving_helmet.tooltip.summary/item.create.netherite_diving_helmet.tooltip.summary into respective goggle helmets, as well as implementing local alternatives of item.create.copper_diving_helmet.tooltip.condition1/item.create.netherite_diving_helmet.tooltip.condition1 (perhaps renaming the existing condition to .condition2) and item.create.copper_diving_helmet.tooltip.behaviour1/item.create.netherite_diving_helmet.tooltip.behaviour1, all to achieve consistency with Create mod.

[Robocraft999]

I agree with merging the summary, but do you really think I should change the order of the When looking at blocks to second just for the diving helmets? I would rather just append the When Worn as second part. Although I just noticed that the banktanks also prefer the when worn as first condition. Maybe it would also be a good idea to split out the When Worn and When looking at blocks on all helmets. When Worn on the other helmets could then just say something like "provides armor". What do you think?

[VladisCrafter]

I agree with merging the summary, but do you really think I should change the order of the When looking at blocks to second just for the diving helmets? I would rather just append the When Worn as second part.

As of writing that I was guided by the following philosophy: they are not goggles with helmet functionality but the other way around. That's why I think the helmet's condition & behaviour should have a priority in the description.
I think it is not just not worth bothering that diving helmets would have a different structure, not just some more info appended, I'd say it's even for good as they do in fact have to stand out.

---

Maybe it would also be a good idea to split out the When Worn and When looking at blocks on all helmets. When Worn on the other helmets could then just say something like "provides armor". What do you think?

I highly doubt that. Vanilla helmets don't have any tooltips at all, and providing a separate condition & behaviour for just "Provides armor." would be an obvious overkill. In my opinion, of course.