Add tests for StellarSubmissionService retry, idempotency, and secret handling

[thlpkee20-wq]

Description

StellarSubmissionService in src/services/stellarSubmissionService.ts reads STELLAR_SERVER_SECRET, builds a keypair, and submits with retry/backoff and failure classification, but existing tests should be extended to cover the retry-on-retryable-failure path, idempotent resubmission, and the assertion that the secret never appears in logs or errors. Strengthen the test suite.

Requirements and context

• Must be secure, tested, and documented
• Should be efficient and easy to review
• Relevant code: src/services/stellarSubmissionService.ts, src/services/stellarSubmissionService.test.ts, src/lib/stellarRpcFailure.ts
• Missing STELLAR_SERVER_SECRET must throw a structured internal error without leaking config

Suggested execution

• Fork the repo and create a branch
• git checkout -b test/stellar-submission-coverage
• Implement changes
  • Stub the RPC server to return retryable then success and assert one final submit
  • Assert non-retryable failures are not retried
  • Assert the server secret is never serialized into errors/logs
• Validate security and correctness assumptions

Test and commit

• Run tests
  • npm test
• Cover edge cases
  • BAD_SEQUENCE, INSUFFICIENT_FUNDS, timeout retry, duplicate submission dedupe
• Include test output and notes

Example commit message

test: cover Stellar submission retry and secret safety

Guidelines

• Minimum 95 percent test coverage
• Clear documentation
• Timeframe: 96 hours

[EmmyKay0026]

@EmmyKay0026 has applied to work on this issue as part of the Stellar Wave Program's 5th wave.

Hi, I'm Emmanuel, a full-stack developer and open-source contributor. I'm interested in working on this issue and would be happy to help implement a solution or improve the test coverage.

I believe resolving this will improve system reliability and security by ensuring retry behavior, idempotency, and secret handling are properly validated without exposing sensitive configuration details.

I’m ready to follow the project’s workflow and coding standards. Please let me know if I can proceed or if there are any pointers to get started. Thanks!

ℹ️ Repo Maintainers: To accept this application, review their application or assign @EmmyKay0026 to this issue.

[estyemma]

@estyemma has applied to work on this issue as part of the Stellar Wave Program's 5th wave.

I’d like to work on this. I specialize in full-stack development and secure smart contract architecture. Given the requirements here, I believe my experience with scalable backends and blockchain security would be a great fit.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @estyemma to this issue.

[nikkybel]

@nikkybel has applied to work on this issue as part of the Stellar Wave Program's 5th wave.

Can I be assigned this issue?

ℹ️ Repo Maintainers: To accept this application, review their application or assign @nikkybel to this issue.

[Paranoa-dev]

@Paranoa-dev has applied to work on this issue as part of the Stellar Wave Program's 5th wave.

Extend stellarSubmissionService.test.ts to cover retry behavior, idempotent submission handling, and secret-safety guarantees for StellarSubmissionService. The goal is to validate resilience and ensure sensitive configuration data can never leak through logs or thrown errors.

Add retry-path tests by mocking the RPC layer to fail with retryable errors (timeout, transient RPC failure) before succeeding. Assert retries occur correctly, backoff logic is respected, and only one final successful submission is committed.

Add non-retryable failure tests for:

• BAD_SEQUENCE
• INSUFFICIENT_FUNDS
• malformed transaction errors

These cases should fail immediately without retry attempts.

Add idempotency coverage by simulating duplicate/replayed submissions and verifying the service safely deduplicates or classifies the transaction instead of double-submitting.

Add security-focused assertions around STELLAR_SERVER_SECRET:

• Missing secret should throw a structured internal/config error.

• The secret must never appear in:

  • logs
  • serialized errors
  • retry metadata
  • stack traces
  • debug output

Use explicit negative-match assertions against a known mock secret value.

Relevant files:

• src/services/stellarSubmissionService.ts
• src/services/stellarSubmissionService.test.ts
• src/lib/stellarRpcFailure.ts

Testing notes:

• Mock all RPC/network interactions.
• Use fake timers for retry/backoff validation where applicable.
• Ensure env vars are isolated/reset between tests.
• Cover retry exhaustion and mixed retryable/non-retryable sequences.

Acceptance criteria:

• npm test passes
• stellarSubmissionService.ts coverage reaches ≥95%
• Retry classification behavior is fully validated
• No secret leakage occurs in any failure path or log output

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Paranoa-dev to this issue.