Expand stellarRpcFailure classification tests to cover Horizon tx/op result codes

[thlpkee20-wq]

Description

src/lib/stellarRpcFailure.ts maps errors into classes including TX_RESULT_CODE and OP_RESULT_CODE, but src/lib/stellarRpcFailure.test.ts should comprehensively cover Horizon result-code shapes such as tx_bad_seq, tx_insufficient_fee, op_no_destination, and op_underfunded, plus the shouldRetry flags for each. Expand coverage so every branch of the classifier is exercised.

Requirements and context

• Must be secure, tested, and documented
• Should be efficient and easy to review
• Relevant code: src/lib/stellarRpcFailure.ts, src/lib/stellarRpcFailure.test.ts
• Tests must assert raw upstream messages never leak into the classified output

Suggested execution

• Fork the repo and create a branch
• git checkout -b test/stellar-failure-result-codes
• Implement changes
  • Add fixtures for Horizon extras.result_codes payloads
  • Assert mapping to TX_RESULT_CODE/OP_RESULT_CODE and shouldRetry
  • Assert UNKNOWN fallback for unrecognized shapes
• Validate security and correctness assumptions

Test and commit

• Run tests
  • npm test
• Cover edge cases
  • Nested result codes, missing extras, non-Error objects, null/undefined input
• Include test output and notes

Example commit message

test: cover Horizon result-code classification

Guidelines

• Minimum 95 percent test coverage
• Clear documentation
• Timeframe: 96 hours

[samueloyibodevv]

@samueloyibodevv has applied to work on this issue as part of the Stellar Wave Program's 5th wave.

Hello, I’m interested in fixing this issue and can provide a well-structured solution along with a clean pull request.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @samueloyibodevv to this issue.

[drips-wave]

Congratulations, @samueloyibodevv! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on June 2, 2026.

🧑‍💻 @samueloyibodevv: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊