Commit e58e68d
authored
fix: make desktop release shell explicit
## Related Issue
No tracking issue — this is maintainer-side recovery for [Desktop
Release run
32870712954](https://github.com/PyModel/pythinker-code/actions/runs/32870712954).
## Problem
The desktop release workflow passed Bash-style `$DESKTOP_VERSION` and
`$DESKTOP_CHANNEL` variables to an implicit shell. macOS uses Bash by
default, but Windows uses PowerShell, which expanded both values to
empty strings. The Windows release stopped at package configuration and
left `v0.3.0` as an unpublished draft.
Actionlint did not catch the mismatch because the Windows step did not
declare Bash.
## What changed
- Declare `shell: bash` on both macOS and Windows desktop package
configuration steps.
- Add a release workflow regression test that requires both
declarations.
This keeps the change on the two affected steps. Signing, artifact
verification, and atomic publishing remain fail-closed and unchanged.
## Verification
- RED on `origin/main`: release workflow test failed with `0 !== 2`.
- `pnpm run test:release` — 20/20 passed.
- Actionlint 1.7.12 — passed.
- `pnpm run lint` — 0 errors.
- `pnpm run sherif` — passed.
- `pnpm run typecheck` — passed.
- `pnpm test` — 1,216 files and 20,343 tests passed.
- Security and internal-identifier review — no findings.
## Checklist
- [x] I have read the
[CONTRIBUTING](https://github.com/PyModel/pythinker-code/blob/main/CONTRIBUTING.md)
document.
- [ ] I have linked a related issue — none; this is maintainer-side
release infrastructure.
- [x] I have added tests that prove my feature works.
- [x] Ran `gen-changesets` — no changeset; this CI/test-only fix does
not change the shipped CLI.
- [x] Ran `gen-docs` — no user-facing documentation change.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Bug Fixes**
- Improved reliability of desktop releases on macOS and Windows by
ensuring release configuration steps run consistently with Bash.
- **Tests**
- Added coverage to verify Bash is configured correctly for both macOS
and Windows desktop release workflows.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->1 parent ff0582f commit e58e68d
2 files changed
Lines changed: 10 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
171 | 171 | | |
172 | 172 | | |
173 | 173 | | |
| 174 | + | |
174 | 175 | | |
175 | 176 | | |
176 | 177 | | |
| |||
355 | 356 | | |
356 | 357 | | |
357 | 358 | | |
| 359 | + | |
358 | 360 | | |
359 | 361 | | |
360 | 362 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
9 | 17 | | |
10 | 18 | | |
11 | 19 | | |
| |||
0 commit comments