fix(flags): report externallyControlled and overridden from the v1 resolver too

Author: elkaix

packages/agent-core/src/flags/resolver.ts

@@ -87,6 +87,8 @@ export class FlagResolver {
       enabled,
       source,
       configValue,
+      externallyControlled: source === 'env' || source === 'master-env',
+      overridden: configValue !== undefined && enabled !== configValue,
     };
   }
 }

packages/agent-core/src/flags/types.ts

@@ -38,6 +38,10 @@ export interface ExperimentalFeatureState {
   readonly enabled: boolean;
   readonly source: ExperimentalFlagSource;
   readonly configValue?: boolean;
+  /** True when an environment variable decides the flag (source `env` or `master-env`). */
+  readonly externallyControlled: boolean;
+  /** True when a saved config value exists and differs from the effective value. */
+  readonly overridden: boolean;
 }
 
 export interface ExperimentalFlagResolver {

packages/agent-core/test/flags/resolver.test.ts

@@ -106,6 +106,36 @@ describe('FlagResolver', () => {
     expect(resolver.enabled('b-off-default' as FlagId)).toBe(true);
   });
 
+  it('reports externallyControlled and overridden the same way the v2 engine does', () => {
+    const agreeing = new FlagResolver({ [DEFS[0].env]: '0' }, DEFS, { 'a-on-default': false } as never);
+    expect(agreeing.explain('a-on-default' as FlagId)).toMatchObject({
+      enabled: false,
+      source: 'env',
+      configValue: false,
+      externallyControlled: true,
+      overridden: false,
+    });
+    const overriding = new FlagResolver({ [DEFS[0].env]: '1' }, DEFS, { 'a-on-default': false } as never);
+    expect(overriding.explain('a-on-default' as FlagId)).toMatchObject({
+      enabled: true,
+      source: 'env',
+      externallyControlled: true,
+      overridden: true,
+    });
+    const saved = new FlagResolver({}, DEFS, { 'a-on-default': false } as never);
+    expect(saved.explain('a-on-default' as FlagId)).toMatchObject({
+      source: 'config',
+      externallyControlled: false,
+      overridden: false,
+    });
+    expect(new FlagResolver({}, DEFS).explain('a-on-default' as FlagId)).toMatchObject({
+      source: 'default',
+      configValue: undefined,
+      externallyControlled: false,
+      overridden: false,
+    });
+  });
+
   it('ignores obsolete config override ids outside the registry', () => {
     const resolver = new FlagResolver({}, DEFS, {
       'a-on-default': false,