Commit 5f51b83
authored
fix(web): align the MCP server form and the provider dialog corners (#122)
## What
Two UI alignment fixes reported from the running preview.
**MCP server form (Settings → Connectors).** The field grid used
`auto-fit` with a 180px minimum, so on a wide settings pane the five
fields packed four to a row, put short inputs next to taller textareas,
and left the final row with three empty columns. Name and Transport now
share the first row; Command, Arguments, Environment (and URL/Headers
for http/sse) each span both columns. The grid is capped at 640px so the
inputs stop stretching across the whole pane.
**Provider manager dialog.** The dialog rounded its border but never
clipped its children, so the header background, the footer, and the list
scrollbar all painted square corners over the rounding. The footer had
worked around this with its own `border-radius`; clipping at the dialog
fixes all three and the workaround is gone.
## Tests
- `connectors-page.test.ts` asserts exactly which fields are narrow and
which span the row.
- `provider-manager-chrome.test.ts` asserts the dialog clips and that
the footer no longer carries its own rounding (jsdom applies no scoped
SFC styles, so the rule is the contract).
Both were mutation-checked: reverting either fix fails its test.
## Verification
- `pnpm run typecheck` — exit 0
- `npx vitest run apps/pythinker-web` — 70 files / 448 tests pass
- `pnpm run lint` — exit 0, zero errors
- Checked in the browser against a fresh build on the local preview
server
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **UI Improvements**
* Improved MCP server form layout with clearer two-column alignment for
name and transport fields.
* Expanded longer fields across the available width.
* Added responsive behavior for smaller screens.
* Refined provider manager dialogs with consistent rounded corners and
cleaner content clipping.
* **Tests**
* Added coverage for connector form layout and provider manager dialog
styling.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->1 parent cb2ecdc commit 5f51b83
5 files changed
Lines changed: 82 additions & 7 deletions
File tree
- .changeset
- apps/pythinker-web
- src/components
- settings
- test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
353 | 353 | | |
354 | 354 | | |
355 | 355 | | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
356 | 359 | | |
357 | 360 | | |
358 | 361 | | |
| |||
578 | 581 | | |
579 | 582 | | |
580 | 583 | | |
581 | | - | |
582 | 584 | | |
583 | 585 | | |
584 | 586 | | |
| |||
Lines changed: 14 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
102 | | - | |
| 102 | + | |
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
106 | | - | |
| 106 | + | |
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
110 | | - | |
| 110 | + | |
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
114 | | - | |
| 114 | + | |
115 | 115 | | |
116 | 116 | | |
117 | 117 | | |
118 | | - | |
| 118 | + | |
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
| |||
139 | 139 | | |
140 | 140 | | |
141 | 141 | | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
142 | 145 | | |
143 | | - | |
| 146 | + | |
144 | 147 | | |
| 148 | + | |
145 | 149 | | |
146 | 150 | | |
| 151 | + | |
147 | 152 | | |
148 | 153 | | |
149 | 154 | | |
| |||
155 | 160 | | |
156 | 161 | | |
157 | 162 | | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
158 | 166 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
90 | 118 | | |
91 | 119 | | |
92 | 120 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
0 commit comments