fix: repair fallout from the legacy migration removal

Regenerate pnpm-lock.yaml so a frozen-lockfile install no longer fails on the
deleted @pymodel/migration-legacy dependency, drop both deleted packages from
the changeset ignore list and its documentation, correct the desktop guide
(arm64 DMG name, tray animation runs during Host startup, signing wording),
and restore the two non-migration assertions the cleanup removed: terminal
tracking disposal on startup failure and a loud invalid-config error.

Author: elkaix

.agents/skills/gen-changesets/SKILL.md

@@ -9,7 +9,7 @@ description: Use when generating changesets in the pythinker-code repository, in
 
 - `@pymodel/pythinker-code`: the CLI
 
-All other `@pymodel/*` packages are treated as internal packages, including `@pymodel/pythinker-code-sdk`, `agent-core`, `kosong`, `kaos`, `pythinker-code-oauth`, `pythinker-telemetry`, and `migration-legacy`.
+All other `@pymodel/*` packages are treated as internal packages, including `@pymodel/pythinker-code-sdk`, `agent-core`, `kosong`, `kaos`, `pythinker-code-oauth`, and `pythinker-telemetry`.
 
 ## Core Rules
 

.changeset/README.md

@@ -22,14 +22,12 @@ All other workspace packages are private internal packages, are not published to
 - `@pymodel/pythinker-telemetry`
 - `@pymodel/pythinker-web`
 - `@pymodel/kosong`
-- `@pymodel/migration-legacy`
 - `@pymodel/protocol`
 - `@pymodel/server`
 - `@pymodel/server-e2e`
 - `@pymodel/dashboard`
 - `@pymodel/dashboard-server`
 - `@pymodel/dashboard-web`
-- `pythinker-migration-legacy`
 
 Version impact from internal dependencies must be judged manually. The published artifacts for CLI and SDK bundle internal workspace packages into the artifact itself; runtime `dependencies` of published packages must not include any `@pymodel/*` internal workspace packages.
 

.changeset/config.json

@@ -14,14 +14,12 @@
     "@pymodel/pythinker-telemetry",
     "@pymodel/pythinker-web",
     "@pymodel/kosong",
-    "@pymodel/migration-legacy",
     "@pymodel/protocol",
     "@pymodel/server",
     "@pymodel/server-e2e",
     "@pymodel/dashboard",
     "@pymodel/dashboard-server",
-    "@pymodel/dashboard-web",
-    "pythinker-migration-legacy"
+    "@pymodel/dashboard-web"
   ],
   "snapshot": {
     "useCalculatedVersion": true,

apps/pythinker-code/test/cli/run-shell.test.ts

@@ -495,6 +495,34 @@ describe('runShell', () => {
     });
   });
 
+  it('surfaces an invalid target config as an error, not silently', async () => {
+    mocks.loadTuiConfig.mockResolvedValue(tuiConfig());
+    mocks.harnessGetConfig.mockRejectedValue(
+      new Error('Invalid configuration in ~/.pythinker-code/config.toml'),
+    );
+
+    // A broken config.toml must fail loudly before the TUI starts — otherwise the
+    // user never learns their config is broken.
+    await expect(
+      runShell(
+        {
+          session: undefined,
+          continue: false,
+          rewindFiles: undefined,
+          yolo: false,
+          auto: false,
+          plan: false,
+          model: undefined,
+          outputFormat: undefined,
+          prompt: undefined,
+          skillsDirs: [],
+        },
+        '1.2.3-test',
+      ),
+    ).rejects.toThrow('Invalid configuration');
+    expect(mocks.tuiStart).not.toHaveBeenCalled();
+  });
+
   it('closes the harness when TUI startup fails', async () => {
     mocks.loadTuiConfig.mockResolvedValue(tuiConfig());
     mocks.tuiStart.mockRejectedValue(new Error('boom'));

apps/pythinker-code/test/tui/pythinker-tui-startup.test.ts

@@ -90,6 +90,13 @@ interface InitMainTuiDriver extends StartupDriver {
   initMainTui(): Promise<boolean>;
 }
 
+interface StartFailureDriver extends StartupDriver {
+  start(): Promise<void>;
+  startEventLoop(): void;
+  initMainTui(): Promise<boolean>;
+  terminalFocusTrackingDispose?: () => void;
+}
+
 interface PresentationDriver extends StartupDriver {
   readonly presentation: TuiPresentation;
   startEventLoop(): void;
@@ -2031,4 +2038,36 @@ describe('footer update status poll', () => {
       rmSync(home, { recursive: true, force: true });
     }
   }, 30_000);
+
+  it('disposes terminal tracking when startup fails', async () => {
+    const harness = makeHarness();
+    const driver = makeDriver(harness, makeStartupInput()) as unknown as StartFailureDriver;
+    // pi-tui start/stop and focus tracking touch the real TTY — stub the I/O.
+    vi.spyOn(driver.state.ui, 'start').mockImplementation(() => {});
+    vi.spyOn(driver.state.ui, 'stop').mockImplementation(() => {});
+    vi.spyOn(driver.state.terminal, 'write').mockImplementation(() => {});
+    vi.spyOn(driver, 'initMainTui').mockRejectedValue(new Error('resume boom'));
+
+    // startEventLoop() only installs focus tracking once the terminal reports a
+    // width, so give it one — otherwise there is nothing to dispose and the
+    // assertion below would hold no matter what the teardown does.
+    const stdoutColumns = Object.getOwnPropertyDescriptor(process.stdout, 'columns');
+    Object.defineProperty(process.stdout, 'columns', { configurable: true, value: 80 });
+    try {
+      driver.startEventLoop();
+      expect(driver.terminalFocusTrackingDispose).toBeDefined();
+
+      await expect(driver.start()).rejects.toThrow('resume boom');
+
+      // The focus tracking installed by startEventLoop() must be torn down before
+      // the error propagates — not left active after the process exits.
+      expect(driver.terminalFocusTrackingDispose).toBeUndefined();
+    } finally {
+      if (stdoutColumns === undefined) {
+        Reflect.deleteProperty(process.stdout, 'columns');
+      } else {
+        Object.defineProperty(process.stdout, 'columns', stdoutColumns);
+      }
+    }
+  });
 });

docs/guides/desktop.md

@@ -14,7 +14,7 @@ Download the installer for your platform from the
 
 | Platform | File |
 | --- | --- |
-| macOS | `Pythinker-<version>.dmg` |
+| macOS | `Pythinker-<version>-arm64.dmg` |
 | Windows | `Pythinker-<version>-x64-Setup.exe` |
 
 - **macOS**: open the DMG and drag **Pythinker** into `Applications`.
@@ -26,7 +26,7 @@ There is no Linux desktop distribution at this time. On Linux, use the
 
 ::: tip Unsigned builds
 If a release is published without code-signing credentials, macOS Gatekeeper or Windows SmartScreen
-shows a warning at first launch. Signed builds do not show this warning.
+shows a warning at first launch. A signed build is much less likely to show one.
 :::
 
 ## First launch
@@ -45,7 +45,8 @@ For the directory layout, see [Data locations](../configuration/data-locations.m
 
 - Closing the window **hides** it. The Host continues to run and your session stays alive.
 - The tray icon menu has two items: **Open Pythinker** shows the window again, and **Quit** stops
-  the Host and closes the application. The tray icon animates while the agent works.
+  the Host and closes the application. The tray icon animates while the Host starts, and becomes
+  static when the Host is ready.
 - The window stays on the local Host origin. `http` and `https` links open in your system browser.
 
 ## Updates