Skip to content

Commit 4b8cab7

Browse files
committed
fix(vscode): give the seeded dev profile its own tree
Both launch profiles pointed at the same user-data, extensions, and home directories, so a seeded run left its real credentials behind for the isolated profile to inherit, which defeated the point of the isolated default.
1 parent 426048c commit 4b8cab7

3 files changed

Lines changed: 19 additions & 9 deletions

File tree

apps/vscode/.vscode/launch.json

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,10 @@
1818
"env": {
1919
"PYTHINKER_CODE_HOME": "${workspaceFolder}/../../.tmp/vscode-extension-dev/pythinker-home"
2020
},
21-
"outFiles": ["${workspaceFolder}/dist/**/*.js", "${workspaceFolder}/dist/**/*.mjs"],
21+
"outFiles": [
22+
"${workspaceFolder}/dist/**/*.js",
23+
"${workspaceFolder}/dist/**/*.mjs"
24+
],
2225
"sourceMaps": true,
2326
"resolveSourceMapLocations": [
2427
"${workspaceFolder}/**",
@@ -32,17 +35,20 @@
3235
"preLaunchTask": "vscode: dev (seeded)",
3336
"args": [
3437
"--extensionDevelopmentPath=${workspaceFolder}",
35-
"--user-data-dir=${workspaceFolder}/../../.tmp/vscode-extension-dev/user-data",
36-
"--extensions-dir=${workspaceFolder}/../../.tmp/vscode-extension-dev/extensions",
38+
"--user-data-dir=${workspaceFolder}/../../.tmp/seeded/vscode-extension-dev/user-data",
39+
"--extensions-dir=${workspaceFolder}/../../.tmp/seeded/vscode-extension-dev/extensions",
3740
"--disable-workspace-trust",
3841
"--skip-welcome",
3942
"--skip-release-notes",
40-
"${workspaceFolder}/../../.tmp/vscode-extension-dev/workspace"
43+
"${workspaceFolder}/../../.tmp/seeded/vscode-extension-dev/workspace"
4144
],
4245
"env": {
43-
"PYTHINKER_CODE_HOME": "${workspaceFolder}/../../.tmp/vscode-extension-dev/pythinker-home"
46+
"PYTHINKER_CODE_HOME": "${workspaceFolder}/../../.tmp/seeded/vscode-extension-dev/pythinker-home"
4447
},
45-
"outFiles": ["${workspaceFolder}/dist/**/*.js", "${workspaceFolder}/dist/**/*.mjs"],
48+
"outFiles": [
49+
"${workspaceFolder}/dist/**/*.js",
50+
"${workspaceFolder}/dist/**/*.mjs"
51+
],
4652
"sourceMaps": true,
4753
"resolveSourceMapLocations": [
4854
"${workspaceFolder}/**",

apps/vscode/README.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,14 @@ read your real `~/.pythinker-code/config.toml`.
3737

3838
To start the dev extension with your real providers and models, use the
3939
"(seeded config)" launch profile or `pnpm run dev:prepare:seeded`. It copies your
40-
real `config.toml` verbatim into the disposable dev home, which duplicates every
40+
real `config.toml` verbatim into a disposable dev home, which duplicates every
4141
secret it contains — API keys and any embedded provider auth metadata — into a
4242
file under `.tmp/` (mode `0600` where supported). Credential stores, session
43-
data, and `mcp.json` stay in the real home. The isolated default remains unchanged.
43+
data, and `mcp.json` stay in the real home.
44+
45+
The seeded profile lives in its own tree (`.tmp/seeded/vscode-extension-dev`)
46+
with its own user-data and extensions directories, so the isolated profile never
47+
inherits the seeded run's configuration or stored credentials.
4448

4549
Note: the engine watches `config.toml` and reloads itself on change, but the
4650
extension has no config-change subscription. The model picker and Models section

apps/vscode/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@
311311
"vscode:prepublish": "pnpm run build",
312312
"dev": "pnpm run dev:prepare && pnpm run \"/^dev:(extension|webview)$/\"",
313313
"dev:prepare": "node scripts/prepare-dev.mjs",
314-
"dev:prepare:seeded": "node scripts/prepare-dev.mjs --seed-config",
314+
"dev:prepare:seeded": "node scripts/prepare-dev.mjs --seed-config --base-dir ../../.tmp/seeded/vscode-extension-dev",
315315
"dev:extension": "node scripts/watch-extension.mjs",
316316
"dev:webview": "vite build --config webview-ui/vite.config.ts --watch --sourcemap",
317317
"typecheck": "tsc -p tsconfig.json --noEmit && tsc -p webview-ui/tsconfig.json --noEmit",

0 commit comments

Comments
 (0)