fix: print-mode telemetry, upgrade -y, telemetry dedup, staleGuard removal, goal budgets, media names (#307)

## Related Issue

No tracked issue — internal reconciliation pass. Stacked on #306; review
that one first.

## Problem

Six independent defects and small features, none of which were reachable
from the CLI or server as shipped:

- Print mode (`pythinker -p`) ignored `PYTHINKER_DISABLE_TELEMETRY` and
never attached a sink to the client the process-wide crash handlers
report through, so print-mode crashes went unreported.
- `pythinker upgrade` could only be answered interactively, so scripts
and non-interactive shells were shown the manual install command
instead.
- Every session open was counted twice in telemetry: the harness and the
engine each emitted `session_started`, and the provider/reload commands
mirrored the engine's `model_switch`.
- The `staleGuard` feature had no consumers but still owned a replayable
state key and two wire records.
- Goal time budgets were capped at 24 hours and kept accruing while the
session was closed, so a long goal could return already over budget
without doing any work.
- Image and video filenames were dropped: the gateway re-derived a name
from the mime type or the stored file.

## What changed

- **Print telemetry** — the config value routes through
`shouldEnableTelemetry` (which honours the env var), and the v1 pipeline
is initialized beside the v2 cloud appender so crash handlers have a
sink. The session id and resolved model are reconciled once known.
- **`upgrade -y/--yes`** — skips the confirmation and installs directly.
The existing native-install path keeps its own no-confirmation
behaviour.
- **Telemetry dedup** — harness-assembled clients drop the engine's
`session_started`; direct `SDKRpcClientV2` consumers keep it, since it
is their only producer. `activateModelAfterLogin` now reports whether
the engine already tracked the switch, so the command layer stays the
producer for exactly the paths it does not.
- **`staleGuard` removed** — replay still works for wires that carry the
retired records: the dispatcher skips them without a warning, and the
visualizer declares both record shapes locally.
- **Goal budgets** — no upper duration limit, time accrues only while
the agent is live, and an active goal pauses when its agent closes so
resume continues with the remainder.
- **Media names** — image and video parts carry an optional name through
the wire contract; an unsupported-format image keeps that name in the
notice and in the file written to the attachments directory.

Two things worth a reviewer's attention:

- `v1↔v2` goal parity now pins one deliberate difference. v2 reports
`Paused after agent closed`; v1 reports `Paused after agent resume`
because agent-core v1 has no agent close hook to attach the behaviour
to. Every other field still compares in full, and each engine's own
reason is asserted explicitly.
- The `dist-web` bundle is restaged in the media-names commit because
`packages/protocol` and `packages/transcript` are web build inputs. Only
`.web-bundle-manifest.json` changed.

## Checklist

- [x] I have read the
[CONTRIBUTING](https://github.com/PyModel/pythinker-code/blob/main/CONTRIBUTING.md)
document.
- [ ] I have linked a related issue (external PRs: the issue must have a
maintainer's `/approve`).
- [x] I have added tests that prove my feature works.
- [x] Ran `gen-changesets` skill, or this PR needs no changeset.
- [x] Ran `gen-docs` skill, or this PR needs no doc update.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
  * Added `-y, --yes` to install upgrades without confirmation.
* Preserved image and video filenames across prompts, sessions, and
history.

* **Bug Fixes**
* Goal timers now pause while sessions are closed and resume with
remaining time.
  * Removed the 24-hour limit on goal time budgets.
  * Print mode now respects telemetry disable settings.
* Improved session reload, model-switch tracking, telemetry, and
compatibility with older sessions.

* **Documentation**
  * Updated goal timing and upgrade command documentation.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Author: elkaix

.changeset/pause-goal-clock-on-close.md

@@ -0,0 +1,5 @@
+---
+"@pymodel/pythinker-code": patch
+---
+
+Exclude time spent with the session closed from goal time budgets.

.changeset/preserve-media-attachment-names.md

@@ -0,0 +1,5 @@
+---
+"@pymodel/pythinker-code": patch
+---
+
+Preserve image and video filenames in session history.

.changeset/print-mode-telemetry-disable-env.md

@@ -0,0 +1,5 @@
+---
+"@pymodel/pythinker-code": patch
+---
+
+Fix print mode (`pythinker -p`) ignoring the `PYTHINKER_DISABLE_TELEMETRY` environment variable.

.changeset/remove-goal-time-cap.md

@@ -0,0 +1,5 @@
+---
+"@pymodel/pythinker-code": patch
+---
+
+Remove the 24-hour limit on goal time budgets.

.changeset/update-yes-flag.md

@@ -0,0 +1,5 @@
+---
+"@pymodel/pythinker-code": patch
+---
+
+Add `-y, --yes` to `pythinker upgrade` (alias `pythinker update`) to skip the confirmation prompt and install the update directly.

apps/pythinker-code/dist-web/.web-bundle-manifest.json

@@ -1,4 +1,4 @@
 {
-  "sourceHash": "3856336183464397291f1fe4b79cf621f9251cfe1d579884874392027f2c376c",
+  "sourceHash": "0670132fd6ebf38fbe6620f3f406ab07bcd253ce8fe8c89e34558d03fd2a4d0f",
   "sourceFileCount": 493
 }

apps/pythinker-code/src/cli/commands.ts

@@ -13,7 +13,7 @@ import { registerWebCommand } from './sub/web';
 
 export type MainCommandHandler = (opts: CLIOptions) => void;
 export type PluginNodeRunnerHandler = (entry: string, args: readonly string[]) => void;
-export type UpgradeCommandHandler = () => void | Promise<void>;
+export type UpgradeCommandHandler = (yes: boolean) => void | Promise<void>;
 export type UpdateDownloadHandler = (version: string, manual: boolean) => void;
 
 export function createProgram(
@@ -27,6 +27,7 @@ export function createProgram(
     .description('The Starting Point for Next-Gen Agents')
     .version(version, '-V, --version')
     .allowUnknownOption(false)
+    .enablePositionalOptions()
     .configureHelp({ helpWidth: 100 })
     .helpOption('-h, --help', 'Show help.')
     .usage('[options] [command]')
@@ -125,8 +126,9 @@ export function createProgram(
     .command('upgrade')
     .alias('update')
     .description('Upgrade Pythinker Code to the latest version.')
-    .action(async () => {
-      await onUpgrade();
+    .option('-y, --yes', 'Skip the confirmation prompt and install the update directly.', false)
+    .action(async (options: { yes?: boolean }) => {
+      await onUpgrade(options.yes === true);
     });
 
   program

apps/pythinker-code/src/cli/sub/upgrade.ts

@@ -44,6 +44,7 @@ export interface UpgradeDeps {
   readonly stdout: WritableLike;
   readonly stderr: WritableLike;
   readonly isInteractive: boolean;
+  readonly yes: boolean;
   readonly track: UpgradeTrack;
   readonly logger: UpgradeLogger;
 }
@@ -87,7 +88,7 @@ export async function handleUpgrade(
   const source = await deps.detectInstallSource().catch(() => 'unsupported' as const);
   const installCommand = installCommandFor(source, target.version, deps.platform);
   const needsConfirmation = source !== 'native';
-  if (!canAutoInstall(source, deps.platform) || (!deps.isInteractive && needsConfirmation)) {
+  if (!canAutoInstall(source, deps.platform) || (!deps.yes && !deps.isInteractive && needsConfirmation)) {
     trackUpgradeEvent(deps.track, 'upgrade_command_manual_command', {
       current_version: currentVersion,
       target_version: target.version,
@@ -102,7 +103,7 @@ export async function handleUpgrade(
     return 0;
   }
 
-  if (deps.isInteractive) {
+  if (!deps.yes && deps.isInteractive) {
     trackUpgradeEvent(deps.track, 'upgrade_command_prompted', {
       current_version: currentVersion,
       target_version: target.version,
@@ -185,6 +186,7 @@ function createDefaultUpgradeDeps(overrides: Partial<UpgradeDeps>): UpgradeDeps
     stdout: overrides.stdout ?? process.stdout,
     stderr: overrides.stderr ?? process.stderr,
     isInteractive: overrides.isInteractive ?? (process.stdin.isTTY && process.stdout.isTTY),
+    yes: overrides.yes ?? false,
     track: overrides.track ?? trackTelemetry,
     logger: overrides.logger ?? log,
   };

apps/pythinker-code/src/cli/v2/run-v2-print.ts

@@ -64,6 +64,14 @@ import {
   resolveMcpJsonPaths,
 } from '@pymodel/agent-core-v2/app/mcpConfig/configLoader';
 import { createPythinkerDefaultHeaders, createPythinkerDeviceId } from '@pymodel/pythinker-code-oauth';
+import {
+  initializeTelemetry,
+  setCrashPhase,
+  setTelemetryContext,
+  setTelemetryModel,
+  shouldEnableTelemetry,
+  shutdownTelemetry,
+} from '@pymodel/pythinker-telemetry';
 import type { GoalUpdated } from '@pymodel/agent-core-v2/features/goal/goalOps';
 import type { TurnEnded } from '@pymodel/agent-core-v2/agent/loop/turnOps';
 import type {
@@ -85,6 +93,7 @@ import {
   CLI_USER_AGENT_PRODUCT,
   PROMPT_CLEANUP_TIMEOUT_MS,
 } from '#/constant/app';
+import { currentPythinkerProfile } from '#/utils/region';
 
 import {
   formatGoalSummaryText,
@@ -174,12 +183,13 @@ export async function runV2Print(
   // user left unset are filled, in the memory layer.
   await applyPrintModeConfigDefaults(configService);
   const defaultModel = configService.get<string>('defaultModel') ?? undefined;
-  let telemetryEnabled: boolean;
+  let configTelemetryEnabled: boolean;
   try {
-    telemetryEnabled = configService.get('telemetry') !== false;
+    configTelemetryEnabled = configService.get('telemetry') !== false;
   } catch {
-    telemetryEnabled = true;
+    configTelemetryEnabled = true;
   }
+  const telemetryEnabled = shouldEnableTelemetry({ enabled: configTelemetryEnabled });
   for (const diagnostic of configService.diagnostics()) {
     if (diagnostic.severity === 'warning') {
       stderr.write(`Warning: ${diagnostic.message}\n`);
@@ -193,13 +203,18 @@ export async function runV2Print(
   const cleanup = async (): Promise<void> => {
     const pending = (cleanupPromise ??= (async () => {
       removeTerminationCleanup?.();
+      setCrashPhase('shutdown');
       try {
         await restorePermission();
       } finally {
-        if (telemetryService !== undefined) {
-          await raceWithTimeout(telemetryService.shutdown(), CLI_SHUTDOWN_TIMEOUT_MS);
+        try {
+          if (telemetryService !== undefined) {
+            await raceWithTimeout(telemetryService.shutdown(), CLI_SHUTDOWN_TIMEOUT_MS);
+          }
+        } finally {
+          await shutdownTelemetry({ timeoutMs: CLI_SHUTDOWN_TIMEOUT_MS }).catch(() => {});
+          app.dispose();
         }
-        app.dispose();
       }
     })());
     await raceWithTimeout(pending, PROMPT_CLEANUP_TIMEOUT_MS);
@@ -211,7 +226,10 @@ export async function runV2Print(
     // `session_load_failed` fire inside create()/resume(), so an appender wired
     // up only after resolveNativeSession() would drop them to the null appender.
     // The model below is the best known up front; a resumed session's real
-    // model is reconciled via setContext once resolved.
+    // model is reconciled once resolved (v2 via setContext, v1 via
+    // setTelemetryModel). The v1 pipeline is initialized here too: the
+    // process-wide crash handlers installed in main() report through its
+    // default client, so its sink must be attached before the run can crash.
     telemetryService = app.accessor.get(ITelemetryService);
     if (telemetryEnabled) {
       telemetryService.setAppender(
@@ -222,6 +240,17 @@ export async function runV2Print(
           model: opts.model ?? defaultModel,
         }),
       );
+      // No `first_launch` on the v1 client: the v2 side already tracks it via
+      // `telemetryService.track2` below, so tracking here would double-send.
+      initializeTelemetry({
+        homeDir,
+        deviceId,
+        appName: CLI_USER_AGENT_PRODUCT,
+        version,
+        uiMode: PROMPT_UI_MODE,
+        model: opts.model ?? defaultModel,
+        endpoint: () => currentPythinkerProfile().telemetryEndpoint,
+      });
     }
 
     try {
@@ -235,6 +264,9 @@ export async function runV2Print(
     restorePermission = resolved.restorePermission;
 
     telemetryService.setContext({ sessionId: resolved.session.id, model: resolved.telemetryModel });
+    setTelemetryContext({ sessionId: resolved.session.id });
+    setTelemetryModel(resolved.telemetryModel);
+    setCrashPhase('runtime');
     if (firstLaunch) {
       telemetryService.track2('first_launch');
     }
@@ -318,7 +350,7 @@ export function formatTrustGatedMcpWarning(servers: readonly TrustGatedMcpServer
 }
 
 function escapeControlChars(value: string): string {
-  return value.replaceAll(/[\u0000-\u001f\u007f-\u009f]/g, (char) => {
+  return value.replaceAll(/[\u0000-\u001F\u007F-\u009F]/g, (char) => {
     const code = char.codePointAt(0) ?? 0;
     return `\\x${code.toString(16).padStart(2, '0')}`;
   });

apps/pythinker-code/src/main.ts

@@ -95,7 +95,7 @@ export async function handleMainCommand(
   return { headlessCompleted: false };
 }
 
-export async function handleUpgradeCommand(version: string): Promise<void> {
+export async function handleUpgradeCommand(version: string, yes: boolean): Promise<void> {
   const telemetryBootstrap = createCliTelemetryBootstrap();
   const telemetryClient: TelemetryClient = {
     track,
@@ -118,7 +118,7 @@ export async function handleUpgradeCommand(version: string): Promise<void> {
       version,
       uiMode: CLI_UI_MODE,
     });
-    exitCode = await handleUpgrade(version, { track, logger: log });
+    exitCode = await handleUpgrade(version, { track, logger: log, yes });
   } finally {
     await shutdownTelemetry({ timeoutMs: CLI_SHUTDOWN_TIMEOUT_MS }).catch(() => {});
     await harness.close().catch(() => {});
@@ -236,8 +236,8 @@ function bootstrap(): void {
         process.exit(1);
       });
     },
-    () => {
-      void handleUpgradeCommand(version).catch(async (error: unknown) => {
+    (yes) => {
+      void handleUpgradeCommand(version, yes).catch(async (error: unknown) => {
         await logStartupFailure('upgrade', error);
         process.stderr.write(formatStartupError(error, { operation: 'upgrade' }));
         process.stderr.write(`See log: ${resolveGlobalLogPath(resolvePythinkerHome())}\n`);