Merge PR #118: stop session snapshots timing out and recover when one fails

Author: elkaix

.changeset/desktop-window-chrome.md

@@ -0,0 +1,5 @@
+---
+'@pymodel/pythinker-code': patch
+---
+
+Repaint the desktop chrome. The sidebar footer now carries a pill button, so Settings and the way back out of it match New Session and stay visible. The transcript reserves room for the floating work chips instead of letting them sit on the last line. Windows gets round window controls on the trailing edge, in place of the native caption buttons that could not be styled.

.changeset/snapshot-stall.md

@@ -0,0 +1,5 @@
+---
+'@pymodel/pythinker-code': patch
+---
+
+Stop the session snapshot request from timing out on busy sessions. Each recorded event no longer pays a fresh file open and close, the watermark is read without waiting for pending writes, and the session list is scanned in parallel, so opening or refreshing a session stays fast even with a long history. This was most visible on Windows, where the per-event file cost is highest.

.changeset/web-codex-login.md

@@ -0,0 +1,5 @@
+---
+'@pymodel/pythinker-code': minor
+---
+
+Add OpenAI Codex sign-in to the web and desktop app. The provider dialog now offers "Sign in with ChatGPT" next to the API-key form: the server runs the OAuth exchange, writes the credentials, and reports only which model it selected. When port 1455 is taken, the dialog asks for the redirect URL instead.

.changeset/web-snapshot-recovery.md

@@ -0,0 +1,5 @@
+---
+'@pymodel/pythinker-code': patch
+---
+
+Recover the web and desktop app when a session snapshot request fails. It is now retried with a growing delay instead of leaving the todo list and the sub-agent list frozen until a reload, and a failed task refresh reports itself rather than failing in silence.

apps/desktop/src/main.ts

@@ -249,6 +249,24 @@ ipcMain.handle('pythinker:update:install', (event) => {
   assertTrustedSender(event)
   return quitAndInstallNow()
 })
+// Windows has no native caption buttons any more, so the renderer drives the
+// window. `close()` is used rather than `destroy()` so the tray lifecycle still
+// intercepts it and only hides the window.
+ipcMain.handle('pythinker:window:minimize', (event) => {
+  assertTrustedSender(event)
+  mainWindow?.minimize()
+})
+ipcMain.handle('pythinker:window:toggle-maximize', (event) => {
+  assertTrustedSender(event)
+  const window = mainWindow
+  if (window === undefined) return
+  if (window.isMaximized()) window.unmaximize()
+  else window.maximize()
+})
+ipcMain.handle('pythinker:window:close', (event) => {
+  assertTrustedSender(event)
+  mainWindow?.close()
+})
 ipcMain.handle('pythinker:theme:set-source', (event, source: unknown) => {
   assertTrustedSender(event)
   if (source === 'dark' || source === 'light' || source === 'system') {

apps/desktop/src/preload.ts

@@ -6,6 +6,9 @@ contextBridge.exposeInMainWorld('pythinkerDesktop', {
   setAutoUpdate: (enabled: boolean) => ipcRenderer.invoke('pythinker:update:set-auto', enabled),
   checkForUpdates: () => ipcRenderer.invoke('pythinker:update:check'),
   quitAndInstall: () => ipcRenderer.invoke('pythinker:update:install'),
+  minimizeWindow: () => ipcRenderer.invoke('pythinker:window:minimize'),
+  toggleMaximizeWindow: () => ipcRenderer.invoke('pythinker:window:toggle-maximize'),
+  closeWindow: () => ipcRenderer.invoke('pythinker:window:close'),
   setThemeSource: (source: 'dark' | 'light' | 'system') =>
     ipcRenderer.invoke('pythinker:theme:set-source', source),
   onUpdateState: (cb: (state: unknown) => void) => {

apps/desktop/src/window-options.ts

@@ -14,9 +14,11 @@ export function windowAppearanceOptions(platform: NodeJS.Platform): BrowserWindo
   }
   if (platform === 'win32') {
     return {
+      // No `titleBarOverlay`: the renderer draws macOS-style round controls in
+      // the top-right instead. `thickFrame` keeps the native resize border,
+      // shadow and drag-to-snap that `frame: false` would remove.
       autoHideMenuBar: true,
       titleBarStyle: 'hidden',
-      titleBarOverlay: { color: '#00000000', symbolColor: '#7f858f', height: 44 },
       backgroundColor: '#161616',
       hasShadow: true,
       roundedCorners: true,

apps/desktop/tests/window-appearance.spec.ts

@@ -16,18 +16,22 @@ describe('desktop window appearance configuration', () => {
     expect(opts['vibrancy']).toBe('sidebar')
   })
 
-  it('keeps the Windows window configuration unchanged', () => {
+  it('leaves the Windows caption buttons to the renderer', () => {
     const opts = windowAppearanceOptions('win32')
 
     expect(opts).toMatchObject({
       autoHideMenuBar: true,
       titleBarStyle: 'hidden',
-      titleBarOverlay: { color: '#00000000', symbolColor: '#7f858f', height: 44 },
       backgroundColor: '#161616',
       hasShadow: true,
       roundedCorners: true,
       thickFrame: true,
     })
+    // The overlay would draw native caption buttons on top of the round ones
+    // the renderer paints, so it has to stay off.
+    expect('titleBarOverlay' in opts).toBe(false)
+    // `thickFrame` without `frame: false` keeps the native resize border.
+    expect('frame' in opts).toBe(false)
   })
 
   it('keeps the Linux window configuration unchanged', () => {

apps/pythinker-code/src/generated/dashboard-web-asset.ts

@@ -2,27 +2,28 @@ import { describe, expect, it } from 'vitest';
 
 import { openUrlCommandFor } from '#/utils/open-url';
 
-const AUTHORIZE_URL =
-  'https://auth.openai.com/oauth/authorize?client_id=app_test&response_type=code&state=abc';
+const oauthUrl =
+  'https://auth.openai.com/oauth/authorize?client_id=app_test&redirect_uri=http%3A%2F%2Flocalhost%3A1455%2Fauth%2Fcallback&state=state';
 
 describe('openUrlCommandFor', () => {
-  it('keeps every query parameter on Windows', () => {
-    const { command, args } = openUrlCommandFor(AUTHORIZE_URL, 'win32');
-    expect(command).toBe('rundll32');
-    // `cmd /c start` cuts the URL at the first `&`, so the launcher must not
-    // hand the URL to a command interpreter.
-    expect(command).not.toBe('cmd');
-    expect(args.at(-1)).toBe(AUTHORIZE_URL);
+  it('passes the complete OAuth URL to the Windows URL handler', () => {
+    expect(openUrlCommandFor(oauthUrl, 'win32')).toEqual({
+      command: 'rundll32',
+      args: ['url.dll,FileProtocolHandler', oauthUrl],
+    });
   });
 
-  it('uses the platform launcher elsewhere', () => {
-    expect(openUrlCommandFor(AUTHORIZE_URL, 'darwin')).toEqual({
+  it('uses the native opener on macOS', () => {
+    expect(openUrlCommandFor(oauthUrl, 'darwin')).toEqual({
       command: 'open',
-      args: [AUTHORIZE_URL],
+      args: [oauthUrl],
     });
-    expect(openUrlCommandFor(AUTHORIZE_URL, 'linux')).toEqual({
+  });
+
+  it('uses xdg-open on Linux', () => {
+    expect(openUrlCommandFor(oauthUrl, 'linux')).toEqual({
       command: 'xdg-open',
-      args: [AUTHORIZE_URL],
+      args: [oauthUrl],
     });
   });
 });