fix(vscode): address review findings on the design overhaul

Guard approval and question dialogs against duplicate in-flight
responses, use a clipboard sentinel to detect an empty terminal
selection, promote token counts that round to one million into the m
unit, stop claiming the config file is missing after a load error,
group sessions by calendar-day boundaries so DST does not shift them,
and drop a stray console statement.

Author: elkaix

apps/vscode/src/integrations/chat-context.ts

@@ -91,20 +91,22 @@ export function registerChatContext(deps: ChatContextDeps): vscode.Disposable[]
     vscode.commands.registerCommand("pythinker.addTerminalSelection", async () => {
       // Clipboard round-trip: workbench.action.terminal.copySelection is the
       // only way to read the terminal selection, so save and restore the
-      // user's clipboard around it.
+      // user's clipboard around it. A sentinel distinguishes "no selection"
+      // (copySelection is a no-op) from a selection that happens to equal the
+      // old clipboard content.
       const previousClipboard = await vscode.env.clipboard.readText();
+      const sentinel = `__pythinker_no_selection_${Date.now()}__`;
       let selection = "";
       try {
+        await vscode.env.clipboard.writeText(sentinel);
         await vscode.commands.executeCommand("workbench.action.terminal.copySelection");
         selection = (await vscode.env.clipboard.readText()).trim();
       } catch (error) {
         deps.logError("Unable to read the terminal selection", error);
       } finally {
         await vscode.env.clipboard.writeText(previousClipboard);
       }
-      // copySelection is a no-op without a selection, which leaves the old
-      // clipboard content in place — do not insert that.
-      if (!selection || selection === previousClipboard.trim()) return;
+      if (!selection || selection === sentinel) return;
       await vscode.commands.executeCommand("pythinker.webview.focus");
       deps.insertText(`Terminal output:\n\`\`\`\n${selection}\n\`\`\``);
     }),

apps/vscode/webview-ui/src/components/ApprovalDialog.tsx

@@ -12,6 +12,9 @@ export function ApprovalDialog() {
   const [selectedIndex, setSelectedIndex] = useState(1);
   const [expanded, setExpanded] = useState(false);
   const cardRef = useRef<HTMLDivElement>(null);
+  // The request stays in the store until the RPC settles, so repeated key
+  // presses would send duplicate responses without this guard.
+  const inFlightRef = useRef(false);
 
   const req = pending[0];
 
@@ -28,10 +31,16 @@ export function ApprovalDialog() {
   const hasDisplay = req.display && req.display.length > 0;
 
   const handleResponse = async (response: ApprovalResponse) => {
-    await respondToRequest(req.id, response);
-    setSelectedIndex(1);
-    setExpanded(false);
-    focusComposer();
+    if (inFlightRef.current) return;
+    inFlightRef.current = true;
+    try {
+      await respondToRequest(req.id, response);
+      setSelectedIndex(1);
+      setExpanded(false);
+      focusComposer();
+    } finally {
+      inFlightRef.current = false;
+    }
   };
 
   const options = [

apps/vscode/webview-ui/src/components/ChatStatus.tsx

@@ -60,7 +60,8 @@ function subscribeToSpeed(listener: () => void): () => void {
 
 /** Compact token count in Cline's style: 999, 12.3k, 1.2m. */
 function formatTokens(count: number): string {
-  if (count >= 1e6) return `${(count / 1e6).toFixed(1)}m`;
+  // 999_950+ rounds to 1.0m; without this the k branch prints "1000.0k".
+  if (count >= 999_950) return `${(count / 1e6).toFixed(1)}m`;
   if (count >= 1e3) return `${(count / 1e3).toFixed(1)}k`;
   return String(count);
 }

apps/vscode/webview-ui/src/components/QuestionDialog.tsx

@@ -12,6 +12,9 @@ export function QuestionDialog() {
   const [questionIndex, setQuestionIndex] = useState(0);
   const [answers, setAnswers] = useState<Record<string, string>>({});
   const cardRef = useRef<HTMLDivElement>(null);
+  // The question stays pending until the RPC settles, so repeated key presses
+  // would submit duplicate answers without this guard.
+  const inFlightRef = useRef(false);
 
   const questions = pendingQuestion?.questions ?? [];
   const question = questions[questionIndex];
@@ -39,8 +42,14 @@ export function QuestionDialog() {
       setCustomInput("");
       setSelectedIndex(1);
     } else {
-      await respondQuestion(nextAnswers);
-      focusComposer();
+      if (inFlightRef.current) return;
+      inFlightRef.current = true;
+      try {
+        await respondQuestion(nextAnswers);
+        focusComposer();
+      } finally {
+        inFlightRef.current = false;
+      }
     }
   };
 

apps/vscode/webview-ui/src/components/SessionList.tsx

@@ -17,12 +17,16 @@ interface SessionListProps {
   onClose: () => void;
 }
 
-const DAY_MS = 86400000;
+interface GroupBoundaries {
+  startOfToday: number;
+  startOfYesterday: number;
+  startOfWeekWindow: number;
+}
 
-function getGroupLabel(timestamp: number, startOfToday: number): string {
-  if (timestamp >= startOfToday) return "Today";
-  if (timestamp >= startOfToday - DAY_MS) return "Yesterday";
-  if (timestamp >= startOfToday - 6 * DAY_MS) return "This week";
+function getGroupLabel(timestamp: number, boundaries: GroupBoundaries): string {
+  if (timestamp >= boundaries.startOfToday) return "Today";
+  if (timestamp >= boundaries.startOfYesterday) return "Yesterday";
+  if (timestamp >= boundaries.startOfWeekWindow) return "This week";
   return "Older";
 }
 
@@ -131,11 +135,17 @@ export function SessionList({ onClose }: SessionListProps) {
     const sorted = [...filtered].sort((a, b) => (sortOrder === "recent" ? b.updatedAt - a.updatedAt : a.updatedAt - b.updatedAt));
 
     const now = new Date();
-    const startOfToday = new Date(now.getFullYear(), now.getMonth(), now.getDate()).getTime();
+    // Calendar-day arithmetic, not fixed 24h offsets — a DST change makes a
+    // local day 23 or 25 hours, which would shift sessions between groups.
+    const boundaries = {
+      startOfToday: new Date(now.getFullYear(), now.getMonth(), now.getDate()).getTime(),
+      startOfYesterday: new Date(now.getFullYear(), now.getMonth(), now.getDate() - 1).getTime(),
+      startOfWeekWindow: new Date(now.getFullYear(), now.getMonth(), now.getDate() - 6).getTime(),
+    };
     // Map preserves insertion order, so group order follows the sort direction
     const groups = new Map<string, SessionInfo[]>();
     for (const session of sorted) {
-      const label = getGroupLabel(session.updatedAt, startOfToday);
+      const label = getGroupLabel(session.updatedAt, boundaries);
       const bucket = groups.get(label);
       if (bucket) {
         bucket.push(session);

apps/vscode/webview-ui/src/components/WelcomeScreen.tsx

@@ -18,7 +18,6 @@ export function WelcomeScreen() {
       const events = await bridge.loadSessionHistory(session.id);
       await loadSession(session.id, events);
     } catch (error) {
-      console.error("[WelcomeScreen] Failed to load session:", error);
       toast.error(`Unable to open the conversation: ${error instanceof Error ? error.message : String(error)}`);
     }
   };

apps/vscode/webview-ui/src/components/confighub/ConfigFileSection.tsx

@@ -48,7 +48,11 @@ export function ConfigFileSection() {
         </div>
       )}
 
-      {info === null || info.path === null || !info.exists ? (
+      {info === null ? (
+        // A load error with no result means the state is unknown — the error
+        // banner above is the whole story, so do not claim the file is missing.
+        error === undefined && <p className="text-xs text-muted-foreground text-center py-10">No config file was found.</p>
+      ) : info.path === null || !info.exists ? (
         <p className="text-xs text-muted-foreground text-center py-10">No config file was found.</p>
       ) : (
         <>