Commit 0387965
authored
ci(desktop): finalize the DMG with the tested release script (#196)
## Problem
`desktop-v0.3.2` failed at **Verify macOS update artifacts**:
`Pythinker-0.3.2-arm64.dmg size does not match latest-mac.yml`. The
notarize step from #194 stapled the DMG after electron-builder had
written the manifest, so size/sha512 (and the `.dmg.blockmap`) went
stale. Notarization itself succeeded.
## What changed
- The workflow now runs `apps/desktop/scripts/finalize-mac-artifacts.ts`
(already used by `dist:mac`, covered by
`tests/finalize-mac-artifacts.spec.ts`): notarytool submit → staple →
rewrite the DMG entry in `latest-mac.yml` → drop the stale blockmap
(full download instead of differential; the zip still has its blockmap).
- Added a CLI entry to that script (`finalize-mac-artifacts.ts
<dist-dir>`), same pattern as the other release scripts.
- Removed the hand-written shell step it replaces. The DMG-level
`stapler validate` + `spctl --type open` gate stays.
After merge, `desktop-v0.3.2` will be re-tagged on the merge commit
(0.3.2 was never published).
[skip changeset] — CI-only.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Bug Fixes**
- Improved macOS release artifact finalization, including notarization
and stapling.
- Updated release manifests automatically and removed stale blockmap
files.
- Improved error handling so release failures are reported clearly and
return a failure status.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->1 parent 8b6cc70 commit 0387965
2 files changed
Lines changed: 20 additions & 23 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
237 | 237 | | |
238 | 238 | | |
239 | 239 | | |
240 | | - | |
241 | | - | |
242 | | - | |
243 | | - | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
244 | 244 | | |
245 | | - | |
246 | | - | |
247 | | - | |
248 | | - | |
249 | | - | |
250 | | - | |
251 | | - | |
252 | | - | |
253 | | - | |
254 | | - | |
255 | | - | |
256 | | - | |
257 | | - | |
258 | | - | |
259 | | - | |
260 | | - | |
261 | | - | |
262 | | - | |
| 245 | + | |
| 246 | + | |
263 | 247 | | |
264 | 248 | | |
265 | 249 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| |||
191 | 192 | | |
192 | 193 | | |
193 | 194 | | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
0 commit comments