Commit d1f1e57
committed
fix(core): keep encrypted reasoning on summary-less responses
Address CodeRabbit review findings on the branch:
- core: a non-streaming OpenAI Responses reasoning item can return
encrypted_content with an empty summary; the conversion loop dropped it
entirely, diverging from the streaming output_item.done path and making
the reasoning boundary non-replayable. Emit an encrypted ThinkPart in
that case, mirroring the streaming behavior, with focused coverage.
- tui: render "1 agent" (singular) instead of "1 agents" in the grouped
agents summary, and make the uniform-status check explicitly boolean.
The two other flagged reasoning findings (summary-index preservation and
cross-output merge collisions) were verified against the code and tests
and are non-issues: real deltas always carry valid indices, and encrypted
boundaries already block adjacent cross-output merges.1 parent 70afc6a commit d1f1e57
4 files changed
Lines changed: 38 additions & 2 deletions
File tree
- packages/pythinker-core
- src/pythinker_core/contrib/chat_provider
- tests
- src/pythinker_code/ui/shell/tool_renderers
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
| |||
Lines changed: 11 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
548 | 548 | | |
549 | 549 | | |
550 | 550 | | |
| 551 | + | |
551 | 552 | | |
| 553 | + | |
552 | 554 | | |
553 | 555 | | |
554 | 556 | | |
555 | 557 | | |
556 | 558 | | |
| 559 | + | |
| 560 | + | |
| 561 | + | |
| 562 | + | |
| 563 | + | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
| 567 | + | |
557 | 568 | | |
558 | 569 | | |
559 | 570 | | |
| |||
Lines changed: 23 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
658 | 658 | | |
659 | 659 | | |
660 | 660 | | |
| 661 | + | |
| 662 | + | |
| 663 | + | |
| 664 | + | |
| 665 | + | |
| 666 | + | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
661 | 684 | | |
662 | 685 | | |
663 | 686 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
449 | 449 | | |
450 | 450 | | |
451 | 451 | | |
452 | | - | |
| 452 | + | |
453 | 453 | | |
454 | 454 | | |
455 | 455 | | |
456 | | - | |
| 456 | + | |
| 457 | + | |
457 | 458 | | |
458 | 459 | | |
459 | 460 | | |
| |||
0 commit comments