fix(homebrew): show logo in brew install, guard empty tap token (#22)

* fix(homebrew): show logo in brew install, guard empty tap token

Two Homebrew install problems, both rooted in the tap pipeline:

1. `brew install` showed no logo. The Tetris/robot-head banner lived only
   in the curl (install.sh) and PowerShell (install.ps1) installers, which
   Homebrew never runs. Add a `caveats` block to the formula template so
   `brew install` prints the static settled frame of that same logo (brew
   caveats are plain text, so this is the uncoloured robot head).

2. The tap auto-update workflow has failed on every release since the org
   migration: the `HOMEBREW_TAP_TOKEN` secret did not carry over, so
   `git push` to the tap repo fails with a cryptic exit-128 auth error and
   the tap stays frozen at the last good push (0.23.0). Add a fail-fast
   guard that detects an empty TAP_TOKEN and prints an actionable error
   instead of the opaque git failure.

Also add a test asserting the rendered formula carries the logo caveats.

The token secret itself must be re-added out-of-band (a fine-grained PAT
with Contents: Read and write on the tap repo); this change only makes the
failure obvious and ships the logo.

* test(homebrew): extract _fake_assets helper to dedupe asset setup

Author: elkaix

.github/workflows/homebrew-tap.yml

@@ -76,6 +76,10 @@ jobs:
           TAP_TOKEN: ${{ secrets.HOMEBREW_TAP_TOKEN }}
         run: |
           set -euxo pipefail
+          if [ -z "${TAP_TOKEN:-}" ]; then
+            echo "::error::HOMEBREW_TAP_TOKEN secret is empty or unset — cannot push to ${TAP_OWNER}/${TAP_REPO}. Add a fine-grained PAT (Contents: Read and write on the tap repo) as the HOMEBREW_TAP_TOKEN secret, then re-run this workflow." >&2
+            exit 1
+          fi
           # We do NOT use actions/checkout for the tap repo because on the
           # very first run the tap is empty and has no refs/heads/main yet.
           # `git init` + `git fetch || true` + `git push -u origin main`

packages/homebrew-tap/pythinker-code.rb.tmpl

@@ -41,6 +41,23 @@ class PythinkerCode < Formula
     bin.write_exec_script libexec/"pythinker"
   end
 
+  def caveats
+    # Static settled frame of the curl/PowerShell installers' "Tetris" logo
+    # (install.sh / install.ps1). Homebrew renders caveats as plain text, so
+    # this is the uncoloured robot-head. The squiggly heredoc strips the common
+    # leading indent, so the art sits one column left of the curl banner.
+    <<~EOS
+
+            ●
+            │
+        ▛▀▀▀▀▀▀▀▜
+       ◖█ ◉   ◉ █◗
+        ▙▄▄▄≡▄▄▄▟
+
+        pythinker code · your next CLI agent
+    EOS
+  end
+
   test do
     assert_path_exists libexec/".pythinker-native"
     assert_match version.to_s, shell_output("#{bin}/pythinker --version")

tests/test_homebrew_formula.py

@@ -20,16 +20,22 @@ def load_generator() -> ModuleType:
     return module
 
 
-def test_native_homebrew_formula_renders_release_tarballs() -> None:
-    generator = load_generator()
-    version = "1.2.3"
-    assets = {}
+def _fake_assets(generator: ModuleType, version: str) -> dict[str, dict[str, str]]:
+    """Build a fake GitHub release-asset map covering every native target."""
+    assets: dict[str, dict[str, str]] = {}
     for target in generator.NATIVE_TARGETS:
         name = target.asset_name(version)
         assets[name] = {
             "browser_download_url": f"https://example.invalid/{name}",
             "digest": "sha256:" + ("a" * 64),
         }
+    return assets
+
+
+def test_native_homebrew_formula_renders_release_tarballs() -> None:
+    generator = load_generator()
+    version = "1.2.3"
+    assets = _fake_assets(generator, version)
 
     formula = generator.render_formula(
         TEMPLATE.read_text(encoding="utf-8"), generator.native_replacements(version, assets)
@@ -59,3 +65,20 @@ def test_native_homebrew_formula_fails_when_asset_missing() -> None:
         assert "release asset missing" in str(exc)
     else:
         raise AssertionError("expected missing native asset to fail formula generation")
+
+
+def test_native_homebrew_formula_caveats_show_logo() -> None:
+    generator = load_generator()
+    version = "1.2.3"
+    assets = _fake_assets(generator, version)
+
+    formula = generator.render_formula(
+        TEMPLATE.read_text(encoding="utf-8"), generator.native_replacements(version, assets)
+    )
+
+    # Homebrew prints `caveats` after install — this is where the static robot
+    # logo (parity with install.sh / install.ps1) must live.
+    assert "def caveats" in formula
+    assert "pythinker code · your next CLI agent" in formula
+    # The robot-head mouth row is the most distinctive line of the art.
+    assert "▙▄▄▄≡▄▄▄▟" in formula