Skip to content

Commit 73a026a

Browse files
committed
test: make brew-warning string concatenation explicit
GitHub code-quality flagged implicit string concatenation of adjacent literals inside the list arguments to _homebrew_untrusted_tap (a common missing-comma footgun). Use explicit '+' so the single-line intent is unambiguous to readers and the scanner.
1 parent 87623b8 commit 73a026a

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

tests/ui_and_conv/test_shell_update.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1375,7 +1375,7 @@ def test_homebrew_untrusted_tap_ignores_unrelated_skip_warnings():
13751375
for taps that are not ours must not trigger the trust hint."""
13761376
lines = [
13771377
"Warning: Skipping mongodb/brew because it is not trusted. "
1378-
"Run `brew trust mongodb/brew` to trust it.",
1378+
+ "Run `brew trust mongodb/brew` to trust it.",
13791379
"Warning: Skipping oven-sh/bun because it is not trusted.",
13801380
]
13811381
assert update._homebrew_untrusted_tap(lines) is None
@@ -1384,7 +1384,7 @@ def test_homebrew_untrusted_tap_ignores_unrelated_skip_warnings():
13841384
def test_homebrew_untrusted_tap_accepts_own_tap_skip_warning():
13851385
lines = [
13861386
"Warning: Skipping pythoughts-labs/pythinker because it is not trusted. "
1387-
"Run `brew trust pythoughts-labs/pythinker` to trust it.",
1387+
+ "Run `brew trust pythoughts-labs/pythinker` to trust it.",
13881388
]
13891389
assert update._homebrew_untrusted_tap(lines) == "pythoughts-labs/pythinker"
13901390

0 commit comments

Comments
 (0)