Various card script fixes

- Agido the Ancient Sentinel: Sending another 5 cards from the top of either player's Deck to the GY shouldn't happen at the same time as the initial sending of the top 5 cards from each player's Deck to the GY.
- Armory Call: Adding the card to your hand and equipping it shouldn't happen at the same time.
- Automatic Laser: Shouldn't check that the summoned monster(s) is still face-up and has 1000 or more ATK on resolution.
- Backlinker: Should also shuffle face-down monsters into the Deck. Should exclude itself in the activation check when checking if there's a card to shuffle into the Deck for cases where a monster in the EMZ copies this card's effect.
- Beast King Unleashed: Shouldn't return if you don't control the monster on resolution.
- Code Hack: Shouldn't protect from your own effects.
- Disenchanter: Should remove a Spell Counter on resolution, not as cost.
- Doom-Z Zero - Drastia/Doom-Z Five - Amalthe/Doom-Z Seven - Elara: Don't allow their Xyz Summoning effects to be used if they're equipped with a Token.
- Evilswarm Coppelia: Its effect should activate even if there's no valid target since it's mandatory.
- Frightfur Cruel Whale: Added a hint timing for "before damage calculation" during your turn.
- Gearfried the Swordmaster: Shouldn't destroy the target if you control it on resolution.
- Junk Synchron: The effect negation should disappear immediately if the summoned monster is flipped face-down.
- Kashtira Shangri-Ira: Fixed an issue where the wrong zone would be blocked if control of this card had switched by the time the effect resolved.
- Mekk-Knight Blue Sky: Fixed an issue where it wasn't counting itself if the opponent controls it when its search effect resolves.
- Nightmare Throne: Fixed an issue where in some cases its effect would trigger in the next Chain.
- Penguin Torpedo: The effect negation and the "cannot attack" effect should disappear if the monster is flipped face-down or changes control again.
- Primordial Soup: Should be able to use its effect even if you have 0 cards in your Deck. Also check that the cards to shuffle are monsters.
- Super Soldier Soul: Fixed an issue where the effects would remain applied for longer than they should if control of this card changed.
- Tyrant's Tirade: Should prevent monsters that are unaffected by Traps from activating their effects.
- Various other small updates and fixes.

Author: pyrQ

official/c17679043.lua

@@ -3,78 +3,67 @@
 --scripted by Naim
 local s,id=GetID()
 function s.initial_effect(c)
-	--Caan attack directly
+	--This card can attack directly
 	local e1=Effect.CreateEffect(c)
 	e1:SetType(EFFECT_TYPE_SINGLE)
 	e1:SetCode(EFFECT_DIRECT_ATTACK)
 	c:RegisterEffect(e1)
-	--Take control of a target
+	--Take control of 1 Level 6 or lower monster your opponent controls until the End Phase, but its effects are negated, also it cannot declare an attack, while you control it
 	local e2=Effect.CreateEffect(c)
 	e2:SetDescription(aux.Stringid(id,0))
 	e2:SetCategory(CATEGORY_CONTROL)
 	e2:SetType(EFFECT_TYPE_SINGLE+EFFECT_TYPE_TRIGGER_O)
 	e2:SetProperty(EFFECT_FLAG_CARD_TARGET)
 	e2:SetCode(EVENT_BATTLE_DAMAGE)
 	e2:SetCountLimit(1,id)
-	e2:SetCondition(s.condition)
-	e2:SetTarget(s.target)
-	e2:SetOperation(s.operation)
+	e2:SetCondition(function(e,tp,eg,ep,ev,re,r,rp) return ep==1-tp end)
+	e2:SetTarget(s.ctrltg)
+	e2:SetOperation(s.ctrlop)
 	c:RegisterEffect(e2)
-	--destroy itself
+	--Destroy this card
 	local e3=Effect.CreateEffect(c)
 	e3:SetDescription(aux.Stringid(id,1))
 	e3:SetCategory(CATEGORY_DESTROY)
 	e3:SetType(EFFECT_TYPE_SINGLE+EFFECT_TYPE_TRIGGER_F)
 	e3:SetCode(EVENT_DAMAGE_STEP_END)
-	e3:SetCondition(s.descon)
+	e3:SetCondition(function(e) return e:GetHandler()==Duel.GetAttacker() end)
 	e3:SetTarget(s.destg)
 	e3:SetOperation(s.desop)
 	c:RegisterEffect(e3)
 end
-function s.condition(e,tp,eg,ep,ev,re,r,rp)
-	return ep==1-tp
+function s.ctrlfilter(c)
+	return c:IsLevelBelow(6) and c:IsFaceup() and c:IsControlerCanBeChanged()
 end
-function s.cfilter(c)
-	return c:IsFaceup() and c:HasLevel() and c:IsLevelBelow(6) and c:IsControlerCanBeChanged()
-end
-function s.target(e,tp,eg,ep,ev,re,r,rp,chk,chkc)
-	if chkc then return chkc:IsControler(1-tp) and s.cfilter(chkc) end
-	if chk==0 then return Duel.IsExistingTarget(s.cfilter,tp,0,LOCATION_MZONE,1,nil) end
+function s.ctrltg(e,tp,eg,ep,ev,re,r,rp,chk,chkc)
+	if chkc then return chkc:IsControler(1-tp) and s.ctrlfilter(chkc) end
+	if chk==0 then return Duel.IsExistingTarget(s.ctrlfilter,tp,0,LOCATION_MZONE,1,nil) end
 	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_CONTROL)
-	local g=Duel.SelectTarget(tp,s.cfilter,tp,0,LOCATION_MZONE,1,1,nil)
-	Duel.SetOperationInfo(0,CATEGORY_CONTROL,g,1,0,0)
+	local g=Duel.SelectTarget(tp,s.ctrlfilter,tp,0,LOCATION_MZONE,1,1,nil)
+	Duel.SetOperationInfo(0,CATEGORY_CONTROL,g,1,tp,0)
 end
-function s.operation(e,tp,eg,ep,ev,re,r,rp)
+function s.ctrlop(e,tp,eg,ep,ev,re,r,rp)
 	local tc=Duel.GetFirstTarget()
 	if tc:IsRelateToEffect(e) and Duel.GetControl(tc,tp,PHASE_END,1) then
 		local c=e:GetHandler()
+		--Its effects are negated while you control it
+		tc:NegateEffects(c,RESET_CONTROL)
+		--It cannot declare an attack while you control it
 		local e1=Effect.CreateEffect(c)
+		e1:SetDescription(3206)
 		e1:SetType(EFFECT_TYPE_SINGLE)
-		e1:SetCode(EFFECT_DISABLE)
-		e1:SetReset(RESET_EVENT|(RESETS_STANDARD&~RESET_TURN_SET)|RESET_PHASE|PHASE_END)
+		e1:SetProperty(EFFECT_FLAG_CANNOT_DISABLE+EFFECT_FLAG_CLIENT_HINT)
+		e1:SetCode(EFFECT_CANNOT_ATTACK)
+		e1:SetReset(RESET_EVENT|RESETS_STANDARD|RESET_CONTROL)
 		tc:RegisterEffect(e1)
-		local e2=Effect.CreateEffect(c)
-		e2:SetType(EFFECT_TYPE_SINGLE)
-		e2:SetCode(EFFECT_DISABLE_EFFECT)
-		e2:SetReset(RESET_EVENT|(RESETS_STANDARD&~RESET_TURN_SET)|RESET_PHASE|PHASE_END)
-		tc:RegisterEffect(e2)
-		local e3=Effect.CreateEffect(c)
-		e3:SetType(EFFECT_TYPE_SINGLE)
-		e3:SetCode(EFFECT_CANNOT_ATTACK)
-		e3:SetReset(RESET_EVENT|(RESETS_STANDARD&~RESET_TURN_SET)|RESET_PHASE|PHASE_END)
-		tc:RegisterEffect(e3)
 	end
 end
-function s.descon(e,tp,eg,ep,ev,re,r,rp)
-	return e:GetHandler()==Duel.GetAttacker()
-end
 function s.destg(e,tp,eg,ep,ev,re,r,rp,chk)
 	if chk==0 then return true end
-	Duel.SetOperationInfo(0,CATEGORY_DESTROY,e:GetHandler(),1,0,0)
+	Duel.SetOperationInfo(0,CATEGORY_DESTROY,e:GetHandler(),1,tp,0)
 end
 function s.desop(e,tp,eg,ep,ev,re,r,rp)
 	local c=e:GetHandler()
-	if c and c:IsRelateToEffect(e) then
+	if c:IsRelateToEffect(e) then
 		Duel.Destroy(c,REASON_EFFECT)
 	end
 end

official/c17749468.lua

@@ -66,14 +66,13 @@ end
 function s.selfspcon(e,c)
 	if not c then return true end
 	local tp=c:GetControler()
-	local mg=Duel.GetMatchingGroup(s.selfspcostfilter,tp,LOCATION_MZONE,LOCATION_MZONE,nil,tp,e:GetHandler())
+	local mg=Duel.GetMatchingGroup(s.selfspcostfilter,tp,LOCATION_MZONE,LOCATION_MZONE,nil,tp,c)
 	return #mg>=2 and aux.SelectUnselectGroup(mg,e,tp,2,2,s.rescon,0)
 end
 function s.selfsptg(e,tp,eg,ep,ev,re,r,rp,chk,c)
-	local mg=Duel.GetMatchingGroup(s.selfspcostfilter,tp,LOCATION_ONFIELD,LOCATION_MZONE,nil,tp,e:GetHandler())
+	local mg=Duel.GetMatchingGroup(s.selfspcostfilter,tp,LOCATION_MZONE,LOCATION_MZONE,nil,tp,c)
 	local g=aux.SelectUnselectGroup(mg,e,tp,2,2,s.rescon,1,tp,HINTMSG_RELEASE,nil,nil,true)
 	if #g>0 then
-		g:KeepAlive()
 		e:SetLabelObject(g)
 		return true
 	end
@@ -83,7 +82,6 @@ function s.selfspop(e,tp,eg,ep,ev,re,r,rp,c)
 	local g=e:GetLabelObject()
 	if not g then return end
 	Duel.Release(g,REASON_COST|REASON_MATERIAL)
-	g:DeleteGroup()
 end
 function s.atkop(e,tp,eg,ep,ev,re,r,rp)
 	if rp~=1-tp then return end

official/c19000848.lua

@@ -6,8 +6,8 @@ function s.initial_effect(c)
 	--Monsters in your leftmost or rightmost Main Monster Zones cannot be destroyed by card effects
 	local e1=Effect.CreateEffect(c)
 	e1:SetType(EFFECT_TYPE_FIELD)
-	e1:SetCode(EFFECT_INDESTRUCTABLE_EFFECT)
 	e1:SetProperty(EFFECT_FLAG_SET_AVAILABLE)
+	e1:SetCode(EFFECT_INDESTRUCTABLE_EFFECT)
 	e1:SetRange(LOCATION_MZONE)
 	e1:SetTargetRange(LOCATION_MZONE,0)
 	e1:SetTarget(function(e,c) return c:IsSequence(0,4) or (Duel.IsDuelType(DUEL_3_COLUMNS_FIELD) and c:IsSequence(1,3)) end)
@@ -76,4 +76,4 @@ function s.thop(e,tp,eg,ep,ev,re,r,rp)
 		Duel.SendtoHand(g,nil,REASON_EFFECT)
 		Duel.ConfirmCards(1-tp,g)
 	end
-end
+end

official/c20537097.lua

@@ -3,70 +3,62 @@
 --Scripted by Eerie Code
 local s,id=GetID()
 function s.initial_effect(c)
-	--Special Summon itself from hand
+	--If 2 or more cards are in the same column, you can Special Summon this card (from your hand) in that column
 	local e1=Effect.CreateEffect(c)
+	e1:SetDescription(aux.Stringid(id,0))
 	e1:SetType(EFFECT_TYPE_FIELD)
-	e1:SetCode(EFFECT_SPSUMMON_PROC)
 	e1:SetProperty(EFFECT_FLAG_UNCOPYABLE)
+	e1:SetCode(EFFECT_SPSUMMON_PROC)
 	e1:SetRange(LOCATION_HAND)
 	e1:SetCountLimit(1,id,EFFECT_COUNT_CODE_OATH)
-	e1:SetValue(s.hspval)
+	e1:SetValue(s.spval)
 	c:RegisterEffect(e1)
-	--If Normal or Special Summoned, add "Mekk-Knight" monster(s) from Deck
-	local e2=Effect.CreateEffect(c)
-	e2:SetDescription(aux.Stringid(id,0))
-	e2:SetCategory(CATEGORY_TOHAND+CATEGORY_SEARCH)
-	e2:SetType(EFFECT_TYPE_SINGLE+EFFECT_TYPE_TRIGGER_O)
-	e2:SetCode(EVENT_SUMMON_SUCCESS)
-	e2:SetProperty(EFFECT_FLAG_DELAY)
-	e2:SetCountLimit(1,{id,1})
-	e2:SetTarget(s.thtg)
-	e2:SetOperation(s.thop)
-	c:RegisterEffect(e2)
-	local e3=e2:Clone()
-	e3:SetCode(EVENT_SPSUMMON_SUCCESS)
-	e3:SetCondition(s.thcon)
-	c:RegisterEffect(e3)
+	--Add "Mekk-Knight" monsters with different names, except "Mekk-Knight Blue Sky", from your Deck to your hand, equal to the number of your opponent's cards in this card's column
+	local e2a=Effect.CreateEffect(c)
+	e2a:SetDescription(aux.Stringid(id,1))
+	e2a:SetCategory(CATEGORY_TOHAND+CATEGORY_SEARCH)
+	e2a:SetType(EFFECT_TYPE_SINGLE+EFFECT_TYPE_TRIGGER_O)
+	e2a:SetProperty(EFFECT_FLAG_DELAY)
+	e2a:SetCode(EVENT_SUMMON_SUCCESS)
+	e2a:SetCountLimit(1,{id,1})
+	e2a:SetCondition(function(e) return e:GetHandler():IsSummonLocation(LOCATION_HAND) end)
+	e2a:SetTarget(s.thtg)
+	e2a:SetOperation(s.thop)
+	c:RegisterEffect(e2a)
+	local e2b=e2a:Clone()
+	e2b:SetCode(EVENT_SPSUMMON_SUCCESS)
+	c:RegisterEffect(e2b)
 end
-s.listed_series={SET_MEKK_KNIGHT}
 s.listed_names={id}
-function s.cfilter(c)
-	return c:GetColumnGroupCount()>0
-end
-function s.hspval(e,c)
-	local tp=c:GetControler()
+s.listed_series={SET_MEKK_KNIGHT}
+function s.spval(e,c)
 	local zone=0
-	local lg=Duel.GetMatchingGroup(s.cfilter,tp,LOCATION_ONFIELD,LOCATION_ONFIELD,nil)
-	for tc in aux.Next(lg) do
+	local tp=c:GetControler()
+	local g=Duel.GetMatchingGroup(function(c) return c:GetColumnGroupCount()>0 end,0,LOCATION_ONFIELD,LOCATION_ONFIELD,nil)
+	for tc in g:Iter() do
 		zone=(zone|tc:GetColumnZone(LOCATION_MZONE,0,0,tp))
 	end
 	return 0,zone
 end
-function s.thcon(e,tp,eg,ep,ev,re,r,rp)
-	return e:GetHandler():IsPreviousLocation(LOCATION_HAND)
-end
 function s.thfilter(c)
 	return c:IsSetCard(SET_MEKK_KNIGHT) and c:IsMonster() and not c:IsCode(id) and c:IsAbleToHand()
 end
 function s.thtg(e,tp,eg,ep,ev,re,r,rp,chk)
-	local g=Duel.GetMatchingGroup(s.thfilter,tp,LOCATION_DECK,0,nil)
 	local ct=e:GetHandler():GetColumnGroup():FilterCount(Card.IsControler,nil,1-tp)
-	if chk==0 then return ct>0 and g:GetClassCount(Card.GetCode)>=ct end
+	if chk==0 then return ct>0 and Duel.GetMatchingGroup(s.thfilter,tp,LOCATION_DECK,0,nil):GetClassCount(Card.GetCode)>=ct end
 	Duel.SetOperationInfo(0,CATEGORY_TOHAND,nil,ct,tp,LOCATION_DECK)
 end
 function s.thop(e,tp,eg,ep,ev,re,r,rp)
 	local c=e:GetHandler()
 	if not c:IsRelateToEffect(e) then return end
 	local g=Duel.GetMatchingGroup(s.thfilter,tp,LOCATION_DECK,0,nil)
-	local ct=e:GetHandler():GetColumnGroup():FilterCount(Card.IsControler,nil,1-tp)
-	if ct<=0 or g:GetClassCount(Card.GetCode)<ct then return end
-	local hg=Group.CreateGroup()
-	for i=1,ct do
-		Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_ATOHAND)
-		local tc=g:Select(tp,1,1,nil):GetFirst()
-		hg:AddCard(tc)
-		g:Remove(Card.IsCode,nil,tc:GetCode())
+	if #g==0 then return end
+	local ct=c:GetColumnGroup():FilterCount(Card.IsControler,nil,1-tp)
+	if c:IsControler(1-tp) then ct=ct+1 end
+	if ct==0 or g:GetClassCount(Card.GetCode)<ct then return end
+	local sg=aux.SelectUnselectGroup(g,e,tp,ct,ct,aux.dncheck,1,tp,HINTMSG_ATOHAND)
+	if #sg>0 then
+		Duel.SendtoHand(sg,nil,REASON_EFFECT)
+		Duel.ConfirmCards(1-tp,sg)
 	end
-	Duel.SendtoHand(hg,nil,REASON_EFFECT)
-	Duel.ConfirmCards(1-tp,hg)
 end

official/c2377034.lua

@@ -2,7 +2,7 @@
 --Neo Flamvell Hedgehog
 local s,id=GetID()
 function s.initial_effect(c)
-	--Banish 1 card in your opponent's GY
+	--Banish 1 card from your opponent's GY
 	local e1=Effect.CreateEffect(c)
 	e1:SetDescription(aux.Stringid(id,0))
 	e1:SetCategory(CATEGORY_REMOVE)
@@ -12,52 +12,49 @@ function s.initial_effect(c)
 	e1:SetTarget(s.rmtg)
 	e1:SetOperation(s.rmop)
 	c:RegisterEffect(e1)
-	--Add to your hand 1 FIRE monster with 200 or less DEF from your GY
+	--Add 1 FIRE monster with 200 or less DEF except "Neo Flamvell Hedgehog" from your GY to your hand
 	local e2=Effect.CreateEffect(c)
 	e2:SetDescription(aux.Stringid(id,1))
 	e2:SetCategory(CATEGORY_TOHAND)
 	e2:SetType(EFFECT_TYPE_SINGLE+EFFECT_TYPE_TRIGGER_F)
 	e2:SetProperty(EFFECT_FLAG_CARD_TARGET)
-	e2:SetCode(EVENT_LEAVE_FIELD)
-	e2:SetCondition(s.thcon)
+	e2:SetCode(EVENT_DESTROYED)
+	e2:SetCondition(function(e) local c=e:GetHandler() return c:IsPreviousLocation(LOCATION_ONFIELD) and c:IsReason(REASON_EFFECT) end)
 	e2:SetTarget(s.thtg)
 	e2:SetOperation(s.thop)
 	c:RegisterEffect(e2)
 end
 s.listed_names={id}
-function s.rmfilter(c)
-	return c:IsAbleToRemove() and aux.SpElimFilter(c)
-end
 function s.rmtg(e,tp,eg,ep,ev,re,r,rp,chk,chkc)
-	if chkc then return chkc:IsLocation(LOCATION_MZONE|LOCATION_GRAVE) and chkc:IsControler(1-tp) and s.rmfilter(chkc) end
+	if chkc then return chkc:IsLocation(LOCATION_GRAVE) and chkc:IsControler(1-tp) and chkc:IsAbleToRemove() end
 	if chk==0 then return true end
 	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_REMOVE)
-	local g=Duel.SelectTarget(tp,s.rmfilter,tp,0,LOCATION_MZONE|LOCATION_GRAVE,1,1,nil)
-	Duel.SetOperationInfo(0,CATEGORY_REMOVE,g,#g,0,0)
+	local g=Duel.SelectTarget(tp,Card.IsAbleToRemove,tp,0,LOCATION_GRAVE,1,1,nil)
+	if #g>0 then
+		Duel.SetOperationInfo(0,CATEGORY_REMOVE,g,1,tp,0)
+	end
 end
 function s.rmop(e,tp,eg,ep,ev,re,r,rp)
 	local tc=Duel.GetFirstTarget()
 	if tc and tc:IsRelateToEffect(e) then
 		Duel.Remove(tc,POS_FACEUP,REASON_EFFECT)
 	end
 end
-function s.thcon(e,tp,eg,ep,ev,re,r,rp)
-	return (e:GetHandler():GetReason()&(REASON_DESTROY|REASON_EFFECT))==(REASON_DESTROY|REASON_EFFECT)
-end
-function s.filter(c)
-	return c:IsDefenseBelow(200) and c:IsAttribute(ATTRIBUTE_FIRE) and c:IsAbleToHand() and not c:IsCode(id)
+function s.thfilter(c)
+	return c:IsAttribute(ATTRIBUTE_FIRE) and c:IsDefenseBelow(200) and not c:IsCode(id) and c:IsAbleToHand()
 end
 function s.thtg(e,tp,eg,ep,ev,re,r,rp,chk,chkc)
-	if chkc then return chkc:IsLocation(LOCATION_GRAVE) and chkc:IsControler(tp) and s.filter(chkc) end
+	if chkc then return chkc:IsLocation(LOCATION_GRAVE) and chkc:IsControler(tp) and s.thfilter(chkc) end
 	if chk==0 then return true end
 	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_ATOHAND)
-	local g=Duel.SelectTarget(tp,s.filter,tp,LOCATION_GRAVE,0,1,1,nil)
-	Duel.SetOperationInfo(0,CATEGORY_TOHAND,g,#g,0,0)
+	local g=Duel.SelectTarget(tp,s.thfilter,tp,LOCATION_GRAVE,0,1,1,nil)
+	if #g>0 then
+		Duel.SetOperationInfo(0,CATEGORY_TOHAND,g,1,tp,0)
+	end
 end
 function s.thop(e,tp,eg,ep,ev,re,r,rp)
 	local tc=Duel.GetFirstTarget()
-	if tc and tc:IsRelateToEffect(e) then
+	if tc and tc:IsRelateToEffect(e) and tc:IsAttribute(ATTRIBUTE_FIRE) then
 		Duel.SendtoHand(tc,nil,REASON_EFFECT)
-		Duel.ConfirmCards(1-tp,tc)
 	end
 end