Skip to content

Commit b28c8bd

Browse files
sanjacorneliussanjacornelius
committed
CS Fixer: Fix file formatting
1 parent 56a7785 commit b28c8bd

5 files changed

Lines changed: 52 additions & 51 deletions

File tree

‎ProcessMaker/Http/Middleware/HideServerHeaders.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ class HideServerHeaders
5555
/**
5656
* Handle an incoming request.
5757
*
58-
* @param \Closure(\Illuminate\Http\Request): (\Symfony\Component\HttpFoundation\Response) $next
58+
* @param Closure(Request): (Response) $next
5959
*/
6060
public function handle(Request $request, Closure $next): Response
6161
{

‎ProcessMaker/Http/Middleware/IsManager.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ class IsManager
1313
/**
1414
* Handle an incoming request.
1515
*
16-
* @param \Closure(\Illuminate\Http\Request): (\Symfony\Component\HttpFoundation\Response) $next
16+
* @param Closure(Request): (Response) $next
1717
*/
1818
public function handle(Request $request, Closure $next): Response
1919
{

‎routes/channels.php‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
23
/*
34
|--------------------------------------------------------------------------
45
| Broadcast Channels

‎tests/Feature/Api/TaskControllerTest.php‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -254,10 +254,10 @@ public function testShowTaskIncludesNewProperty()
254254
$user = User::factory()->create();
255255
$this->actingAs($user);
256256

257-
$comments = "This is a comment";
257+
$comments = 'This is a comment';
258258

259259
$task = ProcessRequestToken::factory()->create([
260-
"comments" => $comments
260+
'comments' => $comments,
261261
]);
262262

263263
$this->assertEquals($comments, $task->comments);

‎tests/unit/ProcessMaker/Models/ProcessTest.php‎

Lines changed: 47 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,12 @@ public function testGetAssignableUsersByAssignmentTypeWithManagerOnlyRules()
4242
{
4343
$manager1 = User::factory()->create(['status' => 'ACTIVE']);
4444
$manager2 = User::factory()->create(['status' => 'ACTIVE']);
45-
45+
4646
// Create process with multiple managers (array)
4747
$process = Process::factory()->create([
48-
'properties' => ['manager_id' => [$manager1->id, $manager2->id]]
48+
'properties' => ['manager_id' => [$manager1->id, $manager2->id]],
4949
]);
50-
50+
5151
$request = ProcessRequest::factory()->create(['process_id' => $process->id]);
5252
$token = ProcessRequestToken::factory()->create([
5353
'process_id' => $process->id,
@@ -57,13 +57,13 @@ public function testGetAssignableUsersByAssignmentTypeWithManagerOnlyRules()
5757

5858
// Mock getAssignmentRule to return different manager-only rules
5959
$managerOnlyRules = ['previous_task_assignee', 'requester', 'process_manager'];
60-
60+
6161
foreach ($managerOnlyRules as $rule) {
6262
$tokenMock = Mockery::mock($token)->makePartial();
6363
$tokenMock->shouldReceive('getAssignmentRule')->andReturn($rule);
64-
64+
6565
$result = $process->getAssignableUsersByAssignmentType($tokenMock);
66-
66+
6767
// Should return both managers
6868
$this->assertIsArray($result);
6969
$this->assertCount(2, $result);
@@ -78,12 +78,12 @@ public function testGetAssignableUsersByAssignmentTypeWithManagerOnlyRules()
7878
public function testGetAssignableUsersByAssignmentTypeWithSingleManager()
7979
{
8080
$manager = User::factory()->create(['status' => 'ACTIVE']);
81-
81+
8282
// Create process with single manager (not array)
8383
$process = Process::factory()->create([
84-
'properties' => ['manager_id' => $manager->id]
84+
'properties' => ['manager_id' => $manager->id],
8585
]);
86-
86+
8787
$request = ProcessRequest::factory()->create(['process_id' => $process->id]);
8888
$token = ProcessRequestToken::factory()->create([
8989
'process_id' => $process->id,
@@ -92,9 +92,9 @@ public function testGetAssignableUsersByAssignmentTypeWithSingleManager()
9292

9393
$tokenMock = Mockery::mock($token)->makePartial();
9494
$tokenMock->shouldReceive('getAssignmentRule')->andReturn('process_manager');
95-
95+
9696
$result = $process->getAssignableUsersByAssignmentType($tokenMock);
97-
97+
9898
$this->assertIsArray($result);
9999
$this->assertCount(1, $result);
100100
$this->assertContains($manager->id, $result);
@@ -108,43 +108,43 @@ public function testGetAssignableUsersByAssignmentTypeWithGroupBasedRules()
108108
$manager = User::factory()->create(['status' => 'ACTIVE']);
109109
$assignableUser1 = User::factory()->create(['status' => 'ACTIVE']);
110110
$assignableUser2 = User::factory()->create(['status' => 'ACTIVE']);
111-
111+
112112
$process = Process::factory()->create([
113-
'properties' => ['manager_id' => $manager->id]
113+
'properties' => ['manager_id' => $manager->id],
114114
]);
115-
115+
116116
$request = ProcessRequest::factory()->create(['process_id' => $process->id]);
117117
$elementId = 'test_element_' . uniqid();
118-
118+
119119
// Create task assignments
120120
ProcessTaskAssignment::factory()->create([
121121
'process_id' => $process->id,
122122
'process_task_id' => $elementId,
123123
'assignment_id' => $assignableUser1->id,
124124
'assignment_type' => User::class,
125125
]);
126-
126+
127127
ProcessTaskAssignment::factory()->create([
128128
'process_id' => $process->id,
129129
'process_task_id' => $elementId,
130130
'assignment_id' => $assignableUser2->id,
131131
'assignment_type' => User::class,
132132
]);
133-
133+
134134
$token = ProcessRequestToken::factory()->create([
135135
'process_id' => $process->id,
136136
'process_request_id' => $request->id,
137137
'element_id' => $elementId,
138138
]);
139139

140140
$groupBasedRules = ['user_group', 'process_variable', 'rule_expression'];
141-
141+
142142
foreach ($groupBasedRules as $rule) {
143143
$tokenMock = Mockery::mock($token)->makePartial();
144144
$tokenMock->shouldReceive('getAssignmentRule')->andReturn($rule);
145-
145+
146146
$result = $process->getAssignableUsersByAssignmentType($tokenMock);
147-
147+
148148
// Should return assignable users + manager
149149
$this->assertIsArray($result);
150150
$this->assertCount(3, $result);
@@ -160,11 +160,11 @@ public function testGetAssignableUsersByAssignmentTypeWithGroupBasedRules()
160160
public function testGetAssignableUsersByAssignmentTypeWithEmptyElementId()
161161
{
162162
$manager = User::factory()->create(['status' => 'ACTIVE']);
163-
163+
164164
$process = Process::factory()->create([
165-
'properties' => ['manager_id' => $manager->id]
165+
'properties' => ['manager_id' => $manager->id],
166166
]);
167-
167+
168168
$request = ProcessRequest::factory()->create(['process_id' => $process->id]);
169169
$token = ProcessRequestToken::factory()->create([
170170
'process_id' => $process->id,
@@ -174,9 +174,9 @@ public function testGetAssignableUsersByAssignmentTypeWithEmptyElementId()
174174

175175
$tokenMock = Mockery::mock($token)->makePartial();
176176
$tokenMock->shouldReceive('getAssignmentRule')->andReturn('user_group');
177-
177+
178178
$result = $process->getAssignableUsersByAssignmentType($tokenMock);
179-
179+
180180
// Should only return manager when element_id is empty
181181
$this->assertIsArray($result);
182182
$this->assertCount(1, $result);
@@ -189,9 +189,9 @@ public function testGetAssignableUsersByAssignmentTypeWithEmptyElementId()
189189
public function testGetAssignableUsersByAssignmentTypeWithNullManager()
190190
{
191191
$process = Process::factory()->create([
192-
'properties' => ['manager_id' => null]
192+
'properties' => ['manager_id' => null],
193193
]);
194-
194+
195195
$request = ProcessRequest::factory()->create(['process_id' => $process->id]);
196196
$token = ProcessRequestToken::factory()->create([
197197
'process_id' => $process->id,
@@ -200,9 +200,9 @@ public function testGetAssignableUsersByAssignmentTypeWithNullManager()
200200

201201
$tokenMock = Mockery::mock($token)->makePartial();
202202
$tokenMock->shouldReceive('getAssignmentRule')->andReturn('process_manager');
203-
203+
204204
$result = $process->getAssignableUsersByAssignmentType($tokenMock);
205-
205+
206206
// Should return empty array when manager_id is null
207207
$this->assertIsArray($result);
208208
$this->assertEmpty($result);
@@ -214,11 +214,11 @@ public function testGetAssignableUsersByAssignmentTypeWithNullManager()
214214
public function testGetAssignableUsersByAssignmentTypeWithUnknownRule()
215215
{
216216
$manager = User::factory()->create(['status' => 'ACTIVE']);
217-
217+
218218
$process = Process::factory()->create([
219-
'properties' => ['manager_id' => $manager->id]
219+
'properties' => ['manager_id' => $manager->id],
220220
]);
221-
221+
222222
$request = ProcessRequest::factory()->create(['process_id' => $process->id]);
223223
$token = ProcessRequestToken::factory()->create([
224224
'process_id' => $process->id,
@@ -227,9 +227,9 @@ public function testGetAssignableUsersByAssignmentTypeWithUnknownRule()
227227

228228
$tokenMock = Mockery::mock($token)->makePartial();
229229
$tokenMock->shouldReceive('getAssignmentRule')->andReturn('unknown_rule');
230-
230+
231231
$result = $process->getAssignableUsersByAssignmentType($tokenMock);
232-
232+
233233
// Should return empty array for unknown rules
234234
$this->assertIsArray($result);
235235
$this->assertEmpty($result);
@@ -242,13 +242,13 @@ public function testGetAssignableUsersByAssignmentTypeHandlesNestedArrays()
242242
{
243243
$manager1 = User::factory()->create(['status' => 'ACTIVE']);
244244
$manager2 = User::factory()->create(['status' => 'ACTIVE']);
245-
245+
246246
// Simulate nested array scenario (shouldn't happen but test the normalization)
247247
// Note: The accessor will normalize this, but we test the normalization logic
248248
$process = Process::factory()->create([
249-
'properties' => ['manager_id' => [[$manager1->id], [$manager2->id]]]
249+
'properties' => ['manager_id' => [[$manager1->id], [$manager2->id]]],
250250
]);
251-
251+
252252
$request = ProcessRequest::factory()->create(['process_id' => $process->id]);
253253
$token = ProcessRequestToken::factory()->create([
254254
'process_id' => $process->id,
@@ -257,9 +257,9 @@ public function testGetAssignableUsersByAssignmentTypeHandlesNestedArrays()
257257

258258
$tokenMock = Mockery::mock($token)->makePartial();
259259
$tokenMock->shouldReceive('getAssignmentRule')->andReturn('process_manager');
260-
260+
261261
$result = $process->getAssignableUsersByAssignmentType($tokenMock);
262-
262+
263263
// Should flatten and return both managers
264264
$this->assertIsArray($result);
265265
$this->assertCount(2, $result);
@@ -278,29 +278,29 @@ public function testGetAssignableUsersByAssignmentTypeRemovesDuplicates()
278278
{
279279
$manager = User::factory()->create(['status' => 'ACTIVE']);
280280
$assignableUser = User::factory()->create(['status' => 'ACTIVE']);
281-
281+
282282
$process = Process::factory()->create([
283-
'properties' => ['manager_id' => $manager->id]
283+
'properties' => ['manager_id' => $manager->id],
284284
]);
285-
285+
286286
$request = ProcessRequest::factory()->create(['process_id' => $process->id]);
287287
$elementId = 'test_element_' . uniqid();
288-
288+
289289
// Create task assignment with manager as assignable user (duplicate scenario)
290290
ProcessTaskAssignment::factory()->create([
291291
'process_id' => $process->id,
292292
'process_task_id' => $elementId,
293293
'assignment_id' => $manager->id, // Same as manager
294294
'assignment_type' => User::class,
295295
]);
296-
296+
297297
ProcessTaskAssignment::factory()->create([
298298
'process_id' => $process->id,
299299
'process_task_id' => $elementId,
300300
'assignment_id' => $assignableUser->id,
301301
'assignment_type' => User::class,
302302
]);
303-
303+
304304
$token = ProcessRequestToken::factory()->create([
305305
'process_id' => $process->id,
306306
'process_request_id' => $request->id,
@@ -309,9 +309,9 @@ public function testGetAssignableUsersByAssignmentTypeRemovesDuplicates()
309309

310310
$tokenMock = Mockery::mock($token)->makePartial();
311311
$tokenMock->shouldReceive('getAssignmentRule')->andReturn('user_group');
312-
312+
313313
$result = $process->getAssignableUsersByAssignmentType($tokenMock);
314-
314+
315315
// Should return unique values (manager should appear only once)
316316
$this->assertIsArray($result);
317317
$this->assertCount(2, $result); // manager + assignableUser (no duplicates)

0 commit comments

Comments
 (0)