Enhance error handling and message display

Added error handling for missing download URL and certificate selection. Introduced a timer to hide temporary error messages after 5 seconds.

Author: NovaDev404

Sources/prostore/signing/DownloadSignManager.swift

@@ -7,37 +7,60 @@ class DownloadSignManager: ObservableObject {
     @Published var status: String = ""
     @Published var isProcessing: Bool = false
     @Published var showSuccess: Bool = false
-    
+   
     private var downloadTask: URLSessionDownloadTask?
     private var cancellables = Set<AnyCancellable>()
-    
+    private var hideTimer: Timer?
+   
     func downloadAndSign(app: AltApp) {
         guard let downloadURL = app.downloadURL else {
-            self.status = "No download URL available"
+            self.showTemporaryError("No download URL available")
             return
         }
-        
+       
         guard let selectedCertFolder = UserDefaults.standard.string(forKey: "selectedCertificateFolder") else {
-            self.status = "No certificate selected"
+            self.showTemporaryError("Please add and select a certificate first!")
             return
         }
-        
+       
         self.isProcessing = true
         self.progress = 0.0
         self.status = "Starting download..."
         self.showSuccess = false
-        
+       
         DispatchQueue.global(qos: .userInitiated).async {
             self.performDownloadAndSign(downloadURL: downloadURL, appName: app.name, certFolder: selectedCertFolder)
         }
     }
 
+    private func showTemporaryError(_ message: String) {
+        DispatchQueue.main.async {
+            self.isProcessing = true
+            self.progress = 0.0
+            self.status = message
+            self.showSuccess = false
+            
+            // Cancel any existing timer
+            self.hideTimer?.invalidate()
+            
+            // Hide the bar after 5 seconds
+            self.hideTimer = Timer.scheduledTimer(withTimeInterval: 5.0, repeats: false) { _ in
+                DispatchQueue.main.async {
+                    self.isProcessing = false
+                    self.progress = 0.0
+                    self.status = ""
+                    self.showSuccess = false
+                }
+            }
+        }
+    }
+   
     private func performDownloadAndSign(downloadURL: URL, appName: String, certFolder: String) {
         // Step 1: Setup directories
         let fm = FileManager.default
         let appFolder = self.getAppFolder()
         let tempDir = appFolder.appendingPathComponent("temp")
-        
+       
         do {
             if !fm.fileExists(atPath: tempDir.path) {
                 try fm.createDirectory(at: tempDir, withIntermediateDirectories: true)
@@ -49,13 +72,13 @@ class DownloadSignManager: ObservableObject {
             }
             return
         }
-        
+       
         let tempIPAURL = tempDir.appendingPathComponent("\(UUID().uuidString).ipa")
-        
+       
         // Step 2: Download the IPA
         self.downloadIPA(from: downloadURL, to: tempIPAURL) { [weak self] result in
             guard let self = self else { return }
-            
+           
             switch result {
             case .success:
                 // Step 3: Get certificate files
@@ -66,38 +89,38 @@ class DownloadSignManager: ObservableObject {
                     }
                     return
                 }
-                
+               
                 // Step 4: Sign the IPA
                 self.signIPA(ipaURL: tempIPAURL, p12URL: p12URL, provURL: provURL, password: password, appName: appName)
-                
+               
             case .failure(let error):
                 DispatchQueue.main.async {
                     self.status = "Download failed: \(error.localizedDescription)"
                     self.isProcessing = false
                 }
-                
+               
                 // Clean up temp file if it exists
                 try? fm.removeItem(at: tempIPAURL)
             }
         }
     }
-    
+   
     private func downloadIPA(from url: URL, to destination: URL, completion: @escaping (Result<Void, Error>) -> Void) {
         let semaphore = DispatchSemaphore(value: 0)
-        
+       
         let task = URLSession.shared.downloadTask(with: url) { tempURL, response, error in
             defer { semaphore.signal() }
-            
+           
             if let error = error {
                 completion(.failure(error))
                 return
             }
-            
+           
             guard let tempURL = tempURL else {
                 completion(.failure(NSError(domain: "Download", code: -1, userInfo: [NSLocalizedDescriptionKey: "No temp URL returned"])))
                 return
             }
-            
+           
             do {
                 let fm = FileManager.default
                 if fm.fileExists(atPath: destination.path) {
@@ -109,7 +132,7 @@ class DownloadSignManager: ObservableObject {
                 completion(.failure(error))
             }
         }
-        
+       
         // Observe download progress
         var observation: NSKeyValueObservation?
         observation = task.progress.observe(\.fractionCompleted) { [weak self] progress, _ in
@@ -120,103 +143,104 @@ class DownloadSignManager: ObservableObject {
                 self?.status = "Downloading... (\(percent)%)"
             }
         }
-        
+       
         self.downloadTask = task
         task.resume()
-        
+       
         // Wait for download to complete
         DispatchQueue.global(qos: .userInitiated).async {
             semaphore.wait()
             observation?.invalidate()
         }
     }
-
-        private func getCertificateFiles(for folderName: String) -> (p12URL: URL, provURL: URL, password: String)? {
+    
+    private func getCertificateFiles(for folderName: String) -> (p12URL: URL, provURL: URL, password: String)? {
         let fm = FileManager.default
         let certsDir = CertificateFileManager.shared.certificatesDirectory.appendingPathComponent(folderName)
-        
+       
         let p12URL = certsDir.appendingPathComponent("certificate.p12")
         let provURL = certsDir.appendingPathComponent("profile.mobileprovision")
         let passwordURL = certsDir.appendingPathComponent("password.txt")
-        
+       
         guard fm.fileExists(atPath: p12URL.path),
               fm.fileExists(atPath: provURL.path),
               fm.fileExists(atPath: passwordURL.path) else {
             return nil
         }
-        
+       
         do {
             let password = try String(contentsOf: passwordURL, encoding: .utf8).trimmingCharacters(in: .whitespacesAndNewlines)
             return (p12URL, provURL, password)
         } catch {
             return nil
         }
     }
-    
-private func signIPA(ipaURL: URL, p12URL: URL, provURL: URL, password: String, appName: String) {
-    DispatchQueue.main.async {
-        self.status = "Starting signing process..."
-        self.progress = 0.5
-    }
-    
-    signer.sign(
-        ipaURL: ipaURL,
-        p12URL: p12URL,
-        provURL: provURL,
-        p12Password: password,
-        progressUpdate: { [weak self] status, progress in
-            DispatchQueue.main.async {
-                let overallProgress = 0.5 + (progress * 0.5)
-                self?.progress = overallProgress
-                let percent = Int(overallProgress * 100)
-                self?.status = "\(status) (\(percent)%)"
-            }
-        },
-        completion: { [weak self] result in
-            DispatchQueue.main.async {
-                switch result {
-                case .success(let signedIPAURL):
-                    self?.progress = 1.0
-                    self?.status = "✅ Successfully signed ipa! Installing app now..."
-                    self?.showSuccess = true
-                    
-                    Task {
-                        do {
-                            try await installApp(from: signedIPAURL)
-                        } catch {
-                            self?.status = "❌ Install failed: \(error.localizedDescription)"
+   
+    private func signIPA(ipaURL: URL, p12URL: URL, provURL: URL, password: String, appName: String) {
+        DispatchQueue.main.async {
+            self.status = "Starting signing process..."
+            self.progress = 0.5
+        }
+   
+        signer.sign(
+            ipaURL: ipaURL,
+            p12URL: p12URL,
+            provURL: provURL,
+            p12Password: password,
+            progressUpdate: { [weak self] status, progress in
+                DispatchQueue.main.async {
+                    let overallProgress = 0.5 + (progress * 0.5)
+                    self?.progress = overallProgress
+                    let percent = Int(overallProgress * 100)
+                    self?.status = "\(status) (\(percent)%)"
+                }
+            },
+            completion: { [weak self] result in
+                DispatchQueue.main.async {
+                    switch result {
+                    case .success(let signedIPAURL):
+                        self?.progress = 1.0
+                        self?.status = "✅ Successfully signed ipa! Installing app now..."
+                        self?.showSuccess = true
+                       
+                        Task {
+                            do {
+                                try await installApp(from: signedIPAURL)
+                            } catch {
+                                self?.status = "❌ Install failed: \(error.localizedDescription)"
+                            }
                         }
-                    }
-
-                    DispatchQueue.main.asyncAfter(deadline: .now() + 3) {
+                        DispatchQueue.main.asyncAfter(deadline: .now() + 3) {
+                            self?.isProcessing = false
+                            self?.showSuccess = false
+                            self?.progress = 0.0
+                            self?.status = ""
+                        }
+                       
+                        // Clean up original downloaded IPA
+                        try? FileManager.default.removeItem(at: ipaURL)
+                       
+                    case .failure(let error):
+                        self?.status = "❌ Signing failed: \(error.localizedDescription)"
                         self?.isProcessing = false
-                        self?.showSuccess = false
-                        self?.progress = 0.0
-                        self?.status = ""
+                        try? FileManager.default.removeItem(at: ipaURL)
                     }
-                    
-                    // Clean up original downloaded IPA
-                    try? FileManager.default.removeItem(at: ipaURL)
-                    
-                case .failure(let error):
-                    self?.status = "❌ Signing failed: \(error.localizedDescription)"
-                    self?.isProcessing = false
-                    try? FileManager.default.removeItem(at: ipaURL)
                 }
             }
-        }
-    )
-}
-    
+        )
+    }
+   
     func cancel() {
         downloadTask?.cancel()
+        hideTimer?.invalidate()
         DispatchQueue.main.async {
             self.isProcessing = false
             self.status = "Cancelled"
             self.progress = 0.0
+            self.showSuccess = false
         }
     }
-    
+   
     private func getAppFolder() -> URL {
         let fm = FileManager.default
         let documents = fm.urls(for: .documentDirectory, in: .userDomainMask).first!
@@ -226,6 +250,4 @@ private func signIPA(ipaURL: URL, p12URL: URL, provURL: URL, password: String, a
         }
         return appFolder
     }
-
 }
-