From fd8064c41f2f04f30d485abad10917eb9fdf1413 Mon Sep 17 00:00:00 2001 From: jewinters Date: Fri, 18 Mar 2016 14:58:56 -0400 Subject: [PATCH] Changing UnitTestProcessor to accept List of File objects --- .../testProcessor/UnitTestProcessor.java | 11 ++++++++++- .../testProcessor/UnitTestProcessorTest.java | 16 ++++++++++------ 2 files changed, 20 insertions(+), 7 deletions(-) diff --git a/src/kataAnalyzer/testProcessor/UnitTestProcessor.java b/src/kataAnalyzer/testProcessor/UnitTestProcessor.java index 63cc584..f21fda0 100644 --- a/src/kataAnalyzer/testProcessor/UnitTestProcessor.java +++ b/src/kataAnalyzer/testProcessor/UnitTestProcessor.java @@ -1,5 +1,9 @@ package kataAnalyzer.testProcessor; +import org.apache.commons.io.FilenameUtils; + +import java.io.File; +import java.util.ArrayList; import java.util.List; /** @@ -10,7 +14,12 @@ public class UnitTestProcessor { UnitTestRunner testRunner = new UnitTestRunner(); UnitTestResultsAnalyzer testResultsAnalyzer = new UnitTestResultsAnalyzer(); - public boolean process(List testFiles, String path) { + public boolean process(List fileList, String path) { + List testFiles = new ArrayList<>(); + + for ( int i = 0; i < fileList.size(); i++) { + testFiles.add(FilenameUtils.removeExtension(fileList.get(i).getName())); + } boolean unitTestsPassed = true; diff --git a/srcTest/kataAnalyzer/testProcessor/UnitTestProcessorTest.java b/srcTest/kataAnalyzer/testProcessor/UnitTestProcessorTest.java index aa07d8f..dc60a02 100644 --- a/srcTest/kataAnalyzer/testProcessor/UnitTestProcessorTest.java +++ b/srcTest/kataAnalyzer/testProcessor/UnitTestProcessorTest.java @@ -2,6 +2,8 @@ import org.junit.Before; import org.junit.Test; + +import java.io.File; import java.util.List; import java.util.ArrayList; import org.junit.Assert; @@ -12,8 +14,10 @@ public class UnitTestProcessorTest { UnitTestProcessor testProcessor; - List testFiles; + List testFiles; final String testClassPath = "../../out/test/kataAnalyzer"; + File successFile = new File(testClassPath + "/SuccessTests.class"); + File failFile = new File(testClassPath + "/FailureTests.class"); @Before public void getUnitTestProcessor() { @@ -21,7 +25,7 @@ public void getUnitTestProcessor() { } @Before public void getTestFilesList() { - testFiles = new ArrayList(); + testFiles = new ArrayList<>(); } @Test @@ -31,8 +35,8 @@ public void itReturnsFalseWhenNoTestFilesArePassed() { @Test public void itReturnsTrueWhenAllTestFilesPass() { - testFiles.add("SuccessTests"); - testFiles.add("SuccessTests"); + testFiles.add(successFile); + testFiles.add(successFile); Assert.assertTrue( testProcessor.process(testFiles, testClassPath) ); @@ -40,8 +44,8 @@ public void itReturnsTrueWhenAllTestFilesPass() { @Test public void itReturnsFalseWhenAnyTestFileFails() { - testFiles.add("FailureTest"); - testFiles.add("SuccessTest"); + testFiles.add(failFile); + testFiles.add(successFile); Assert.assertFalse( testProcessor.process(testFiles, testClassPath) ); }