From 8f33d207385adf166c294c1de4db0b7387109f08 Mon Sep 17 00:00:00 2001 From: Jason Millard Date: Mon, 13 Apr 2026 12:29:56 -0400 Subject: [PATCH] build: fix CMake from always enabling address sanitizer on macos --- CMakeLists.txt | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index c16d9ba..ff9bf5c 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -14,12 +14,7 @@ message(STATUS "BUILD_SHARED: ${BUILD_SHARED}") message(STATUS "BUILD_STATIC: ${BUILD_STATIC}") message(STATUS "ENABLE_SANITIZERS: ${ENABLE_SANITIZERS}") -if(PLATFORM STREQUAL "macos") - if(CMAKE_BUILD_TYPE STREQUAL "Debug") - set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=address -g") - set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fsanitize=address -g") - endif() -elseif(PLATFORM STREQUAL "ios" OR PLATFORM STREQUAL "ios-simulator") +if(PLATFORM STREQUAL "ios" OR PLATFORM STREQUAL "ios-simulator") set(CMAKE_SYSTEM_NAME iOS) if (PLATFORM STREQUAL "ios-simulator") set(CMAKE_OSX_SYSROOT iphonesimulator) @@ -88,11 +83,9 @@ set(CMAKE_C_VISIBILITY_PRESET hidden) if(CMAKE_BUILD_TYPE STREQUAL "Debug") if(ENABLE_SANITIZERS AND (PLATFORM STREQUAL "macos" OR PLATFORM STREQUAL "linux")) - add_compile_options(-fsanitize=address) - add_link_options(-fsanitize=address) - - add_compile_options(-fsanitize=undefined) - add_link_options(-fsanitize=undefined) + set(SANITIZER_FLAGS -fsanitize=address,undefined) + add_compile_options(${SANITIZER_FLAGS} -fno-omit-frame-pointer -g) + add_link_options(${SANITIZER_FLAGS}) endif() endif()