Skip to content

Commit 7fecc1d

Browse files
committed
fix: verify Windows packaged app startup directly
1 parent e9d64f9 commit 7fecc1d

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

‎doc/ci-release.md‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ Windows x64, and Linux x64. The check uses a temporary user-data directory,
1414
waits for a visible main window and the real renderer's startup-ready marker,
1515
then exits cleanly. Startup failures, renderer crashes, early exits, and timeouts
1616
fail the workflow. It does not test translation, PDF interaction, or other features.
17-
Linux uses Xvfb. The cross-built ia32 and ARMv7 packages are compiled but are not
17+
Windows launches the bundled main executable directly because the portable
18+
launcher does not forward its child process stdout. Linux uses Xvfb. The cross-built ia32 and ARMv7 packages are compiled but are not
1819
separately launched on the x64 runners.
1920

2021
## Release workflow

‎electron/launch-check.mjs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ async function resolveExecutable(platform, arch) {
7575
join(releaseRoot, `${name}.app`, 'Contents', 'MacOS', 'PDFMathReader'),
7676
]
7777
: platform === 'win32'
78-
? [join(releaseRoot, `${name}.exe`), join(packageRoot, 'PDFMathReader.exe')]
78+
? [join(packageRoot, 'PDFMathReader.exe')]
7979
: [join(packageRoot, 'PDFMathReader')];
8080
for (const candidate of candidates) if (await isFile(candidate)) return candidate;
8181
throw Error(

0 commit comments

Comments
 (0)